NewInstitutionConfigurationCreatedEvent::__construct() - Code Metrics - Inspection of "Add authorization projection without serialized in..." - OpenConext/Stepup-Middleware - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#236)

unknown

created 2018-09-27 11:31 UTC

__construct() A

↳ Parent: NewInstitutionConfigurationCreatedEvent

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	21
rs	9.584
c	0
b	0
f	0
cc	1
nc	1
nop	9

How to fix Many Parameters

<?php

/**
 * Copyright 2016 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\Stepup\Configuration\Event;

use Broadway\Serializer\SerializableInterface;
use Surfnet\Stepup\Configuration\Value\Institution;
use Surfnet\Stepup\Configuration\Value\InstitutionConfigurationId;
use Surfnet\Stepup\Configuration\Value\InstitutionRole;
use Surfnet\Stepup\Configuration\Value\InstitutionSet;
use Surfnet\Stepup\Configuration\Value\NumberOfTokensPerIdentityOption;
use Surfnet\Stepup\Configuration\Value\SelectRaaOption;
use Surfnet\Stepup\Configuration\Value\ShowRaaContactInformationOption;
use Surfnet\Stepup\Configuration\Value\UseRaaOption;
use Surfnet\Stepup\Configuration\Value\UseRaLocationsOption;
use Surfnet\Stepup\Configuration\Value\InstitutionOption;
use Surfnet\Stepup\Configuration\Value\VerifyEmailOption;

class NewInstitutionConfigurationCreatedEvent implements SerializableInterface
{
    /**
     * @var InstitutionConfigurationId
     */
    public $institutionConfigurationId;

    /**
     * @var Institution
     */
    public $institution;
    /**
     * @var UseRaLocationsOption
     */
    public $useRaLocationsOption;

    /**
     * @var ShowRaaContactInformationOption
     */
    public $showRaaContactInformationOption;

    /**
     * @var VerifyEmailOption
     */
    public $verifyEmailOption;

    /**
     * @var NumberOfTokensPerIdentityOption
     */
    public $numberOfTokensPerIdentityOption;

    /**
     * @var InstitutionOption
     */
    public $useRaOption;

    /**
     * @var InstitutionOption
     */
    public $useRaaOption;

    /**
     * @var InstitutionOption
     */
    public $selectRaaOption;

    public function __construct(
        InstitutionConfigurationId $institutionConfigurationId,
        Institution $institution,
        UseRaLocationsOption $useRaLocationsOption,
        ShowRaaContactInformationOption $showRaaContactInformationOption,
        VerifyEmailOption $verifyEmailOption,
        NumberOfTokensPerIdentityOption $numberOfTokensPerIdentityOption,
        InstitutionOption $useRaOption,
        InstitutionOption $useRaaOption,
        InstitutionOption $selectRaaOption
    ) {
        $this->institutionConfigurationId      = $institutionConfigurationId;
        $this->institution                     = $institution;
        $this->useRaLocationsOption            = $useRaLocationsOption;
        $this->showRaaContactInformationOption = $showRaaContactInformationOption;
        $this->verifyEmailOption               = $verifyEmailOption;
        $this->numberOfTokensPerIdentityOption = $numberOfTokensPerIdentityOption;
        $this->useRaOption = $useRaOption;
        $this->useRaaOption = $useRaaOption;
        $this->selectRaaOption = $selectRaaOption;
    }

    public static function deserialize(array $data)
    {
        if (!isset($data['verify_email_option'])) {
            $data['verify_email_option'] = true;
        }
        if (!isset($data['number_of_tokens_per_identity_option'])) {
            $data['number_of_tokens_per_identity_option'] = NumberOfTokensPerIdentityOption::DISABLED;
        }

        // Support FGA options on PRE FGA events
        if (!isset($data['use_ra_option'])) {
            $data['use_ra_option'] = InstitutionOption::blank();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        }
        if (!isset($data['use_raa_option'])) {
            $data['use_raa_option'] = InstitutionOption::blank();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        }
        if (!isset($data['select_raa_option'])) {
            $data['select_raa_option'] = InstitutionOption::blank();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        }

        $institution = new Institution($data['institution']);

        return new self(
            new InstitutionConfigurationId($data['institution_configuration_id']),
            new Institution($data['institution']),
            new UseRaLocationsOption($data['use_ra_locations_option']),
            new ShowRaaContactInformationOption($data['show_raa_contact_information_option']),
            new VerifyEmailOption($data['verify_email_option']),
            new NumberOfTokensPerIdentityOption($data['number_of_tokens_per_identity_option']),
            InstitutionOption::fromInstitutionConfig(InstitutionRole::useRa(), $institution, $data['use_ra_option']),
            InstitutionOption::fromInstitutionConfig(InstitutionRole::useRaa(), $institution, $data['use_raa_option']),
            InstitutionOption::fromInstitutionConfig(InstitutionRole::selectRaa(), $institution, $data['select_raa_option'])
        );
    }

    public function serialize()
    {
        return [
            'institution_configuration_id'        => $this->institutionConfigurationId->getInstitutionConfigurationId(),
            'institution'                         => $this->institution->getInstitution(),
            'use_ra_locations_option'             => $this->useRaLocationsOption->isEnabled(),
            'show_raa_contact_information_option' => $this->showRaaContactInformationOption->isEnabled(),
            'verify_email_option'                 => $this->verifyEmailOption->isEnabled(),
            'number_of_tokens_per_identity_option' => $this->numberOfTokensPerIdentityOption->getNumberOfTokensPerIdentity(),
            'use_ra_option' => $this->useRaOption->getInstitutionSet()->toScalarArray(),
            'use_raa_option' => $this->useRaaOption->getInstitutionSet()->toScalarArray(),
            'select_raa_option' => $this->selectRaaOption->getInstitutionSet()->toScalarArray(),
        ];
    }
}


1			<?php
2
3			/**
4			* Copyright 2016 SURFnet B.V.
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19			namespace Surfnet\Stepup\Configuration\Event;
20
21			use Broadway\Serializer\SerializableInterface;
22			use Surfnet\Stepup\Configuration\Value\Institution;
23			use Surfnet\Stepup\Configuration\Value\InstitutionConfigurationId;
24			use Surfnet\Stepup\Configuration\Value\InstitutionRole;
25			use Surfnet\Stepup\Configuration\Value\InstitutionSet;
26			use Surfnet\Stepup\Configuration\Value\NumberOfTokensPerIdentityOption;
27			use Surfnet\Stepup\Configuration\Value\SelectRaaOption;
28			use Surfnet\Stepup\Configuration\Value\ShowRaaContactInformationOption;
29			use Surfnet\Stepup\Configuration\Value\UseRaaOption;
30			use Surfnet\Stepup\Configuration\Value\UseRaLocationsOption;
31			use Surfnet\Stepup\Configuration\Value\InstitutionOption;
32			use Surfnet\Stepup\Configuration\Value\VerifyEmailOption;
33
34			class NewInstitutionConfigurationCreatedEvent implements SerializableInterface
35			{
36			/**
37			* @var InstitutionConfigurationId
38			*/
39			public $institutionConfigurationId;
40
41			/**
42			* @var Institution
43			*/
44			public $institution;
45			/**
46			* @var UseRaLocationsOption
47			*/
48			public $useRaLocationsOption;
49
50			/**
51			* @var ShowRaaContactInformationOption
52			*/
53			public $showRaaContactInformationOption;
54
55			/**
56			* @var VerifyEmailOption
57			*/
58			public $verifyEmailOption;
59
60			/**
61			* @var NumberOfTokensPerIdentityOption
62			*/
63			public $numberOfTokensPerIdentityOption;
64
65			/**
66			* @var InstitutionOption
67			*/
68			public $useRaOption;
69
70			/**
71			* @var InstitutionOption
72			*/
73			public $useRaaOption;
74
75			/**
76			* @var InstitutionOption
77			*/
78			public $selectRaaOption;
79
80			public function __construct(
81			InstitutionConfigurationId $institutionConfigurationId,
82			Institution $institution,
83			UseRaLocationsOption $useRaLocationsOption,
84			ShowRaaContactInformationOption $showRaaContactInformationOption,
85			VerifyEmailOption $verifyEmailOption,
86			NumberOfTokensPerIdentityOption $numberOfTokensPerIdentityOption,
87			InstitutionOption $useRaOption,
88			InstitutionOption $useRaaOption,
89			InstitutionOption $selectRaaOption
90			) {
91			$this->institutionConfigurationId = $institutionConfigurationId;
92			$this->institution = $institution;
93			$this->useRaLocationsOption = $useRaLocationsOption;
94			$this->showRaaContactInformationOption = $showRaaContactInformationOption;
95			$this->verifyEmailOption = $verifyEmailOption;
96			$this->numberOfTokensPerIdentityOption = $numberOfTokensPerIdentityOption;
97			$this->useRaOption = $useRaOption;
98			$this->useRaaOption = $useRaaOption;
99			$this->selectRaaOption = $selectRaaOption;
100			}
101
102			public static function deserialize(array $data)
103			{
104			if (!isset($data['verify_email_option'])) {
105			$data['verify_email_option'] = true;
106			}
107			if (!isset($data['number_of_tokens_per_identity_option'])) {
108			$data['number_of_tokens_per_identity_option'] = NumberOfTokensPerIdentityOption::DISABLED;
109			}
110
111			// Support FGA options on PRE FGA events
112			if (!isset($data['use_ra_option'])) {
113			$data['use_ra_option'] = InstitutionOption::blank();
			0 ignored issues – show Bug introduced 2018-09-26 14:53 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$data['use_ra_option']` is correct as `\Surfnet\Stepup\Configur...titutionOption::blank()` (which targets `Surfnet\Stepup\Configura...titutionOption::blank()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
114			}
115			if (!isset($data['use_raa_option'])) {
116			$data['use_raa_option'] = InstitutionOption::blank();
			0 ignored issues – show Bug introduced 2018-09-26 14:53 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$data['use_raa_option']` is correct as `\Surfnet\Stepup\Configur...titutionOption::blank()` (which targets `Surfnet\Stepup\Configura...titutionOption::blank()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
117			}
118			if (!isset($data['select_raa_option'])) {
119			$data['select_raa_option'] = InstitutionOption::blank();
			0 ignored issues – show Bug introduced 2018-09-26 14:53 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$data['select_raa_option']` is correct as `\Surfnet\Stepup\Configur...titutionOption::blank()` (which targets `Surfnet\Stepup\Configura...titutionOption::blank()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
120			}
121
122			$institution = new Institution($data['institution']);
123
124			return new self(
125			new InstitutionConfigurationId($data['institution_configuration_id']),
126			new Institution($data['institution']),
127			new UseRaLocationsOption($data['use_ra_locations_option']),
128			new ShowRaaContactInformationOption($data['show_raa_contact_information_option']),
129			new VerifyEmailOption($data['verify_email_option']),
130			new NumberOfTokensPerIdentityOption($data['number_of_tokens_per_identity_option']),
131			InstitutionOption::fromInstitutionConfig(InstitutionRole::useRa(), $institution, $data['use_ra_option']),
132			InstitutionOption::fromInstitutionConfig(InstitutionRole::useRaa(), $institution, $data['use_raa_option']),
133			InstitutionOption::fromInstitutionConfig(InstitutionRole::selectRaa(), $institution, $data['select_raa_option'])
134			);
135			}
136
137			public function serialize()
138			{
139			return [
140			'institution_configuration_id' => $this->institutionConfigurationId->getInstitutionConfigurationId(),
141			'institution' => $this->institution->getInstitution(),
142			'use_ra_locations_option' => $this->useRaLocationsOption->isEnabled(),
143			'show_raa_contact_information_option' => $this->showRaaContactInformationOption->isEnabled(),
144			'verify_email_option' => $this->verifyEmailOption->isEnabled(),
145			'number_of_tokens_per_identity_option' => $this->numberOfTokensPerIdentityOption->getNumberOfTokensPerIdentity(),
146			'use_ra_option' => $this->useRaOption->getInstitutionSet()->toScalarArray(),
147			'use_raa_option' => $this->useRaaOption->getInstitutionSet()->toScalarArray(),
148			'select_raa_option' => $this->selectRaaOption->getInstitutionSet()->toScalarArray(),
149			];
150			}
151			}
152

OpenConext / Stepup-Middleware

Pull Request — develop (#236)

__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like