DBALEventHydrator::getEventsFrom() - Code Metrics - Inspection of "Add dispatching events in ReplaySpecificEventsComm..." - OpenConext/Stepup-Middleware - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/specific-replay/dispat... ( 9bd709 )

by A.

created 2017-02-17 10:32 UTC

DBALEventHydrator::getEventsFrom() B

↳ Parent: DBALEventHydrator

Complexity

Conditions	2
Paths	2

Size

Total Lines	27
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	27
rs	8.8571
cc	2
eloc	14
nc	2
nop	1

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\MiddlewareBundle\EventSourcing;

use Broadway\Domain\DateTime;
use Broadway\Domain\DomainEventStream;
use Broadway\Domain\DomainMessage;
use Broadway\Serializer\SerializerInterface;
use Doctrine\DBAL\Connection;
use PDO;
use Surfnet\StepupMiddleware\CommandHandlingBundle\SensitiveData\Forgettable;
use Surfnet\StepupMiddleware\CommandHandlingBundle\SensitiveData\SensitiveData;

class DBALEventHydrator
{
    /**
     * @var Connection
     */
    private $connection;

    /**
     * @var \Broadway\Serializer\SerializerInterface
     */
    private $payloadSerializer;

    /**
     * @var \Broadway\Serializer\SerializerInterface
     */
    private $metadataSerializer;

    /**
     * @var string
     */
    private $eventStreamTableName;

    /**
     * @var string
     */
    private $sensitiveDataTable;

    /**
     * @var \Doctrine\DBAL\Driver\Statement
     */
    private $loadStatement = null;

    /**
     * @param Connection          $connection
     * @param SerializerInterface $payloadSerializer
     * @param SerializerInterface $metadataSerializer
     * @param string              $eventStreamTable
     * @param string              $sensitiveDataTable
     */
    public function __construct(
        Connection $connection,
        SerializerInterface $payloadSerializer,
        SerializerInterface $metadataSerializer,
        $eventStreamTable,
        $sensitiveDataTable
    ) {
        $this->connection         = $connection;
        $this->payloadSerializer  = $payloadSerializer;
        $this->metadataSerializer = $metadataSerializer;
        $this->eventStreamTableName = $eventStreamTable;
        $this->sensitiveDataTable = $sensitiveDataTable;
    }

    /**
     * @return string
     * @throws \Doctrine\DBAL\DBALException
     */
    public function getCount()
    {
        $statement = $this->connection->prepare('SELECT COUNT(1) AS cnt FROM ' . $this->eventStreamTableName);
        $statement->execute();

        $row = $statement->fetch();

        return $row['cnt'];
    }

    /**
     * @param int $limit
     * @param int $offset
     * @return DomainEventStream
     */
    public function getFromTill($limit, $offset)
    {
        $statement = $this->prepareLoadStatement();
        $statement->bindValue('limit', $limit, PDO::PARAM_INT);
        $statement->bindValue('offset', $offset, PDO::PARAM_INT);

        $statement->execute();

        $events = array();
        while ($row = $statement->fetch()) {
            $events[] = $this->deserializeEvent($row);
        }

        return new DomainEventStream($events);
    }

    public function getEventsFrom(EventCollection $eventCollection)
    {
        $eventTypes = $eventCollection->formatAsEventStreamTypes();
        $eventNamePlaceholders = str_repeat('?, ', count($eventTypes) -1) . '?';

        $query = str_replace(
            ['%es%', '%sd%'],
            [$this->eventStreamTableName, $this->sensitiveDataTable],
            "SELECT %es%.uuid, %es%.playhead, %es%.metadata, %es%.payload, %es%.recorded_on, %sd%.sensitive_data
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
                FROM %es%
                LEFT JOIN %sd%
                    ON %es%.uuid = %sd%.identity_id
                        AND %es%.playhead = %sd%.playhead
                WHERE %es%.type IN ($eventNamePlaceholders)
                ORDER BY recorded_on, playhead ASC"
        );

        $statement = $this->connection->prepare($query);
        $statement->execute($eventTypes);

        $events = array();
        while ($row = $statement->fetch()) {
            $events[] = $this->deserializeEvent($row);
        }

        return new DomainEventStream($events);
    }

    private function deserializeEvent($row)
    {
        $event = $this->payloadSerializer->deserialize(json_decode($row['payload'], true));

        if ($event instanceof Forgettable) {
            $event->setSensitiveData(SensitiveData::deserialize(json_decode($row['sensitive_data'], true)));
        }

        return new DomainMessage(
            $row['uuid'],
            $row['playhead'],
            $this->metadataSerializer->deserialize(json_decode($row['metadata'], true)),
            $event,
            DateTime::fromString($row['recorded_on'])
        );
    }

    private function prepareLoadStatement()
    {
        if ($this->loadStatement === null) {
            $query = str_replace(
                ['%es%', '%sd%'],
                [$this->eventStreamTableName, $this->sensitiveDataTable],
                'SELECT %es%.uuid, %es%.playhead, %es%.metadata, %es%.payload, %es%.recorded_on, %sd%.sensitive_data
                FROM %es%
                LEFT JOIN %sd%
                    ON %es%.uuid = %sd%.identity_id
                        AND %es%.playhead = %sd%.playhead
                ORDER BY recorded_on ASC
                LIMIT :limit OFFSET :offset'
            );

            $this->loadStatement = $this->connection->prepare($query);
        }

        return $this->loadStatement;
    }
}


1			<?php
2
3			/**
4			* Copyright 2014 SURFnet bv
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19			namespace Surfnet\StepupMiddleware\MiddlewareBundle\EventSourcing;
20
21			use Broadway\Domain\DateTime;
22			use Broadway\Domain\DomainEventStream;
23			use Broadway\Domain\DomainMessage;
24			use Broadway\Serializer\SerializerInterface;
25			use Doctrine\DBAL\Connection;
26			use PDO;
27			use Surfnet\StepupMiddleware\CommandHandlingBundle\SensitiveData\Forgettable;
28			use Surfnet\StepupMiddleware\CommandHandlingBundle\SensitiveData\SensitiveData;
29
30			class DBALEventHydrator
31			{
32			/**
33			* @var Connection
34			*/
35			private $connection;
36
37			/**
38			* @var \Broadway\Serializer\SerializerInterface
39			*/
40			private $payloadSerializer;
41
42			/**
43			* @var \Broadway\Serializer\SerializerInterface
44			*/
45			private $metadataSerializer;
46
47			/**
48			* @var string
49			*/
50			private $eventStreamTableName;
51
52			/**
53			* @var string
54			*/
55			private $sensitiveDataTable;
56
57			/**
58			* @var \Doctrine\DBAL\Driver\Statement
59			*/
60			private $loadStatement = null;
61
62			/**
63			* @param Connection $connection
64			* @param SerializerInterface $payloadSerializer
65			* @param SerializerInterface $metadataSerializer
66			* @param string $eventStreamTable
67			* @param string $sensitiveDataTable
68			*/
69			public function __construct(
70			Connection $connection,
71			SerializerInterface $payloadSerializer,
72			SerializerInterface $metadataSerializer,
73			$eventStreamTable,
74			$sensitiveDataTable
75			) {
76			$this->connection = $connection;
77			$this->payloadSerializer = $payloadSerializer;
78			$this->metadataSerializer = $metadataSerializer;
79			$this->eventStreamTableName = $eventStreamTable;
80			$this->sensitiveDataTable = $sensitiveDataTable;
81			}
82
83			/**
84			* @return string
85			* @throws \Doctrine\DBAL\DBALException
86			*/
87			public function getCount()
88			{
89			$statement = $this->connection->prepare('SELECT COUNT(1) AS cnt FROM ' . $this->eventStreamTableName);
90			$statement->execute();
91
92			$row = $statement->fetch();
93
94			return $row['cnt'];
95			}
96
97			/**
98			* @param int $limit
99			* @param int $offset
100			* @return DomainEventStream
101			*/
102			public function getFromTill($limit, $offset)
103			{
104			$statement = $this->prepareLoadStatement();
105			$statement->bindValue('limit', $limit, PDO::PARAM_INT);
106			$statement->bindValue('offset', $offset, PDO::PARAM_INT);
107
108			$statement->execute();
109
110			$events = array();
111			while ($row = $statement->fetch()) {
112			$events[] = $this->deserializeEvent($row);
113			}
114
115			return new DomainEventStream($events);
116			}
117
118			public function getEventsFrom(EventCollection $eventCollection)
119			{
120			$eventTypes = $eventCollection->formatAsEventStreamTypes();
121			$eventNamePlaceholders = str_repeat('?, ', count($eventTypes) -1) . '?';
122
123			$query = str_replace(
124			['%es%', '%sd%'],
125			[$this->eventStreamTableName, $this->sensitiveDataTable],
126			"SELECT %es%.uuid, %es%.playhead, %es%.metadata, %es%.payload, %es%.recorded_on, %sd%.sensitive_data
			0 ignored issues – show Coding Style Best Practice introduced 2017-02-17 10:36 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$eventNamePlaceholders` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
127			FROM %es%
128			LEFT JOIN %sd%
129			ON %es%.uuid = %sd%.identity_id
130			AND %es%.playhead = %sd%.playhead
131			WHERE %es%.type IN ($eventNamePlaceholders)
132			ORDER BY recorded_on, playhead ASC"
133			);
134
135			$statement = $this->connection->prepare($query);
136			$statement->execute($eventTypes);
137
138			$events = array();
139			while ($row = $statement->fetch()) {
140			$events[] = $this->deserializeEvent($row);
141			}
142
143			return new DomainEventStream($events);
144			}
145
146			private function deserializeEvent($row)
147			{
148			$event = $this->payloadSerializer->deserialize(json_decode($row['payload'], true));
149
150			if ($event instanceof Forgettable) {
151			$event->setSensitiveData(SensitiveData::deserialize(json_decode($row['sensitive_data'], true)));
152			}
153
154			return new DomainMessage(
155			$row['uuid'],
156			$row['playhead'],
157			$this->metadataSerializer->deserialize(json_decode($row['metadata'], true)),
158			$event,
159			DateTime::fromString($row['recorded_on'])
160			);
161			}
162
163			private function prepareLoadStatement()
164			{
165			if ($this->loadStatement === null) {
166			$query = str_replace(
167			['%es%', '%sd%'],
168			[$this->eventStreamTableName, $this->sensitiveDataTable],
169			'SELECT %es%.uuid, %es%.playhead, %es%.metadata, %es%.payload, %es%.recorded_on, %sd%.sensitive_data
170			FROM %es%
171			LEFT JOIN %sd%
172			ON %es%.uuid = %sd%.identity_id
173			AND %es%.playhead = %sd%.playhead
174			ORDER BY recorded_on ASC
175			LIMIT :limit OFFSET :offset'
176			);
177
178			$this->loadStatement = $this->connection->prepare($query);
179			}
180
181			return $this->loadStatement;
182			}
183			}
184

OpenConext / Stepup-Middleware

Push — feature/specific-replay/dispat... ( 9bd709 )

DBALEventHydrator::getEventsFrom() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like