Passed
Push — feature/main-authz-bugfix ( e03212 )
by Michiel
15:54 queued 09:38
created
Surfnet/StepupMiddleware/ApiBundle/DependencyInjection/Configuration.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
                     ->scalarNode('http_basic_realm')
34 34
                         ->defaultValue('Secure Gateway API')
35 35
                         ->validate()
36
-                            ->ifTrue(function ($realm) {
36
+                            ->ifTrue(function($realm) {
37 37
                                 return !is_string($realm) || empty($realm);
38 38
                             })
39 39
                             ->thenInvalid("Invalid HTTP Basic realm '%s'. Must be string and non-empty.")
Please login to merge, or discard this patch.
ApiBundle/Configuration/Repository/RaLocationRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
             throw new RuntimeException(sprintf('Unknown order by column "%s"', $query->orderBy));
44 44
         }
45 45
 
46
-        $orderBy        = 'rl.'.$query->orderBy;
46
+        $orderBy        = 'rl.' . $query->orderBy;
47 47
         $orderDirection = $query->orderDirection === 'asc' ? 'ASC' : 'DESC';
48 48
 
49 49
         return $this->getEntityManager()->createQueryBuilder()
Please login to merge, or discard this patch.
ApiBundle/Configuration/Repository/InstitutionAuthorizationRepository.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
         $entityManager = $this->getEntityManager();
108 108
 
109 109
         $entityManager->createQuery(
110
-            'DELETE '.InstitutionAuthorization::class.' ia
110
+            'DELETE ' . InstitutionAuthorization::class . ' ia
111 111
             WHERE ia.institution = :institution'
112 112
         )
113 113
             ->setParameter('institution', $institution->getInstitution())
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
     private function clearOldAuthorizations(EntityManager $entityManager, Institution $institution, InstitutionRole $role)
162 162
     {
163 163
         $entityManager->createQuery(
164
-            'DELETE '.InstitutionAuthorization::class.' ia
164
+            'DELETE ' . InstitutionAuthorization::class . ' ia
165 165
             WHERE ia.institutionRole = :role AND ia.institution = :institution'
166 166
         )
167 167
             ->setParameter('role', $role)
Please login to merge, or discard this patch.
ApiBundle/Configuration/Service/AllowedSecondFactorListService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 
47 47
     public function getAllowedSecondFactorListFor(Institution $institution)
48 48
     {
49
-        $allowedSecondFactors = array_map(function (AllowedSecondFactor $allowedSecondFactor) {
49
+        $allowedSecondFactors = array_map(function(AllowedSecondFactor $allowedSecondFactor) {
50 50
             return $allowedSecondFactor->secondFactorType;
51 51
         }, $this->allowedSecondFactorRepository->getAllowedSecondFactorsFor($institution));
52 52
 
Please login to merge, or discard this patch.
ApiBundle/Authorization/Filter/InstitutionAuthorizationRepositoryFilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
         // Else filter on institutions we are allowed to manage
44 44
         $values = [];
45 45
         foreach ($authorizationContext->getInstitutions() as $institution) {
46
-            $values[] = (string)$institution;
46
+            $values[] = (string) $institution;
47 47
         }
48 48
 
49 49
         $parameter = $this->getParameterName($authorizationAlias, 'institutions');
Please login to merge, or discard this patch.
StepupMiddleware/ApiBundle/Authorization/Service/AuthorizationService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -194,14 +194,14 @@
 block discarded – undo
194 194
 
195 195
     private function findInstitutionConfiguration(Identity $identity): ?InstitutionConfigurationOptions
196 196
     {
197
-        $institution = new Institution((string)$identity->institution);
197
+        $institution = new Institution((string) $identity->institution);
198 198
         return  $this->institutionConfigurationService
199 199
             ->findInstitutionConfigurationOptionsFor($institution);
200 200
     }
201 201
 
202 202
     private function findIdentity(IdentityId $identityId): ?Identity
203 203
     {
204
-        return $this->identityService->find((string)$identityId);
204
+        return $this->identityService->find((string) $identityId);
205 205
     }
206 206
 
207 207
     private function deny(string $errorMessage): AuthorizationDecision
Please login to merge, or discard this patch.
src/Surfnet/Migrations/Version20160219133522.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
      */
16 16
     public function up(Schema $schema): void
17 17
     {
18
-        $this->addSql('ALTER TABLE event_stream CHANGE payload payload LONGTEXT NOT NULL');    }
18
+        $this->addSql('ALTER TABLE event_stream CHANGE payload payload LONGTEXT NOT NULL'); }
19 19
 
20 20
     /**
21 21
      * @param Schema $schema
Please login to merge, or discard this patch.
src/Surfnet/Migrations/Version20200114161618.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
         $this->addSql('UPDATE ra_location SET institution=LOWER(institution)');
52 52
 
53 53
         // Convert all GW institutions to lowercase
54
-        $gatewaySchema  = $this->getGatewaySchema();
54
+        $gatewaySchema = $this->getGatewaySchema();
55 55
         $this->addSql(sprintf('UPDATE %s.whitelist_entry SET institution=LOWER(institution)', $gatewaySchema));
56 56
         $this->addSql(sprintf('UPDATE %s.second_factor SET institution=LOWER(institution)', $gatewaySchema));
57 57
     }
Please login to merge, or discard this patch.
src/Surfnet/Migrations/Version20141210174213.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
 
20 20
     public function up(Schema $schema): void
21 21
     {
22
-        $gatewaySchema  = $this->getGatewaySchema();
22
+        $gatewaySchema = $this->getGatewaySchema();
23 23
 
24 24
         // this up() migration is auto-generated, please modify it to your needs
25 25
         $this->abortIf($this->connection->getDatabasePlatform()->getName() != 'mysql', 'Migration can only be executed safely on \'mysql\'.');
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 
33 33
     public function down(Schema $schema): void
34 34
     {
35
-        $gatewaySchema  = $this->getGatewaySchema();
35
+        $gatewaySchema = $this->getGatewaySchema();
36 36
 
37 37
         // this down() migration is auto-generated, please modify it to your needs
38 38
         $this->abortIf($this->connection->getDatabasePlatform()->getName() != 'mysql', 'Migration can only be executed safely on \'mysql\'.');
Please login to merge, or discard this patch.