Surfnet\StepupMiddleware\ApiBundle\Authorization\Value\InstitutionAuthorizationContext

Complexity

Total Complexity

5

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
A	getActorInstitution()	0	4	1
A	getRoleRequirements()	0	4	1
A	isActorSraa()	0	4	1
A	getInstitutions()	0	4	1

<?php

/**
 * Copyright 2018 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\ApiBundle\Authorization\Value;

use Surfnet\Stepup\Identity\Collection\InstitutionCollection;
use Surfnet\Stepup\Identity\Value\Institution;

class InstitutionAuthorizationContext implements InstitutionAuthorizationContextInterface
{
    /**
     * @var Institution
     */
    private $actorInstitution;

    /**
     * @var InstitutionRoleSet
     */
    private $roleRequirements;

    /**
     * @var InstitutionCollection|null
     */
    private $institutions;

    /**
     * @var bool
     */
    private $isSraa;

    /**
     * AuthorizationContext constructor.
     * @param Institution $actorInstitution
     * @param InstitutionRoleSetInterface $roleRequirements
     * @param InstitutionCollection $institutions[]

There is no parameter named $institutions[]. Did you maybe mean $institutions?

     * @param bool $isSraa describes if the actor is SRAA or not. Default: false
     */
    public function __construct(
        Institution $actorInstitution,
        InstitutionRoleSetInterface $roleRequirements,
        InstitutionCollection $institutions = null,
        $isSraa = false
    ) {
        $this->actorInstitution = $actorInstitution;
        $this->roleRequirements = $roleRequirements;

$roleRequirements is of type object<Surfnet\StepupMiddleware\ApiBundle\Authorization\Value\InstitutionRoleSetInterface>, but the property $roleRequirements was declared to be of type object<Surfnet\StepupMiddleware\ApiBundle\Authorization\Value\InstitutionRoleSet>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->institutions = $institutions;
        $this->isSraa = $isSraa;
    }

    /**
     * @return Institution
     */
    public function getActorInstitution()
    {
        return $this->actorInstitution;
    }

    /**
     * @return InstitutionRoleSet
     */
    public function getRoleRequirements()
    {
        return $this->roleRequirements;
    }

    /**
     * @return InstitutionCollection

Should the return type not be InstitutionCollection|null?

     */
    public function getInstitutions()
    {
        return $this->institutions;
    }

    /**
     * @return bool
     */
    public function isActorSraa()
    {
        return $this->isSraa;
    }
}