VerifiedTokenInformation::__construct() - Code Metrics - Inspection of "Remove differences between develop and master" - OpenConext/Stepup-Middleware - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 64908a...328605 )

unknown

created 2018-03-15 09:18 UTC

VerifiedTokenInformation::__construct() A

↳ Parent: VerifiedTokenInformation

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	17
nc	1
nop	8

How to fix Many Parameters

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\ApiBundle\Identity\Value;

use Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity;
use Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\VerifiedSecondFactor;

class VerifiedTokenInformation
{
    private $email;

    private $tokenId;

    private $tokenType;

    private $commonName;

    private $requestedAt;

    private $preferredLocale;

    private $institution;

    private $registrationCode;

    /**
     * @param $email
     * @param $tokenId
     * @param $tokenType
     * @param $commonName
     * @param $requestedAt
     * @param $preferredLocale
     * @param $institution
     * @param $registrationCode
     */
    public function __construct(
        $email,
        $tokenId,
        $tokenType,
        $commonName,
        $requestedAt,
        $preferredLocale,
        $institution,
        $registrationCode
    ) {
        $this->email = $email;
        $this->tokenId = $tokenId;
        $this->tokenType = $tokenType;
        $this->commonName = $commonName;
        $this->requestedAt = $requestedAt;
        $this->preferredLocale = $preferredLocale;
        $this->institution = $institution;
        $this->registrationCode = $registrationCode;
    }

    public static function fromEntity(VerifiedSecondFactor $token, Identity $identity)
    {
        $tokenInformation = new self(
            (string) $identity->email,
            $token->id,
            $token->type,
            (string) $identity->commonName,
            $token->registrationRequestedAt,
            (string) $identity->preferredLocale,
            $identity->institution,
            $token->registrationCode
        );

        return $tokenInformation;
    }

    public function getEmail()

    {
        return $this->email;
    }

    public function getTokenId()

    {
        return $this->tokenId;
    }

    public function getTokenType()

    {
        return $this->tokenType;
    }

    public function getCommonName()

    {
        return $this->commonName;
    }

    public function getRequestedAt()

    {
        return $this->requestedAt;
    }

    public function getPreferredLocale()

    {
        return $this->preferredLocale;
    }

    public function getInstitution()

    {
        return $this->institution;
    }

    public function getRegistrationCode()

    {
        return $this->registrationCode;
    }
}


1			<?php
2
3			/**
4			* Copyright 2014 SURFnet bv
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19			namespace Surfnet\StepupMiddleware\ApiBundle\Identity\Value;
20
21			use Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity;
22			use Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\VerifiedSecondFactor;
23
24			class VerifiedTokenInformation
25			{
26			private $email;
27
28			private $tokenId;
29
30			private $tokenType;
31
32			private $commonName;
33
34			private $requestedAt;
35
36			private $preferredLocale;
37
38			private $institution;
39
40			private $registrationCode;
41
42			/**
43			* @param $email
44			* @param $tokenId
45			* @param $tokenType
46			* @param $commonName
47			* @param $requestedAt
48			* @param $preferredLocale
49			* @param $institution
50			* @param $registrationCode
51			*/
52			public function __construct(
53			$email,
54			$tokenId,
55			$tokenType,
56			$commonName,
57			$requestedAt,
58			$preferredLocale,
59			$institution,
60			$registrationCode
61			) {
62			$this->email = $email;
63			$this->tokenId = $tokenId;
64			$this->tokenType = $tokenType;
65			$this->commonName = $commonName;
66			$this->requestedAt = $requestedAt;
67			$this->preferredLocale = $preferredLocale;
68			$this->institution = $institution;
69			$this->registrationCode = $registrationCode;
70			}
71
72			public static function fromEntity(VerifiedSecondFactor $token, Identity $identity)
73			{
74			$tokenInformation = new self(
75			(string) $identity->email,
76			$token->id,
77			$token->type,
78			(string) $identity->commonName,
79			$token->registrationRequestedAt,
80			(string) $identity->preferredLocale,
81			$identity->institution,
82			$token->registrationCode
83			);
84
85			return $tokenInformation;
86			}
87
88			public function getEmail()
			0 ignored issues – show Documentation introduced 2017-11-15 15:54 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
89			{
90			return $this->email;
91			}
92
93			public function getTokenId()
			0 ignored issues – show Documentation introduced 2017-11-15 15:54 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
94			{
95			return $this->tokenId;
96			}
97
98			public function getTokenType()
			0 ignored issues – show Documentation introduced 2017-11-15 15:54 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
99			{
100			return $this->tokenType;
101			}
102
103			public function getCommonName()
			0 ignored issues – show Documentation introduced 2017-11-15 15:54 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
104			{
105			return $this->commonName;
106			}
107
108			public function getRequestedAt()
			0 ignored issues – show Documentation introduced 2017-11-15 15:54 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
109			{
110			return $this->requestedAt;
111			}
112
113			public function getPreferredLocale()
			0 ignored issues – show Documentation introduced 2017-11-15 15:54 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
114			{
115			return $this->preferredLocale;
116			}
117
118			public function getInstitution()
			0 ignored issues – show Documentation introduced 2017-11-15 15:54 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
119			{
120			return $this->institution;
121			}
122
123			public function getRegistrationCode()
			0 ignored issues – show Documentation introduced 2017-11-15 15:54 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
124			{
125			return $this->registrationCode;
126			}
127			}
128

OpenConext / Stepup-Middleware

Push — master ( 64908a...328605 )

VerifiedTokenInformation::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like