OpenConext / Stepup-Middleware

src/Surfnet/StepupMiddleware/MiddlewareBundle/Service/TokenBootstrapService.php

Doc Comments +2 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
     }
 
     /**
-     * @param $identityId
+     * @param string $identityId
      * @param $tokenType
      * @return UnverifiedSecondFactor|null
      */
@@ -90,7 +90,7 @@ 
     }
 
     /**
-     * @param $identityId
+     * @param string $identityId
      * @param $tokenType
      * @return VerifiedSecondFactor|null
      */

src/Surfnet/Stepup/Identity/Api/Identity.php

Doc Comments +3 added lines, -1 removed lines

@@ -66,6 +66,7 @@ 
 
     /**
      * Construct a new aggregate root. Aggregate roots can only be affected by events, so no parameters are allowed.
+     * @return void
      */
     public function __construct();
 
@@ -297,13 +298,14 @@ 
     public function getVerifiedSecondFactor(SecondFactorId $secondFactorId);
 
     /**
-     * @return IdentityId We're deviating from Broadway's official API, as they accept toString-able VOs as IDs, and we
+     * @return string We're deviating from Broadway's official API, as they accept toString-able VOs as IDs, and we
      *     require the IdentityId VO in our SensitiveDataEventStoreDecorator.
      */
     public function getAggregateRootId(): string;
 
     /**
      * @param int $numberOfTokens
+     * @return void
      */
     public function setMaxNumberOfTokens($numberOfTokens);
 }

src/Surfnet/Stepup/Identity/Entity/InstitutionCollection.php

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
 
     /**
      * @param Institution $institution
-     * @return Institution
+     * @return boolean
      */
     public function exists(Institution $institution)
     {

src/Surfnet/Stepup/Identity/Value/GssfId.php

Doc Comments +3 added lines

@@ -32,6 +32,9 @@
         return new self('—');
     }
 
+    /**
+     * @param string $gssfId
+     */
     public function __construct($gssfId)
     {
         if (!is_string($gssfId) || trim($gssfId) === '') {

src/Surfnet/Stepup/Identity/Value/PhoneNumber.php

Doc Comments +3 added lines

@@ -32,6 +32,9 @@
         return new self('+0 (0) 000000000');
     }
 
+    /**
+     * @param string $phoneNumber
+     */
     public function __construct($phoneNumber)
     {
         if (!is_string($phoneNumber)) {

src/Surfnet/Stepup/Identity/Value/YubikeyPublicId.php

Doc Comments +3 added lines

@@ -40,6 +40,9 @@
         return new self(self::UNKNOWN);
     }
 
+    /**
+     * @param string $value
+     */
     public function __construct($value)
     {
         if ($value === self::UNKNOWN) {

src/Surfnet/StepupMiddleware/ApiBundle/EventListener/ExceptionListener.php

Doc Comments -1 removed lines

@@ -80,7 +80,6 @@
     }
 
     /**
-     * @param Throwable $exception
      * @param int $statusCode
      * @param array $headers OPTIONAL
      * @return JsonResponse

src/Surfnet/Stepup/Identity/Entity/VerifiedSecondFactor.php

Doc Comments +3 added lines

@@ -139,6 +139,9 @@
         );
     }
 
+    /**
+     * @param boolean $provePossessionSkipped
+     */
     public function vet(DocumentNumber $documentNumber, $provePossessionSkipped)
     {
         if ($provePossessionSkipped) {