Surfnet\StepupMiddleware\MiddlewareBundle\Console\Command\MigrateSecondFactorCommand::__invoke()

Complexity

Conditions	6
Paths	34

Size

Total Lines	75
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function __invoke(
        #[Argument(description: 'The old NameID of the identity used as the source of the tokens to move', name: 'old-name-id')]
        string $oldNameId,
        #[Argument(description: 'The new NameID of the identity to move the tokens to', name: 'new-name-id')]
        string $newNameId,
        #[Argument(description: 'The institution of the target identity', name: 'target-institution')]
        ?string $targetInstitution,
        #[Argument(description: 'The e-mail address of the identity to create', name: 'email')]
        ?string $email,
        OutputInterface $output
    ): int {
        $sourceNameId = new NameId($oldNameId);
        $targetNameId = new NameId($newNameId);

        $output->writeln(sprintf('<comment>Starting token migration for %s</comment>', $sourceNameId));
        $sourceIdentity = $this->bootstrapService->getIdentityByNameId($sourceNameId);

        if ($sourceIdentity === null) {
            throw new InvalidArgumentException("oldNameId could net be resolved to a Identity.");
        }

        $targetIdentity = $this->bootstrapService->getIdentityByNameId($targetNameId);

        try {
            $this->transactionHelper->beginTransaction();

            // Check if target identity should be created
            if (!$targetIdentity instanceof Identity) {
                $output->writeln(
                    sprintf('<info>Target with NameID %s does not exist, creating new identity</info>', $targetNameId),
                );

                $identityId = $this->createIdentity($targetNameId, $sourceIdentity, $targetInstitution, $email);

                $output->writeln(
                    sprintf('<info>Successfully created identity with UUID %s</info>', $identityId),
                );


                $targetIdentity = $this->bootstrapService->getIdentityByNameId($targetNameId);
            }

            // Foreach token, perform the token move command
            $sourceVettedSecondFactors = $this->bootstrapService->getVettedSecondFactorsFromIdentity($sourceIdentity);
            $targetVettedSecondFactors = $this->bootstrapService->getVettedSecondFactorsFromIdentity($targetIdentity);

It seems like $targetIdentity can also be of type null; however, parameter $identity of Surfnet\StepupMiddleware\MiddlewareBundle\Service\BootstrapCommandService::getVettedSecondFactorsFromIdentity() does only seem to accept Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity, maybe add an additional type check?

            foreach ($sourceVettedSecondFactors as $secondFactor) {
                if (!$this->tokenExists($targetVettedSecondFactors, $secondFactor)) {
                    $this->bootstrapService->migrateVettedSecondFactor($sourceIdentity, $targetIdentity, $secondFactor);

It seems like $targetIdentity can also be of type null; however, parameter $targetIdentity of Surfnet\StepupMiddleware\MiddlewareBundle\Service\BootstrapCommandService::migrateVettedSecondFactor() does only seem to accept Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\Identity, maybe add an additional type check?

                    $output->writeln(sprintf('<comment>Moved token %s</comment>', $secondFactor->id));
                } else {
                    $output->writeln(
                        sprintf('<info>Skipped moving token %s, already present"</info>', $secondFactor->id),
                    );
                }
            }

            $this->transactionHelper->finishTransaction();
        } catch (Exception $e) {
            $output->writeln(
                sprintf(
                    '<error>An Error occurred when trying to move the tokens of identity: "%s"</error>',
                    $e->getMessage(),
                ),
            );
            $this->transactionHelper->rollback();
            return 1;
        }
        $output->writeln(
            sprintf(
                '<info>Successfully moved tokens from identity %s to identity %s</info>',
                $sourceIdentity->id,
                $targetIdentity->id,
            ),
        );
        return 0;
    }