Surfnet\StepupMiddleware\ApiBundle\Identity\Service\RaCandidateService

Complexity

Total Complexity

6

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	search()	0	8	1
A	getFilterOptions()	0	4	1
A	findOneByIdentityId()	0	4	1
A	setUseRaInstitutionsOnRaCandidate()	0	9	2

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\ApiBundle\Identity\Service;

use Surfnet\Stepup\Identity\Value\Institution;
use Surfnet\StepupMiddleware\ApiBundle\Authorization\Value\InstitutionAuthorizationContext;
use Surfnet\StepupMiddleware\ApiBundle\Identity\Query\RaCandidateQuery;
use Surfnet\StepupMiddleware\ApiBundle\Identity\Repository\RaCandidateRepository;

class RaCandidateService extends AbstractSearchService
{
    /**
     * @var RaCandidateRepository
     */
    private $raCandidateRepository;

    /**
     * @param RaCandidateRepository $raCandidateRepository
     */
    public function __construct(RaCandidateRepository $raCandidateRepository)
    {
        $this->raCandidateRepository = $raCandidateRepository;
    }

    /**
     * @param RaCandidateQuery $query
     * @return \Pagerfanta\Pagerfanta
     */
    public function search(RaCandidateQuery $query)
    {
        $doctrineQuery = $this->raCandidateRepository->createSearchQuery($query);

        $paginator = $this->createPaginatorFrom($doctrineQuery, $query, false);

        return $paginator;
    }

    /**
     * @param RaCandidateQuery $query
     * @return array
     */
    public function getFilterOptions(RaCandidateQuery $query)
    {
        return $this->getFilteredQueryOptions($this->raCandidateRepository->createOptionsQuery($query));
    }

    /**
     * @param string $identityId
     * @return null|array
     */
    public function findOneByIdentityId($identityId)
    {
        return $this->raCandidateRepository->findOneByIdentityId($identityId);
    }

    /**
     * Set the RA candidates USE RA(A) institutions on the Identity he is going to promote.
     */
    public function setUseRaInstitutionsOnRaCandidate(InstitutionAuthorizationContext $actor, array $raCandidate)
    {
        $result = [];
        foreach ($actor->getInstitutions() as $raInstitution) {

The expression $actor->getInstitutions() of type object<Surfnet\Stepup\Identity\Collection\InstitutionCollection>|null is not guaranteed to be traversable. How about adding an additional type check?

            $raCandidate['ra_institution'] = new Institution($raInstitution->getInstitution());
            $result[] = $raCandidate;
        }
        return $result;
    }
}