Surfnet\Stepup\Configuration\Value\InstitutionConfigurationId

Complexity

Total Complexity

9

Size/Duplication

Total Lines	63
Duplicated Lines	31.75 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	5
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	from()	0	4	1
A	__construct()	20	20	4
A	equals()	0	4	1
A	getInstitutionConfigurationId()	0	4	1
A	__toString()	0	4	1
A	jsonSerialize()	0	4	1

<?php

/**
 * Copyright 2016 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\Stepup\Configuration\Value;

use JsonSerializable;
use Rhumsaa\Uuid\Uuid;
use Surfnet\Stepup\Exception\InvalidArgumentException;

final class InstitutionConfigurationId implements JsonSerializable
{
    const UUID_NAMESPACE = '09876543-abcd-0987-abcd-098765432109';

    private $institutionConfigurationId;

    /**
     * @param Institution $institution
     * @return InstitutionConfigurationId
     */
    public static function from(Institution $institution)
    {
        return new self((string) Uuid::uuid5(self::UUID_NAMESPACE, $institution->getInstitution()));
    }

    public function __construct($institutionConfigurationId)

This method seems to be duplicated in your project.

    {
        if (!is_string($institutionConfigurationId) || strlen(trim($institutionConfigurationId)) === 0) {
            throw InvalidArgumentException::invalidType(
                'non-empty string',
                'institutionConfigurationId',
                $institutionConfigurationId
            );
        }

        if (!Uuid::isValid($institutionConfigurationId)) {
            throw InvalidArgumentException::invalidType(
                'UUID',
                'institutionConfigurationId',
                $institutionConfigurationId
            );
        }

        $this->institutionConfigurationId = $institutionConfigurationId;
    }

    /**
     * @param InstitutionConfigurationId $otherInstitutionConfigurationId
     * @return bool
     */
    public function equals(InstitutionConfigurationId $otherInstitutionConfigurationId)

The variable name $otherInstitutionConfigurationId exceeds the maximum configured length of 30.

    {
        return $this->institutionConfigurationId === $otherInstitutionConfigurationId->institutionConfigurationId;
    }

    /**
     * @return string
     */
    public function getInstitutionConfigurationId()
    {
        return $this->institutionConfigurationId;
    }

    public function __toString()
    {
        return $this->institutionConfigurationId;
    }

    public function jsonSerialize()
    {
        return $this->institutionConfigurationId;
    }
}