Surfnet\StepupMiddleware\CommandHandlingBundle\Processor\SecondFactorRevocationEmailProcessor

Complexity

Total Complexity

5

Size/Duplication

Total Lines	59
Duplicated Lines	55.93 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	handleCompliedWithVettedSecondFactorRevocationEvent()	17	17	2
A	handleVettedSecondFactorRevokedEvent()	16	16	2

<?php

/**
 * Copyright 2016 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\CommandHandlingBundle\Processor;

use Broadway\Processor\Processor;
use Surfnet\Stepup\Identity\Event\CompliedWithVettedSecondFactorRevocationEvent;
use Surfnet\Stepup\Identity\Event\SecondFactorRevokedEvent;
use Surfnet\StepupMiddleware\ApiBundle\Identity\Service\IdentityService;
use Surfnet\StepupMiddleware\CommandHandlingBundle\Identity\Service\SecondFactorRevocationMailService;

final class SecondFactorRevocationEmailProcessor extends Processor
{
    /**
     * @var SecondFactorRevocationMailService
     */
    private $mailService;

    /**
     * @var IdentityService
     */
    private $identityService;

    /**
     * @param SecondFactorRevocationMailService $secondFactorRevocationMailService
     * @param IdentityService $identityService
     */
    public function __construct(
        SecondFactorRevocationMailService $secondFactorRevocationMailService,

The variable name $secondFactorRevocationMailService exceeds the maximum configured length of 30.

        IdentityService $identityService
    ) {
        $this->mailService = $secondFactorRevocationMailService;
        $this->identityService = $identityService;
    }

    public function handleCompliedWithVettedSecondFactorRevocationEvent(

This method seems to be duplicated in your project.

        CompliedWithVettedSecondFactorRevocationEvent $event
    ) {
        $identity = $this->identityService->find($event->identityId->getIdentityId());

        if ($identity === null) {
            return;
        }

        $this->mailService->sendVettedSecondFactorRevokedByRaEmail(
            $identity->preferredLocale,
            $identity->commonName,
            $identity->email,
            $event->secondFactorType,
            $event->secondFactorIdentifier
        );
    }

    public function handleVettedSecondFactorRevokedEvent(SecondFactorRevokedEvent $event)

This method seems to be duplicated in your project.

    {
        $identity = $this->identityService->find($event->identityId->getIdentityId());

        if ($identity === null) {
            return;
        }

        $this->mailService->sendVettedSecondFactorRevokedByRegistrantEmail(
            $identity->preferredLocale,
            $identity->commonName,
            $identity->email,
            $event->secondFactorType,
            $event->secondFactorIdentifier
        );
    }
}