VerifiedSecondFactorRepository::__construct() - Code Metrics - Inspection of "Merge pull request #242 from OpenConext/feature/fg..." - OpenConext/Stepup-Middleware - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/fine-grained-authoriza... ( e1bd5c...a0b49e )

by Michiel

created 2018-10-11 13:44 UTC

VerifiedSecondFactorRepository::__construct() A

↳ Parent: VerifiedSecondFactorRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	3

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\ApiBundle\Identity\Repository;

use DateTime;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityRepository;
use Doctrine\ORM\Mapping;
use Doctrine\ORM\Query;
use Surfnet\Stepup\Identity\Value\IdentityId;
use Surfnet\StepupMiddleware\ApiBundle\Authorization\Filter\InstitutionAuthorizationRepositoryFilter;
use Surfnet\StepupMiddleware\ApiBundle\Authorization\Value\InstitutionAuthorizationContextInterface;
use Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\VerifiedSecondFactor;
use Surfnet\StepupMiddleware\ApiBundle\Identity\Query\VerifiedSecondFactorQuery;

class VerifiedSecondFactorRepository extends EntityRepository
{
    /**
     * @var InstitutionAuthorizationRepositoryFilter
     */
    private $authorizationRepositoryFilter;

    /**
     * VerifiedSecondFactorRepository constructor.
     * @param EntityManager $em
     * @param Mapping\ClassMetadata $class
     * @param InstitutionAuthorizationRepositoryFilter $authorizationRepositoryFilter
     */
    public function __construct(
        EntityManager $em,
        Mapping\ClassMetadata $class,
        InstitutionAuthorizationRepositoryFilter $authorizationRepositoryFilter
    ) {
        parent::__construct($em, $class);
        $this->authorizationRepositoryFilter = $authorizationRepositoryFilter;
    }


    /**
     * @param string $id
     * @return VerifiedSecondFactor|null
     */
    public function find($id)
    {
        /** @var VerifiedSecondFactor|null $secondFactor */
        $secondFactor = parent::find($id);

        return $secondFactor;
    }

    /**
     * @param DateTime $requestedAt
     * @return VerifiedSecondFactor[]
     */
    public function findByDate(DateTime $requestedAt)
    {
        $fromDate = clone $requestedAt;
        $fromDate->setTime(0, 0, 0);

        $toDate = clone $requestedAt;
        $toDate->setTime(23, 59, 59);

        return $this->createQueryBuilder('sf')
            ->where('sf.registrationRequestedAt <= :toDate')
            ->andWhere('sf.registrationRequestedAt >= :fromDate')
            ->setParameter('toDate', $toDate)
            ->setParameter('fromDate', $fromDate)
            ->getQuery()
            ->getResult();
    }

    /**
     * @param VerifiedSecondFactorQuery $query
     * @param InstitutionAuthorizationContextInterface $authorizationContext
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param InstitutionAuthorizationRepositoryFilter $authorizationRepositoryFilter
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return Query
     */
    public function createSearchQuery(VerifiedSecondFactorQuery $query)

    {
        $queryBuilder = $this->createQueryBuilder('sf');

        // Modify query to filter on authorization
        $this->authorizationRepositoryFilter->filter($queryBuilder, $query->authorizationContext, 'sf.id', 'sf.institution', 'iac');

        if ($query->identityId) {
            $queryBuilder
                ->andWhere('sf.identityId = :identityId')
                ->setParameter('identityId', (string) $query->identityId);
        }

        if ($query->secondFactorId) {
            $queryBuilder
                ->andWhere('sf.id = :secondFactorId')
                ->setParameter('secondFactorId', (string) $query->secondFactorId);
        }

        if (is_string($query->registrationCode)) {
            $queryBuilder
                ->andWhere('sf.registrationCode = :registrationCode')
                ->setParameter('registrationCode', $query->registrationCode);
        }

        return $queryBuilder->getQuery();
    }

    public function removeByIdentityId(IdentityId $identityId)

    {
        $this->getEntityManager()->createQueryBuilder()
            ->delete($this->_entityName, 'sf')
            ->where('sf.identityId = :identityId')
            ->setParameter('identityId', $identityId->getIdentityId())
            ->getQuery()
            ->execute();
    }

    /**
     * @param VerifiedSecondFactor $secondFactor
     */
    public function save(VerifiedSecondFactor $secondFactor)
    {
        $this->getEntityManager()->persist($secondFactor);
        $this->getEntityManager()->flush();
    }

    public function remove(VerifiedSecondFactor $secondFactor)
    {
        $this->getEntityManager()->remove($secondFactor);
        $this->getEntityManager()->flush();
    }
}


1		<?php
2
3		/**
4		* Copyright 2014 SURFnet bv
5		*
6		* Licensed under the Apache License, Version 2.0 (the "License");
7		* you may not use this file except in compliance with the License.
8		* You may obtain a copy of the License at
9		*
10		* http://www.apache.org/licenses/LICENSE-2.0
11		*
12		* Unless required by applicable law or agreed to in writing, software
13		* distributed under the License is distributed on an "AS IS" BASIS,
14		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15		* See the License for the specific language governing permissions and
16		* limitations under the License.
17		*/
18
19		namespace Surfnet\StepupMiddleware\ApiBundle\Identity\Repository;
20
21		use DateTime;
22		use Doctrine\ORM\EntityManager;
23		use Doctrine\ORM\EntityRepository;
24		use Doctrine\ORM\Mapping;
25		use Doctrine\ORM\Query;
26		use Surfnet\Stepup\Identity\Value\IdentityId;
27		use Surfnet\StepupMiddleware\ApiBundle\Authorization\Filter\InstitutionAuthorizationRepositoryFilter;
28		use Surfnet\StepupMiddleware\ApiBundle\Authorization\Value\InstitutionAuthorizationContextInterface;
29		use Surfnet\StepupMiddleware\ApiBundle\Identity\Entity\VerifiedSecondFactor;
30		use Surfnet\StepupMiddleware\ApiBundle\Identity\Query\VerifiedSecondFactorQuery;
31
32		class VerifiedSecondFactorRepository extends EntityRepository
33		{
34		/**
35		* @var InstitutionAuthorizationRepositoryFilter
36		*/
37		private $authorizationRepositoryFilter;
38
39		/**
40		* VerifiedSecondFactorRepository constructor.
41		* @param EntityManager $em
42		* @param Mapping\ClassMetadata $class
43		* @param InstitutionAuthorizationRepositoryFilter $authorizationRepositoryFilter
44		*/
45		public function __construct(
46		EntityManager $em,
47		Mapping\ClassMetadata $class,
48		InstitutionAuthorizationRepositoryFilter $authorizationRepositoryFilter
49		) {
50		parent::__construct($em, $class);
51		$this->authorizationRepositoryFilter = $authorizationRepositoryFilter;
52		}
53
54
55		/**
56		* @param string $id
57		* @return VerifiedSecondFactor\|null
58		*/
59		public function find($id)
60		{
61		/** @var VerifiedSecondFactor\|null $secondFactor */
62		$secondFactor = parent::find($id);
63
64		return $secondFactor;
65		}
66
67		/**
68		* @param DateTime $requestedAt
69		* @return VerifiedSecondFactor[]
70		*/
71		public function findByDate(DateTime $requestedAt)
72		{
73		$fromDate = clone $requestedAt;
74		$fromDate->setTime(0, 0, 0);
75
76		$toDate = clone $requestedAt;
77		$toDate->setTime(23, 59, 59);
78
79		return $this->createQueryBuilder('sf')
80		->where('sf.registrationRequestedAt <= :toDate')
81		->andWhere('sf.registrationRequestedAt >= :fromDate')
82		->setParameter('toDate', $toDate)
83		->setParameter('fromDate', $fromDate)
84		->getQuery()
85		->getResult();
86		}
87
88		/**
89		* @param VerifiedSecondFactorQuery $query
90		* @param InstitutionAuthorizationContextInterface $authorizationContext
		0 ignored issues – show Bug introduced 2018-10-11 10:11 UTC by Report Bug Copy Issue Report There is no parameter named `$authorizationContext`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
91		* @param InstitutionAuthorizationRepositoryFilter $authorizationRepositoryFilter
		0 ignored issues – show Bug introduced 2018-10-11 10:11 UTC by Report Bug Copy Issue Report There is no parameter named `$authorizationRepositoryFilter`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
92		* @return Query
93		*/
94	View Code Duplication	public function createSearchQuery(VerifiedSecondFactorQuery $query)
		0 ignored issues – show Duplication introduced 2018-10-11 10:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
95		{
96		$queryBuilder = $this->createQueryBuilder('sf');
97
98		// Modify query to filter on authorization
99		$this->authorizationRepositoryFilter->filter($queryBuilder, $query->authorizationContext, 'sf.id', 'sf.institution', 'iac');
100
101		if ($query->identityId) {
102		$queryBuilder
103		->andWhere('sf.identityId = :identityId')
104		->setParameter('identityId', (string) $query->identityId);
105		}
106
107		if ($query->secondFactorId) {
108		$queryBuilder
109		->andWhere('sf.id = :secondFactorId')
110		->setParameter('secondFactorId', (string) $query->secondFactorId);
111		}
112
113		if (is_string($query->registrationCode)) {
114		$queryBuilder
115		->andWhere('sf.registrationCode = :registrationCode')
116		->setParameter('registrationCode', $query->registrationCode);
117		}
118
119		return $queryBuilder->getQuery();
120		}
121
122	View Code Duplication	public function removeByIdentityId(IdentityId $identityId)
		0 ignored issues – show Duplication introduced 2017-08-01 07:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
123		{
124		$this->getEntityManager()->createQueryBuilder()
125		->delete($this->_entityName, 'sf')
126		->where('sf.identityId = :identityId')
127		->setParameter('identityId', $identityId->getIdentityId())
128		->getQuery()
129		->execute();
130		}
131
132		/**
133		* @param VerifiedSecondFactor $secondFactor
134		*/
135		public function save(VerifiedSecondFactor $secondFactor)
136		{
137		$this->getEntityManager()->persist($secondFactor);
138		$this->getEntityManager()->flush();
139		}
140
141		public function remove(VerifiedSecondFactor $secondFactor)
142		{
143		$this->getEntityManager()->remove($secondFactor);
144		$this->getEntityManager()->flush();
145		}
146		}
147

OpenConext / Stepup-Middleware

Push — feature/fine-grained-authoriza... ( e1bd5c...a0b49e )

VerifiedSecondFactorRepository::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like