Surfnet\StepupMiddleware\ApiBundle\Controller\RaLocationController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getRaLocationService()	0	4	1
A	listAction()	0	14	1

<?php

/**
 * Copyright 2016 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\ApiBundle\Controller;

use Surfnet\Stepup\Configuration\Value\Institution;
use Surfnet\StepupMiddleware\ApiBundle\Configuration\Query\RaLocationQuery;
use Surfnet\StepupMiddleware\ApiBundle\Configuration\Service\RaLocationService;
use Surfnet\StepupMiddleware\ApiBundle\Response\JsonCollectionResponse;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;

final class RaLocationController extends Controller
{
    public function listAction(Request $request, Institution $institution)
    {
        $this->denyAccessUnlessGranted(['ROLE_RA', 'ROLE_SS']);

        $query                 = new RaLocationQuery();
        $query->institution    = $institution;
        $query->orderBy        = $request->get('orderBy', $query->orderBy);
        $query->orderDirection = $request->get('orderDirection', $query->orderDirection);

        $raLocations = $this->getRaLocationService()->findByInstitution($query);
        $count = count($raLocations);

        return new JsonCollectionResponse($count, 1, $count, $raLocations);

It seems like $raLocations defined by $this->getRaLocationService()->findByInstitution($query) on line 39 can also be of type null; however, Surfnet\StepupMiddleware\ApiBundle\Response\JsonCollectionResponse::__construct() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @return RaLocationService
     */
    private function getRaLocationService()
    {
        return $this->container->get('surfnet_stepup_middleware_api.service.ra_location');
    }
}