InstitutionAuthorizationContext::isActorSraa() - Code Metrics - Inspection of "Integrate required SRAA authorization changes" - OpenConext/Stepup-Middleware - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/fga-sraa-authorization ( 8efd63 )

by Michiel

created 2018-10-24 11:10 UTC

InstitutionAuthorizationContext::isActorSraa() A

↳ Parent: InstitutionAuthorizationContext

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

/**
 * Copyright 2018 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\ApiBundle\Authorization\Value;

use Surfnet\Stepup\Identity\Value\Institution;

class InstitutionAuthorizationContext implements InstitutionAuthorizationContextInterface
{
    /**
     * @var Institution
     */
    private $actorInstitution;

    /**
     * @var InstitutionRoleSet
     */
    private $roleRequirements;

    /**
     * @var bool
     */
    private $isSraa;

    /**
     * AuthorizationContext constructor.
     * @param Institution $actorInstitution
     * @param InstitutionRoleSetInterface $roleRequirements
     * @param bool $isSraa describes if the actor is SRAA or not. Default: false
     */
    public function __construct(
        Institution $actorInstitution,
        InstitutionRoleSetInterface $roleRequirements,
        $isSraa = false
    ) {
        $this->actorInstitution = $actorInstitution;
        $this->roleRequirements = $roleRequirements;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->isSraa = $isSraa;
    }

    /**
     * @return Institution
     */
    public function getActorInstitution()
    {
        return $this->actorInstitution;
    }

    /**
     * @return InstitutionRoleSet
     */
    public function getRoleRequirements()
    {
        return $this->roleRequirements;
    }

    /**
     * @return bool
     */
    public function isActorSraa()
    {
        return $this->isSraa;
    }
}


1			<?php
2
3			/**
4			* Copyright 2018 SURFnet B.V.
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19			namespace Surfnet\StepupMiddleware\ApiBundle\Authorization\Value;
20
21			use Surfnet\Stepup\Identity\Value\Institution;
22
23			class InstitutionAuthorizationContext implements InstitutionAuthorizationContextInterface
24			{
25			/**
26			* @var Institution
27			*/
28			private $actorInstitution;
29
30			/**
31			* @var InstitutionRoleSet
32			*/
33			private $roleRequirements;
34
35			/**
36			* @var bool
37			*/
38			private $isSraa;
39
40			/**
41			* AuthorizationContext constructor.
42			* @param Institution $actorInstitution
43			* @param InstitutionRoleSetInterface $roleRequirements
44			* @param bool $isSraa describes if the actor is SRAA or not. Default: false
45			*/
46			public function __construct(
47			Institution $actorInstitution,
48			InstitutionRoleSetInterface $roleRequirements,
49			$isSraa = false
50			) {
51			$this->actorInstitution = $actorInstitution;
52			$this->roleRequirements = $roleRequirements;
			0 ignored issues – show Documentation Bug introduced 2018-10-04 13:13 UTC by Report Bug Copy Issue Report `$roleRequirements` is of type `object<Surfnet\StepupMid...tutionRoleSetInterface>`, but the property `$roleRequirements` was declared to be of type `object<Surfnet\StepupMid...lue\InstitutionRoleSet>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
53			$this->isSraa = $isSraa;
54			}
55
56			/**
57			* @return Institution
58			*/
59			public function getActorInstitution()
60			{
61			return $this->actorInstitution;
62			}
63
64			/**
65			* @return InstitutionRoleSet
66			*/
67			public function getRoleRequirements()
68			{
69			return $this->roleRequirements;
70			}
71
72			/**
73			* @return bool
74			*/
75			public function isActorSraa()
76			{
77			return $this->isSraa;
78			}
79			}
80

OpenConext / Stepup-Middleware

Push — feature/fga-sraa-authorization ( 8efd63 )

InstitutionAuthorizationContext::isActorSraa() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like