InstitutionWithPersonalRaDetailsProjector::__construct() - Code Metrics - Inspection of "Institutions with personal RA details" - OpenConext/Stepup-Middleware - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#127)

by A.

created 2016-06-21 11:00 UTC

__construct() A

↳ Parent: InstitutionWithPersonalRaDetailsProjector

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

/**
 * Copyright 2016 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddleware\ApiBundle\Configuration\Projector;

use Broadway\ReadModel\Projector;
use Surfnet\Stepup\Configuration\Event\InstitutionsWithPersonalRaDetailsUpdatedEvent;
use Surfnet\StepupMiddleware\ApiBundle\Configuration\Entity\InstitutionWithPersonalRaDetails;
use Surfnet\StepupMiddleware\ApiBundle\Configuration\Repository\InstitutionWithPersonalRaDetailsRepository;

final class InstitutionWithPersonalRaDetailsProjector extends Projector
{
    /**
     * @var InstitutionWithPersonalRaDetails
     */
    private $repository;

    public function __construct(InstitutionWithPersonalRaDetailsRepository $repository)
    {
        $this->repository = $repository;

    }

    public function applyInstitutionsWithPersonalRaDetailsUpdatedEvent(
        InstitutionsWithPersonalRaDetailsUpdatedEvent $event
    ) {
        foreach ($event->institutionsWithPersonalRaDetails as $institution) {
            $this->repository->addIfNotExists(InstitutionWithPersonalRaDetails::createFrom($institution));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }
}


1			<?php
2
3			/**
4			* Copyright 2016 SURFnet B.V.
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19			namespace Surfnet\StepupMiddleware\ApiBundle\Configuration\Projector;
20
21			use Broadway\ReadModel\Projector;
22			use Surfnet\Stepup\Configuration\Event\InstitutionsWithPersonalRaDetailsUpdatedEvent;
23			use Surfnet\StepupMiddleware\ApiBundle\Configuration\Entity\InstitutionWithPersonalRaDetails;
24			use Surfnet\StepupMiddleware\ApiBundle\Configuration\Repository\InstitutionWithPersonalRaDetailsRepository;
25
26			final class InstitutionWithPersonalRaDetailsProjector extends Projector
27			{
28			/**
29			* @var InstitutionWithPersonalRaDetails
30			*/
31			private $repository;
32
33			public function __construct(InstitutionWithPersonalRaDetailsRepository $repository)
34			{
35			$this->repository = $repository;
			0 ignored issues – show Documentation Bug introduced 2016-06-20 09:47 UTC by Report Bug Copy Issue Report It seems like `$repository` of type `object<Surfnet\StepupMid...nalRaDetailsRepository>` is incompatible with the declared type `object<Surfnet\StepupMid...nWithPersonalRaDetails>` of property `$repository`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
36			}
37
38			public function applyInstitutionsWithPersonalRaDetailsUpdatedEvent(
39			InstitutionsWithPersonalRaDetailsUpdatedEvent $event
40			) {
41			foreach ($event->institutionsWithPersonalRaDetails as $institution) {
42			$this->repository->addIfNotExists(InstitutionWithPersonalRaDetails::createFrom($institution));
			0 ignored issues – show Documentation introduced 2016-06-20 09:47 UTC by Report Bug Copy Issue Report `$institution` is of type `string`, but the function expects a `object<Surfnet\Stepup\Co...tion\Value\Institution>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug introduced 2016-06-20 09:47 UTC by Report Bug Copy Issue Report The method `addIfNotExists()` does not seem to exist on `object<Surfnet\StepupMid...nWithPersonalRaDetails>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
43			}
44			}
45			}
46

OpenConext / Stepup-Middleware

Pull Request — develop (#127)

__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like