Completed
Push — feature/fga-develop-merge ( 38d1cb...265513 )
by
unknown
03:19
created
ApiBundle/Configuration/Repository/InstitutionAuthorizationRepository.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,6 @@
 block discarded – undo
79 79
 
80 80
     /**
81 81
      * @param Institution $institution
82
-     * @param InstitutionAuthorizationOption $institutionOption
83 82
      * @throws \Doctrine\ORM\OptimisticLockException
84 83
      */
85 84
     public function clearInstitutionOption(Institution $institution)
Please login to merge, or discard this patch.
ApiBundle/Authorization/Value/InstitutionRoleSetInterface.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -23,5 +23,8 @@
 block discarded – undo
23 23
 
24 24
 interface InstitutionRoleSetInterface
25 25
 {
26
+    /**
27
+     * @return InstitutionRole[]
28
+     */
26 29
     public function getRoles();
27 30
 }
Please login to merge, or discard this patch.
src/Surfnet/StepupMiddleware/ApiBundle/Identity/Service/IdentityService.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,6 @@
 block discarded – undo
73 73
 
74 74
     /**
75 75
      * @param IdentityQuery $query
76
-     * @param InstitutionRoleSet $institutionRoles
77 76
      * @return \Pagerfanta\Pagerfanta
78 77
      */
79 78
     public function search(IdentityQuery $query)
Please login to merge, or discard this patch.
Surfnet/StepupMiddleware/ApiBundle/Controller/RaSecondFactorController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
 
75 75
     /**
76 76
      * @param Request $request
77
-     * @param Institution $institution
77
+     * @param Institution $actorInstitution
78 78
      * @return RaSecondFactorQuery
79 79
      */
80 80
     private function buildRaSecondFactorQuery(Request $request, Institution $actorInstitution)
Please login to merge, or discard this patch.
src/Surfnet/Stepup/Identity/Entity/RegistrationAuthorityCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
 
48 48
     /**
49 49
      * @param Institution $institution
50
-     * @return RegistrationAuthority
50
+     * @return boolean
51 51
      */
52 52
     public function exists(Institution $institution)
53 53
     {
Please login to merge, or discard this patch.
src/Surfnet/Stepup/Identity/Entity/InstitutionCollection.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 
50 50
     /**
51 51
      * @param Institution $institution
52
-     * @return Institution
52
+     * @return InstitutionRole
53 53
      */
54 54
     public function get(Institution $institution)
55 55
     {
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 
59 59
     /**
60 60
      * @param Institution $institution
61
-     * @return Institution
61
+     * @return boolean
62 62
      */
63 63
     public function exists(Institution $institution)
64 64
     {
Please login to merge, or discard this patch.
src/Surfnet/Stepup/Identity/Identity.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1001,7 +1001,7 @@
 block discarded – undo
1001 1001
     /**
1002 1002
      * This method is kept to be backwards compatible for changes before FGA
1003 1003
      *
1004
-     * @param AppointedAsRaaEvent $event
1004
+     * @param IdentityAccreditedAsRaEvent $event
1005 1005
      */
1006 1006
     protected function applyIdentityAccreditedAsRaEvent(IdentityAccreditedAsRaEvent $event)
1007 1007
     {
Please login to merge, or discard this patch.
StepupMiddleware/ApiBundle/Identity/Repository/RaListingRepository.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 
48 48
     /**
49 49
      * @param IdentityId $identityId The RA's identity id.
50
-     * @return null|RaListing
50
+     * @return RaListing
51 51
      */
52 52
     public function findByIdentityId(IdentityId $identityId)
53 53
     {
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
     /**
58 58
      * @param IdentityId $identityId The RA's identity id.
59 59
      * @param Institution $raInstitution
60
-     * @return null|RaListing
60
+     * @return RaListing
61 61
      */
62 62
     public function findByIdentityIdAndRaInstitution(IdentityId $identityId, Institution $raInstitution)
63 63
     {
Please login to merge, or discard this patch.
src/Surfnet/Stepup/Identity/Event/AppointedAsRaaEvent.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
     }
54 54
 
55 55
     /**
56
-     * @return mixed The object instance
56
+     * @return AppointedAsRaaEvent The object instance
57 57
      */
58 58
     public static function deserialize(array $data)
59 59
     {
Please login to merge, or discard this patch.