Surfnet\Stepup\Identity\Entity\RecoveryToken

Complexity

Total Complexity

6

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	complyWithRevocation()	0	9	1
A	create()	0	11	1
A	getTokenId()	0	3	1
A	getType()	0	3	1
A	revoke()	0	8	1
A	__construct()	0	2	1

<?php

/**
 * Copyright 2022 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\Stepup\Identity\Entity;

use Broadway\EventSourcing\EventSourcedAggregateRoot;
use Broadway\EventSourcing\SimpleEventSourcedEntity;
use Surfnet\Stepup\Identity\Api\Identity;
use Surfnet\Stepup\Identity\Event\CompliedWithRecoveryCodeRevocationEvent;
use Surfnet\Stepup\Identity\Event\RecoveryTokenRevokedEvent;
use Surfnet\Stepup\Identity\Value\IdentityId;
use Surfnet\Stepup\Identity\Value\RecoveryTokenId;
use Surfnet\Stepup\Identity\Value\RecoveryTokenType;

final class RecoveryToken extends SimpleEventSourcedEntity
{
    private ?RecoveryTokenId $tokenId = null;

    private ?RecoveryTokenType $type = null;

    private ?Identity $identity = null;

    public static function create(
        RecoveryTokenId $id,
        RecoveryTokenType $type,
        Identity&EventSourcedAggregateRoot $identity,
    ): self {
        $token = new self;

Parentheses must be used when instantiating a new class

        $token->tokenId = $id;
        $token->type = $type;
        $token->identity = $identity;
        $token->registerAggregateRoot($identity);
        return $token;
    }

    final public function __construct()
    {
    }

    public function getTokenId(): RecoveryTokenId
    {
        return $this->tokenId;
    }

    public function getType(): RecoveryTokenType
    {
        return $this->type;
    }

    public function revoke(): void
    {
        $this->apply(
            new RecoveryTokenRevokedEvent(
                $this->identity->getId(),

The method getId() does not exist on null.

                $this->identity->getInstitution(),
                $this->tokenId,

It seems like $this->tokenId can also be of type null; however, parameter $recoveryTokenId of Surfnet\Stepup\Identity\Event\RecoveryTokenRevokedEvent::__construct() does only seem to accept Surfnet\Stepup\Identity\Value\RecoveryTokenId, maybe add an additional type check?

                $this->type,

It seems like $this->type can also be of type null; however, parameter $recoveryTokenType of Surfnet\Stepup\Identity\Event\RecoveryTokenRevokedEvent::__construct() does only seem to accept Surfnet\Stepup\Identity\Value\RecoveryTokenType, maybe add an additional type check?

            ),
        );
    }

    public function complyWithRevocation(IdentityId $authorityId): void
    {
        $this->apply(
            new CompliedWithRecoveryCodeRevocationEvent(
                $this->identity->getId(),
                $this->identity->getInstitution(),
                $this->tokenId,

It seems like $this->tokenId can also be of type null; however, parameter $recoveryTokenId of Surfnet\Stepup\Identity\Event\CompliedWithRecoveryCodeRevocationEvent::__construct() does only seem to accept Surfnet\Stepup\Identity\Value\RecoveryTokenId, maybe add an additional type check?

                $this->type,

It seems like $this->type can also be of type null; however, parameter $recoveryTokenType of Surfnet\Stepup\Identity\Event\CompliedWithRecoveryCodeRevocationEvent::__construct() does only seem to accept Surfnet\Stepup\Identity\Value\RecoveryTokenType, maybe add an additional type check?

                $authorityId,
            ),
        );
    }
}