Surfnet\StepupMiddleware\GatewayBundle\Projector\SecondFactorProjector

Complexity

Total Complexity

13

Size/Duplication

Total Lines	122
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	isIdentityVetted()	0	3	1
A	applySecondFactorVettedWithoutTokenProofOfPossession()	0	13	1
A	applyCompliedWithVettedSecondFactorRevocationEvent()	0	15	2
A	applySecondFactorVettedEvent()	0	12	1
A	applyLocalePreferenceExpressedEvent()	0	7	2
A	applyYubikeySecondFactorBootstrappedEvent()	0	12	1
A	applyVettedSecondFactorRevokedEvent()	0	14	2
A	applySecondFactorMigratedEvent()	0	12	1
A	__construct()	0	2	1
A	applyIdentityForgottenEvent()	0	3	1

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

Missing @link tag in file comment

namespace Surfnet\StepupMiddleware\GatewayBundle\Projector;

use Surfnet\Stepup\Projector\Projector;
use Surfnet\Stepup\Identity\Event\CompliedWithVettedSecondFactorRevocationEvent;
use Surfnet\Stepup\Identity\Event\IdentityForgottenEvent;
use Surfnet\Stepup\Identity\Event\LocalePreferenceExpressedEvent;
use Surfnet\Stepup\Identity\Event\SecondFactorMigratedEvent;
use Surfnet\Stepup\Identity\Event\SecondFactorVettedEvent;
use Surfnet\Stepup\Identity\Event\SecondFactorVettedWithoutTokenProofOfPossession;
use Surfnet\Stepup\Identity\Event\VettedSecondFactorRevokedEvent;
use Surfnet\Stepup\Identity\Event\YubikeySecondFactorBootstrappedEvent;
use Surfnet\Stepup\Identity\Value\VettingType;
use Surfnet\StepupMiddleware\GatewayBundle\Entity\SecondFactor;
use Surfnet\StepupMiddleware\GatewayBundle\Exception\RuntimeException;
use Surfnet\StepupMiddleware\GatewayBundle\Repository\SecondFactorRepository;

class SecondFactorProjector extends Projector

Missing doc comment for class SecondFactorProjector

{
    public function __construct(private readonly SecondFactorRepository $repository)
    {
    }

    public function applyYubikeySecondFactorBootstrappedEvent(YubikeySecondFactorBootstrappedEvent $event): void
    {
        $this->repository->save(
            new SecondFactor(
                (string)$event->identityId,
                (string)$event->nameId,
                (string)$event->identityInstitution,
                (string)$event->preferredLocale,
                (string)$event->secondFactorId,
                (string)$event->yubikeyPublicId,
                'yubikey',
                true,
            ),
        );
    }

    public function applySecondFactorMigratedEvent(SecondFactorMigratedEvent $event): void
    {
        $this->repository->save(
            new SecondFactor(
                (string)$event->identityId,
                (string)$event->targetNameId,
                (string)$event->identityInstitution,
                (string)$event->preferredLocale,
                (string)$event->newSecondFactorId,
                $event->secondFactorIdentifier,
                $event->secondFactorType,
                $this->isIdentityVetted($event->vettingType),
            ),
        );
    }

    public function applySecondFactorVettedEvent(SecondFactorVettedEvent $event): void
    {
        $this->repository->save(
            new SecondFactor(
                (string)$event->identityId,
                (string)$event->nameId,
                (string)$event->identityInstitution,
                (string)$event->preferredLocale,
                (string)$event->secondFactorId,
                $event->secondFactorIdentifier,
                $event->secondFactorType,
                $this->isIdentityVetted($event->vettingType),

It seems like $event->vettingType can also be of type null; however, parameter $vettingType of Surfnet\StepupMiddleware\GatewayBundle\Projector\SecondFactorProjector::isIdentityVetted() does only seem to accept Surfnet\Stepup\Identity\Value\VettingType, maybe add an additional type check?

            ),
        );
    }

    public function applySecondFactorVettedWithoutTokenProofOfPossession(
        SecondFactorVettedWithoutTokenProofOfPossession $event,
    ): void {
        $this->repository->save(
            new SecondFactor(
                (string)$event->identityId,
                (string)$event->nameId,
                (string)$event->identityInstitution,
                (string)$event->preferredLocale,
                (string)$event->secondFactorId,
                $event->secondFactorIdentifier,
                $event->secondFactorType,
                $this->isIdentityVetted($event->vettingType),

It seems like $event->vettingType can also be of type null; however, parameter $vettingType of Surfnet\StepupMiddleware\GatewayBundle\Projector\SecondFactorProjector::isIdentityVetted() does only seem to accept Surfnet\Stepup\Identity\Value\VettingType, maybe add an additional type check?

            ),
        );
    }

    private function isIdentityVetted(VettingType $vettingType): bool

Private method name "SecondFactorProjector::isIdentityVetted" must be prefixed with an underscore

    {
        return $vettingType->type() !== VettingType::TYPE_SELF_ASSERTED_REGISTRATION;
    }

    protected function applyVettedSecondFactorRevokedEvent(VettedSecondFactorRevokedEvent $event): void
    {
        $secondFactor = $this->repository->findOneBySecondFactorId($event->secondFactorId);

        if ($secondFactor === null) {
            throw new RuntimeException(
                sprintf(
                    'Expected to find a second factor having secondFactorId "%s", found none.',
                    $event->secondFactorId,
                ),
            );
        }

        $this->repository->remove($secondFactor);
    }

    protected function applyCompliedWithVettedSecondFactorRevocationEvent(
        CompliedWithVettedSecondFactorRevocationEvent $event,
    ): void {
        $secondFactor = $this->repository->findOneBySecondFactorId($event->secondFactorId);

        if ($secondFactor === null) {
            throw new RuntimeException(
                sprintf(
                    'Expected to find a second factor having secondFactorId "%s", found none.',
                    $event->secondFactorId,
                ),
            );
        }

        $this->repository->remove($secondFactor);
    }

    protected function applyLocalePreferenceExpressedEvent(LocalePreferenceExpressedEvent $event): void
    {
        $secondFactors = $this->repository->findByIdentityId($event->identityId);

        foreach ($secondFactors as $secondFactor) {
            $secondFactor->displayLocale = (string)$event->preferredLocale;
            $this->repository->save($secondFactor);
        }
    }

    protected function applyIdentityForgottenEvent(IdentityForgottenEvent $event): void
    {
        $this->repository->removeByIdentityId($event->identityId);
    }
}