Surfnet\StepupMiddlewareClientBundle\Identity\Service\RaCandidateService

Complexity

Total Complexity

7

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	search()	0	16	2
A	assertIsValid()	0	8	2
A	get()	0	14	2

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddlewareClientBundle\Identity\Service;

use Surfnet\StepupMiddlewareClient\Identity\Dto\RaCandidateSearchQuery;
use Surfnet\StepupMiddlewareClient\Identity\Service\RaCandidateService as LibraryRaCandidateService;
use Surfnet\StepupMiddlewareClientBundle\Exception\InvalidResponseException;
use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\RaCandidateCollection;
use Surfnet\StepupMiddlewareClientBundle\Identity\Dto\RaCandidateInstitutions;
use Symfony\Component\Validator\Validator\ValidatorInterface;

class RaCandidateService
{
    /**
     * @var LibraryRaCandidateService
     */
    private $libraryService;

    /**
     * @var ValidatorInterface
     */
    private $validator;

    /**
     * @param LibraryRaCandidateService $libraryService
     * @param ValidatorInterface        $validator
     */
    public function __construct(LibraryRaCandidateService $libraryService, ValidatorInterface $validator)
    {
        $this->libraryService = $libraryService;
        $this->validator      = $validator;
    }

    /**
     * @param RaCandidateSearchQuery $query
     * @return RaCandidateCollection
     */
    public function search(RaCandidateSearchQuery $query)
    {
        $data = $this->libraryService->search($query);

        if ($data === null) {
            throw new InvalidResponseException(
                'Received a "null" as data when searching for RaCandidates, is the library service set up correctly?'
            );
        }

        $collection = RaCandidateCollection::fromData($data);

        $this->assertIsValid($collection, 'One or more RaCandidates are not valid');

        return $collection;
    }

    /**
     * @param string $identityId
     * @param string $institution

There is no parameter named $institution. Was it maybe removed?

     * @param string $actorId
     * @return RaCandidateInstitutions

Should the return type not be RaCandidateInstitutions|null?

     */
    public function get($identityId, $actorId)
    {
        $data = $this->libraryService->get($identityId, $actorId);

        if ($data === null) {
            return null;
        }

        $raCandidateInstitutions = RaCandidateInstitutions::fromData($data);

        $this->assertIsValid($raCandidateInstitutions, 'Received invalid RaCandidate');

        return $raCandidateInstitutions;
    }

    /**
     * @param mixed $value
     * @param string $message
     */
    private function assertIsValid($value, $message)
    {
        $violations = $this->validator->validate($value);

        if (count($violations)) {
            throw InvalidResponseException::withViolations($message, $violations);
        }
    }
}