RaLocation - Code Metrics - Inspection of "Add RA Location query, command and service objects..." - OpenConext/Stepup-Middleware-clientbundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/ra-locations ( 8e7bb5...72222c )

by Boy

created 2016-06-20 12:54 UTC

RaLocation A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	58
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	1
c	1
b	0
f	1
lcom	1
cbo	0
dl	58
loc	58
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	fromData()	11	11	1

How to fix Duplicated Code

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupMiddlewareClientBundle\Configuration\Dto;

use Surfnet\StepupMiddlewareClientBundle\Dto\Dto;
use Symfony\Component\Validator\Constraints as Assert;

class RaLocation implements Dto

{
    /**
     * @Assert\NotBlank(message="middleware_client.dto.ra_location.id.must_not_be_blank")
     * @Assert\Type(type="string", message="middleware_client.dto.ra_location.id.must_be_string")
     *
     * @var string
     */
    public $id;

    /**
     * @Assert\NotBlank(message="middleware_client.dto.ra_location.institution.must_not_be_blank")
     * @Assert\Type(type="string", message="middleware_client.dto.ra_location.institution.must_be_string")
     *
     * @var string
     */
    public $institution;

    /**
     * @Assert\NotBlank(message="middleware_client.dto.ra_location.name.must_not_be_blank")
     * @Assert\Type(type="string", message="middleware_client.dto.ra_location.name.must_be_string")
     *
     * @var string
     */
    public $name;

    /**
     * @Assert\NotBlank(message="middleware_client.dto.ra_location.location.must_not_be_blank")
     * @Assert\Type(type="string", message="middleware_client.dto.ra_location.location.must_be_string")
     *
     * @var string
     */
    public $location;

    /**
     * @Assert\NotBlank(message="middleware_client.dto.ra_location.contact_information.must_not_be_blank")
     * @Assert\Type(type="string", message="middleware_client.dto.ra_location.contact_information.must_be_string")
     *
     * @var string
     */
    public $contactInformation;

    /**
     * @param array $data
     * @return static
     */
    public static function fromData(array $data)
    {
        $raLocation                     = new self();
        $raLocation->identityId         = $data['id'];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $raLocation->institution        = $data['institution'];
        $raLocation->name               = $data['name'];
        $raLocation->location           = $data['location'];
        $raLocation->contactInformation = $data['contact_information'];

        return $raLocation;
    }
}


1		<?php
2
3		/**
4		* Copyright 2014 SURFnet bv
5		*
6		* Licensed under the Apache License, Version 2.0 (the "License");
7		* you may not use this file except in compliance with the License.
8		* You may obtain a copy of the License at
9		*
10		* http://www.apache.org/licenses/LICENSE-2.0
11		*
12		* Unless required by applicable law or agreed to in writing, software
13		* distributed under the License is distributed on an "AS IS" BASIS,
14		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15		* See the License for the specific language governing permissions and
16		* limitations under the License.
17		*/
18
19		namespace Surfnet\StepupMiddlewareClientBundle\Configuration\Dto;
20
21		use Surfnet\StepupMiddlewareClientBundle\Dto\Dto;
22		use Symfony\Component\Validator\Constraints as Assert;
23
24	View Code Duplication	class RaLocation implements Dto
		0 ignored issues – show Duplication introduced 2016-06-20 13:08 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		{
26		/**
27		* @Assert\NotBlank(message="middleware_client.dto.ra_location.id.must_not_be_blank")
28		* @Assert\Type(type="string", message="middleware_client.dto.ra_location.id.must_be_string")
29		*
30		* @var string
31		*/
32		public $id;
33
34		/**
35		* @Assert\NotBlank(message="middleware_client.dto.ra_location.institution.must_not_be_blank")
36		* @Assert\Type(type="string", message="middleware_client.dto.ra_location.institution.must_be_string")
37		*
38		* @var string
39		*/
40		public $institution;
41
42		/**
43		* @Assert\NotBlank(message="middleware_client.dto.ra_location.name.must_not_be_blank")
44		* @Assert\Type(type="string", message="middleware_client.dto.ra_location.name.must_be_string")
45		*
46		* @var string
47		*/
48		public $name;
49
50		/**
51		* @Assert\NotBlank(message="middleware_client.dto.ra_location.location.must_not_be_blank")
52		* @Assert\Type(type="string", message="middleware_client.dto.ra_location.location.must_be_string")
53		*
54		* @var string
55		*/
56		public $location;
57
58		/**
59		* @Assert\NotBlank(message="middleware_client.dto.ra_location.contact_information.must_not_be_blank")
60		* @Assert\Type(type="string", message="middleware_client.dto.ra_location.contact_information.must_be_string")
61		*
62		* @var string
63		*/
64		public $contactInformation;
65
66		/**
67		* @param array $data
68		* @return static
69		*/
70		public static function fromData(array $data)
71		{
72		$raLocation = new self();
73		$raLocation->identityId = $data['id'];
		0 ignored issues – show Bug introduced 2016-06-20 13:08 UTC by Report Bug Copy Issue Report The property `identityId` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
74		$raLocation->institution = $data['institution'];
75		$raLocation->name = $data['name'];
76		$raLocation->location = $data['location'];
77		$raLocation->contactInformation = $data['contact_information'];
78
79		return $raLocation;
80		}
81		}
82

OpenConext / Stepup-Middleware-clientbundle

Push — feature/ra-locations ( 8e7bb5...72222c )

RaLocation A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like