Surfnet\StepupMiddlewareClient\Configuration\Dto\RaLocationSearchQuery

Complexity

Total Complexity

7

Size/Duplication

Total Lines	83
Duplicated Lines	26.51 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	3
Bugs	2	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getInstitution()	0	4	1
A	setOrderBy()	0	8	1
A	setOrderDirection()	12	12	1
A	assertNonEmptyString()	10	10	2
A	toHttpQuery()	0	6	1

<?php

namespace Surfnet\StepupMiddlewareClient\Configuration\Dto;

use Assert;
use Surfnet\StepupMiddlewareClient\Dto\HttpQuery;

class RaLocationSearchQuery implements HttpQuery
{
    /**
     * @var string
     */
    private $institution;

    /**
     * @var string|null
     */
    private $orderBy = 'name';

    /**
     * @var string|null
     */
    private $orderDirection = 'asc';

    /**
     * @param string $institution
     */
    public function __construct($institution)
    {
        $this->assertNonEmptyString($institution, 'institution');

        $this->institution = $institution;
    }

    /**
     * @return string
     */
    public function getInstitution()
    {
        return $this->institution;
    }

    /**
     * @param string $orderBy
     * @return $this
     */
    public function setOrderBy($orderBy)
    {
        $this->assertNonEmptyString($orderBy, 'orderBy');

        $this->orderBy = $orderBy;

        return $this;
    }

    /**
     * @param string $orderDirection
     * @return $this
     */
    public function setOrderDirection($orderDirection)

This method seems to be duplicated in your project.

    {
        $this->assertNonEmptyString($orderDirection, 'orderDirection');
        Assert\that($orderDirection)->choice(
            ['asc', 'desc', '', null],
            "Invalid order direction, must be one of 'asc', 'desc'"
        );

        $this->orderDirection = $orderDirection;

        return $this;
    }

    private function assertNonEmptyString($value, $name)

This method seems to be duplicated in your project.

    {
        $message = sprintf(
            '"%s" must be a non-empty string, "%s" given',
            $name,
            (is_object($value) ? get_class($value) : gettype($value))
        );

        Assert\that($value)->string($message)->notEmpty($message);
    }

    public function toHttpQuery()
    {
        return '?institution=' . urlencode($this->institution)
            . '&orderBy=' . urlencode($this->orderBy)
            . '&orderDirection' . urlencode($this->orderDirection);
    }
}