RaLocationService   A
last analyzed

Complexity

Total Complexity 3

Size/Duplication

Total Lines 36
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 0
Metric Value
wmc 3
lcom 1
cbo 2
dl 36
loc 36
rs 10
c 0
b 0
f 0

3 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 4 4 1
A get() 4 4 1
A search() 4 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
/**
4
 * Copyright 2014 SURFnet bv
5
 *
6
 * Licensed under the Apache License, Version 2.0 (the "License");
7
 * you may not use this file except in compliance with the License.
8
 * You may obtain a copy of the License at
9
 *
10
 *     http://www.apache.org/licenses/LICENSE-2.0
11
 *
12
 * Unless required by applicable law or agreed to in writing, software
13
 * distributed under the License is distributed on an "AS IS" BASIS,
14
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
 * See the License for the specific language governing permissions and
16
 * limitations under the License.
17
 */
18
19
namespace Surfnet\StepupMiddlewareClient\Configuration\Service;
20
21
use Surfnet\StepupMiddlewareClient\Configuration\Dto\RaLocationSearchQuery;
22
use Surfnet\StepupMiddlewareClient\Exception\AccessDeniedToResourceException;
23
use Surfnet\StepupMiddlewareClient\Exception\MalformedResponseException;
24
use Surfnet\StepupMiddlewareClient\Exception\ResourceReadException;
25
use Surfnet\StepupMiddlewareClient\Service\ApiService;
26
27 View Code Duplication
class RaLocationService
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
28
{
29
    /**
30
     * @var ApiService
31
     */
32
    private $apiService;
33
34
    /**
35
     * @param ApiService $apiService
36
     */
37
    public function __construct(ApiService $apiService)
38
    {
39
        $this->apiService = $apiService;
40
    }
41
42
    /**
43
     * @param string $id The RA's locations ID.
44
     * @return null|array
45
     * @throws AccessDeniedToResourceException When the consumer isn't authorised to access given resource.
46
     * @throws ResourceReadException When the server doesn't respond with the resource.
47
     * @throws MalformedResponseException When the server doesn't respond with (well-formed) JSON.
48
     */
49
    public function get($id)
50
    {
51
        return $this->apiService->read('ra-location/%s', [$id]);
52
    }
53
54
    /**
55
     * @param RaLocationSearchQuery $searchQuery
56
     * @return mixed|null
57
     */
58
    public function search(RaLocationSearchQuery $searchQuery)
59
    {
60
        return $this->apiService->read('ra-location' . $searchQuery->toHttpQuery());
61
    }
62
}
63