OpenConext / Stepup-Gateway

src/Surfnet/StepupGateway/SecondFactorOnlyBundle/Service/SecondFactorOnlyNameIdValidationService.php

<?php
/**
 * Copyright 2016 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupGateway\SecondFactorOnlyBundle\Service;

use Psr\Log\LoggerInterface;
use Surfnet\StepupGateway\GatewayBundle\Service\SamlEntityService;

final class SecondFactorOnlyNameIdValidationService
{
    /**
     * @var LoggerInterface
     */
    private $logger;

    /**
     * @var SamlEntityService
     */
    private $entityService;

    public function __construct(LoggerInterface $logger, SamlEntityService $entityService)
    {
        $this->logger = $logger;
        $this->entityService = $entityService;
    }

    /**
     * @param LoggerInterface $logger
     * @return $this
     */
    public function with(LoggerInterface $logger)
    {
        $this->logger = $logger;
        return $this;
    }

    /**
     * Is the given SP allowed to authenticate via Second Factor Only for the given NameID?
     */
    public function validate(string $spEntityId, string $nameId): bool
    {
        if (!$nameId) {
            $this->logger->notice(
                'No NameID provided, sending response with status Requester Error'
            );
            return false;
        }

        $serviceProvider = $this->entityService->getServiceProvider($spEntityId);

        if (!$serviceProvider->isAllowedToUseSecondFactorOnlyFor($nameId)) {

The method isAllowedToUseSecondFactorOnlyFor() does not exist on Surfnet\SamlBundle\Entity\ServiceProvider. Are you sure you never get this type here, but always one of the subclasses?

            $this->logger->notice(
                sprintf(
                    'SP "%s" may not use SecondFactorOnly mode for nameid "%s", sending response with status Requester Error',
                    $spEntityId,
                    $nameId
                )
            );
            return false;
        }

        $this->logger->notice(
            sprintf(
                'SP "%s" is allowed to use SecondFactorOnly mode for nameid "%s"',
                $spEntityId,
                $nameId
            )
        );

        return true;
    }
}