Passed
Push — feature/sf6-upgrade ( f8da3c...b8e292 )
by Paul
05:01 queued 10s
created
StepupGateway/SamlStepupProviderBundle/Saml/ProxyResponseFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
         $this->stateHandler            = $stateHandler;
75 75
         $this->assertionSigningService = $assertionSigningService;
76 76
 
77
-        $this->currentTime = is_null($now) ? new DateTime('now', new DateTimeZone('UTC')): $now;
77
+        $this->currentTime = is_null($now) ? new DateTime('now', new DateTimeZone('UTC')) : $now;
78 78
     }
79 79
 
80 80
     /**
Please login to merge, or discard this patch.
SamlStepupProviderBundle/Provider/ConnectedServiceProviders.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
     public function getConfigurationOf(string $serviceProvider): ServiceProvider
49 49
     {
50 50
         if (!$this->isConnected($serviceProvider)) {
51
-            throw UnknownProviderException::create($serviceProvider, (string )$this->allowed);
51
+            throw UnknownProviderException::create($serviceProvider, (string) $this->allowed);
52 52
         }
53 53
 
54 54
         return $this->samlEntityService->getServiceProvider($serviceProvider);
Please login to merge, or discard this patch.
src/Surfnet/StepupGateway/GatewayBundle/Service/Gateway/RespondService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@
 block discarded – undo
96 96
         $response = $this->responseProxy->createProxyResponse(
97 97
             $responseContext->reconstituteAssertion(),
98 98
             $responseContext->getDestination(),
99
-            (string)$grantedLoa
99
+            (string) $grantedLoa
100 100
         );
101 101
 
102 102
         $logger->notice(sprintf(
Please login to merge, or discard this patch.
Surfnet/StepupGateway/GatewayBundle/Monolog/Logger/AuthenticationLogger.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@
 block discarded – undo
107 107
             'institution'           => $secondFactor->institution,
108 108
             'authentication_result' => $stateHandler->isSecondFactorVerified() ? 'OK' : 'FAILED',
109 109
             'resulting_loa'         => (string) $loa,
110
-            'sso' => $stateHandler->isVerifiedBySsoOn2faCookie() ? 'YES': 'NO',
110
+            'sso' => $stateHandler->isVerifiedBySsoOn2faCookie() ? 'YES' : 'NO',
111 111
         ];
112 112
 
113 113
         if ($stateHandler->isVerifiedBySsoOn2faCookie()) {
Please login to merge, or discard this patch.
src/Surfnet/StepupGateway/GatewayBundle/Saml/AssertionAdapter.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
      */
36 36
     public function inResponseToMatches($inResponseTo)
37 37
     {
38
-         return $this->getInResponseTo() === $inResponseTo;
38
+            return $this->getInResponseTo() === $inResponseTo;
39 39
     }
40 40
 
41 41
     /**
Please login to merge, or discard this patch.
src/Surfnet/StepupGateway/GatewayBundle/Saml/ResponseBuilder.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -95,20 +95,20 @@
 block discarded – undo
95 95
     private function isValidResponseStatus($status)
96 96
     {
97 97
         return in_array($status, [
98
-            Constants::STATUS_SUCCESS,            // weeee!
99
-            Constants::STATUS_REQUESTER,          // Something is wrong with the AuthnRequest
100
-            Constants::STATUS_RESPONDER,          // Something went wrong with the Response
101
-            Constants::STATUS_VERSION_MISMATCH,   // The version of the request message was incorrect
98
+            Constants::STATUS_SUCCESS, // weeee!
99
+            Constants::STATUS_REQUESTER, // Something is wrong with the AuthnRequest
100
+            Constants::STATUS_RESPONDER, // Something went wrong with the Response
101
+            Constants::STATUS_VERSION_MISMATCH, // The version of the request message was incorrect
102 102
         ]);
103 103
     }
104 104
 
105 105
     private function isValidResponseSubStatus($subStatus)
106 106
     {
107 107
         return in_array($subStatus, [
108
-            Constants::STATUS_AUTHN_FAILED,               // failed authentication
108
+            Constants::STATUS_AUTHN_FAILED, // failed authentication
109 109
             Constants::STATUS_INVALID_ATTR,
110 110
             Constants::STATUS_INVALID_NAMEID_POLICY,
111
-            Constants::STATUS_NO_AUTHN_CONTEXT,           // insufficient Loa or Loa cannot be met
111
+            Constants::STATUS_NO_AUTHN_CONTEXT, // insufficient Loa or Loa cannot be met
112 112
             Constants::STATUS_NO_AVAILABLE_IDP,
113 113
             Constants::STATUS_NO_PASSIVE,
114 114
             Constants::STATUS_NO_SUPPORTED_IDP,
Please login to merge, or discard this patch.
src/Surfnet/StepupGateway/GatewayBundle/Saml/ResponseContext.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
         $this->samlEntityService      = $samlEntityService;
80 80
         $this->stateHandler           = $stateHandler;
81 81
         $this->logger                 = $logger;
82
-        $this->generationTime         = is_null($now) ? new DateTime('now', new DateTimeZone('UTC')): $now;
82
+        $this->generationTime         = is_null($now) ? new DateTime('now', new DateTimeZone('UTC')) : $now;
83 83
     }
84 84
 
85 85
     /**
Please login to merge, or discard this patch.
src/Surfnet/StepupGateway/GatewayBundle/Form/Type/SendSmsChallengeType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
     {
30 30
         $builder->add('send_challenge', SubmitType::class, [
31 31
             'label' => 'gateway.form.gateway_send_sms_challenge.button.send_challenge',
32
-            'attr' => [ 'class' => 'btn btn-primary' ],
32
+            'attr' => ['class' => 'btn btn-primary'],
33 33
         ]);
34 34
     }
35 35
 
Please login to merge, or discard this patch.
src/Surfnet/StepupGateway/GatewayBundle/Sso2fa/Http/CookieHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
         return new Cookie(
95 95
             $this->configuration->getName(),
96 96
             $value,
97
-            $this->configuration->isPersistent() ? $this->getTimestamp($this->configuration->getLifetime()): 0,
97
+            $this->configuration->isPersistent() ? $this->getTimestamp($this->configuration->getLifetime()) : 0,
98 98
             '/',
99 99
             null,
100 100
             true,
Please login to merge, or discard this patch.