Passed
Push — main ( a1c3da...92595f )
by Michiel
09:16 queued 06:43
created
src/Surfnet/StepupGateway/GatewayBundle/Saml/ResponseContext.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
         $this->samlEntityService      = $samlEntityService;
80 80
         $this->stateHandler           = $stateHandler;
81 81
         $this->logger                 = $logger;
82
-        $this->generationTime         = is_null($now) ? new DateTime('now', new DateTimeZone('UTC')): $now;
82
+        $this->generationTime         = is_null($now) ? new DateTime('now', new DateTimeZone('UTC')) : $now;
83 83
     }
84 84
 
85 85
     /**
Please login to merge, or discard this patch.
src/Surfnet/StepupGateway/GatewayBundle/Form/Type/SendSmsChallengeType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
     {
30 30
         $builder->add('send_challenge', SubmitType::class, [
31 31
             'label' => 'gateway.form.gateway_send_sms_challenge.button.send_challenge',
32
-            'attr' => [ 'class' => 'btn btn-primary' ],
32
+            'attr' => ['class' => 'btn btn-primary'],
33 33
         ]);
34 34
     }
35 35
 
Please login to merge, or discard this patch.
src/Surfnet/StepupGateway/GatewayBundle/Sso2fa/Http/CookieHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
         return new Cookie(
95 95
             $this->configuration->getName(),
96 96
             $value,
97
-            $this->configuration->isPersistent() ? $this->getTimestamp($this->configuration->getLifetime()): 0,
97
+            $this->configuration->isPersistent() ? $this->getTimestamp($this->configuration->getLifetime()) : 0,
98 98
             '/',
99 99
             null,
100 100
             true,
Please login to merge, or discard this patch.
StepupGateway/SecondFactorOnlyBundle/Service/Gateway/ResponseValidator.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
             if ($subjectNameIdFromResponse !== $secondFactor->secondFactorIdentifier) {
70 70
                 throw new ReceivedInvalidSubjectNameIdException(
71 71
                     sprintf(
72
-                        'The nameID received from the GSSP (%s) did not match the selected second factor (%s). This '.
72
+                        'The nameID received from the GSSP (%s) did not match the selected second factor (%s). This ' .
73 73
                         'might be an indication someone is tampering with a GSSP. The authentication was started by %s',
74 74
                         $subjectNameIdFromResponse,
75 75
                         $secondFactor->secondFactorIdentifier,
Please login to merge, or discard this patch.
SecondFactorOnlyBundle/Controller/SecondFactorOnlyController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@
 block discarded – undo
149 149
         } else {
150 150
             // Render the regular SAML response, we do not return it yet, the SSO on 2FA handler will use it to store
151 151
             // the SSO on 2FA cookie.
152
-            $httpResponse =  $responseRendering->renderResponse($responseContext, $response, $request);
152
+            $httpResponse = $responseRendering->renderResponse($responseContext, $response, $request);
153 153
         }
154 154
 
155 155
         if ($response->isSuccess()) {
Please login to merge, or discard this patch.
src/Surfnet/StepupGateway/GatewayBundle/Service/ProxyResponseService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -160,7 +160,7 @@
 block discarded – undo
160 160
     private function addAuthenticationStatementTo(Assertion $newAssertion, Assertion $assertion): void
161 161
     {
162 162
         $newAssertion->setAuthnInstant($assertion->getAuthnInstant());
163
-        $newAssertion->setAuthnContextClassRef((string)$this->intrinsicLoa);
163
+        $newAssertion->setAuthnContextClassRef((string) $this->intrinsicLoa);
164 164
 
165 165
         $authority = $assertion->getAuthenticatingAuthority();
166 166
         $newAssertion->setAuthenticatingAuthority(
Please login to merge, or discard this patch.
tests/features/bootstrap/FeatureContext.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
      */
198 198
     public function anInstitutionThatAllows(string $institution, string $option): void
199 199
     {
200
-        switch(true) {
200
+        switch (true) {
201 201
             case $option === 'sso_on_2fa':
202 202
                 $optionColumnName = 'sso_on2fa_enabled';
203 203
                 break;
@@ -365,7 +365,7 @@  discard block
 block discarded – undo
365 365
     private function getCookieNames(array $responseCookieHeaders): array
366 366
     {
367 367
         $response = [];
368
-        foreach($responseCookieHeaders as $cookie) {
368
+        foreach ($responseCookieHeaders as $cookie) {
369 369
             $parts = explode('=', $cookie);
370 370
             $response[] = array_shift($parts);
371 371
         }
Please login to merge, or discard this patch.
DependencyInjection/SurfnetStepupGatewaySamlStepupProviderExtension.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
         $configuration = new Configuration();
43 43
         $config = $this->processConfiguration($configuration, $configs);
44 44
 
45
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
45
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
46 46
         $loader->load('services.yml');
47 47
 
48 48
         $connectedServiceProviders = $container->getDefinition('gssp.allowed_sps');
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
         $hostedDefinition = $this->buildHostedEntityDefinition($provider, $configuration, $routes);
138 138
         $container->setDefinition('gssp.provider.' . $provider . '.hosted_entities', $hostedDefinition);
139 139
 
140
-        $hostedSpDefinition  = (new Definition())
140
+        $hostedSpDefinition = (new Definition())
141 141
             ->setClass(\Surfnet\SamlBundle\Entity\ServiceProvider::class)
142 142
             ->setFactory([new Reference('gssp.provider.' . $provider . '.hosted_entities'), 'getServiceProvider'])
143 143
             ->setPublic(false);
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
      */
191 191
     private function createRemoteDefinition($provider, array $configuration, ContainerBuilder $container): void
192 192
     {
193
-        $definition    = new Definition(\Surfnet\SamlBundle\Entity\IdentityProvider::class, [
193
+        $definition = new Definition(\Surfnet\SamlBundle\Entity\IdentityProvider::class, [
194 194
             [
195 195
                 'entityId'        => $configuration['entity_id'],
196 196
                 'ssoUrl'          => $configuration['sso_url'],
Please login to merge, or discard this patch.
ci/qa/phpstan-baseline.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@
 block discarded – undo
1
-<?php declare(strict_types = 1);
1
+<?php declare(strict_types=1);
2 2
 
3 3
 $ignoreErrors = [];
4 4
 $ignoreErrors[] = [
Please login to merge, or discard this patch.
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -2,17 +2,17 @@
 block discarded – undo
2 2
 
3 3
 $ignoreErrors = [];
4 4
 $ignoreErrors[] = [
5
-	// identifier: function.deprecated
6
-	'message' => '#^Call to deprecated function GuzzleHttp\\\\json_decode\\(\\)\\:
5
+    // identifier: function.deprecated
6
+    'message' => '#^Call to deprecated function GuzzleHttp\\\\json_decode\\(\\)\\:
7 7
 json_decode will be removed in guzzlehttp/guzzle\\:8\\.0\\. Use Utils\\:\\:jsonDecode instead\\.$#',
8
-	'count' => 1,
9
-	'path' => __DIR__ . '/../../src/Surfnet/StepupGateway/GatewayBundle/Entity/SamlEntity.php',
8
+    'count' => 1,
9
+    'path' => __DIR__ . '/../../src/Surfnet/StepupGateway/GatewayBundle/Entity/SamlEntity.php',
10 10
 ];
11 11
 $ignoreErrors[] = [
12
-	// identifier: parameter.requiredAfterOptional
13
-	'message' => '#^Deprecated in PHP 8\\.0\\: Required parameter \\$value follows optional parameter \\$propertyPath\\.$#',
14
-	'count' => 1,
15
-	'path' => __DIR__ . '/../../src/Surfnet/StepupGateway/GatewayBundle/Exception/AssertionFailedException.php',
12
+    // identifier: parameter.requiredAfterOptional
13
+    'message' => '#^Deprecated in PHP 8\\.0\\: Required parameter \\$value follows optional parameter \\$propertyPath\\.$#',
14
+    'count' => 1,
15
+    'path' => __DIR__ . '/../../src/Surfnet/StepupGateway/GatewayBundle/Exception/AssertionFailedException.php',
16 16
 ];
17 17
 
18 18
 return ['parameters' => ['ignoreErrors' => $ignoreErrors]];
Please login to merge, or discard this patch.