OpenConext / Stepup-Gateway

src/Surfnet/StepupGateway/GatewayBundle/Sso2fa/Http/CookieHelper.php

Spacing +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
         return new Cookie(
             $this->configuration->getName(),
             $value,
-            $this->configuration->isPersistent() ? $this->getTimestamp($this->configuration->getLifetime()): 0,
+            $this->configuration->isPersistent() ? $this->getTimestamp($this->configuration->getLifetime()) : 0,
             '/',
             null,
             true,

src/Surfnet/StepupGateway/GatewayBundle/Controller/SecondFactorController.php

Indentation +1 added lines, -1 removed lines

@@ -271,7 +271,7 @@
             $form->addError(
                 new FormError(
                     $this->get('translator')
-                      ->trans('gateway.form.gateway_choose_second_factor.unknown_second_factor_type')
+                        ->trans('gateway.form.gateway_choose_second_factor.unknown_second_factor_type')
                 )
             );
         }

Spacing +2 added lines, -2 removed lines

@@ -247,7 +247,7 @@ 
 
             // Filter the selected second factor from the array collection
             $secondFactorFiltered = $secondFactors->filter(
-                function ($secondFactor) use ($secondFactorType) {
+                function($secondFactor) use ($secondFactorType) {
                     return $secondFactorType === $secondFactor->secondFactorType;
                 }
             );
@@ -392,7 +392,7 @@ 
         $form = $this->createForm(VerifyYubikeyOtpType::class, $command)->handleRequest($request);
         $cancelForm = $this->buildCancelAuthenticationForm($authenticationMode)->handleRequest($request);
 
-        if ($form->isSubmitted()  && $form->isValid()) {
+        if ($form->isSubmitted() && $form->isValid()) {
             $result = $this->getStepupService()->verifyYubikeyOtp($command);
             if ($result->didOtpVerificationFail()) {
                 $form->addError(

src/Kernel.php

Spacing +11 added lines, -11 removed lines

@@ -32,7 +32,7 @@ 
 
     public function registerBundles(): iterable
     {
-        $contents = require $this->getProjectDir().'/config/bundles.php';
+        $contents = require $this->getProjectDir() . '/config/bundles.php';
         foreach ($contents as $class => $envs) {
             if ($envs[$this->environment] ?? $envs['all'] ?? false) {
                 yield new $class();
@@ -47,23 +47,23 @@ 
 
     protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader): void
     {
-        $container->addResource(new FileResource($this->getProjectDir().'/config/bundles.php'));
+        $container->addResource(new FileResource($this->getProjectDir() . '/config/bundles.php'));
         $container->setParameter('container.dumper.inline_class_loader', \PHP_VERSION_ID < 70400 || $this->debug);
         $container->setParameter('container.dumper.inline_factories', true);
-        $confDir = $this->getProjectDir().'/config';
+        $confDir = $this->getProjectDir() . '/config';
 
-        $loader->load($confDir.'/{packages}/*'.self::CONFIG_EXTS, 'glob');
-        $loader->load($confDir.'/{packages}/'.$this->environment.'/*'.self::CONFIG_EXTS, 'glob');
-        $loader->load($confDir.'/{services}'.self::CONFIG_EXTS, 'glob');
-        $loader->load($confDir.'/{services}_'.$this->environment.self::CONFIG_EXTS, 'glob');
+        $loader->load($confDir . '/{packages}/*' . self::CONFIG_EXTS, 'glob');
+        $loader->load($confDir . '/{packages}/' . $this->environment . '/*' . self::CONFIG_EXTS, 'glob');
+        $loader->load($confDir . '/{services}' . self::CONFIG_EXTS, 'glob');
+        $loader->load($confDir . '/{services}_' . $this->environment . self::CONFIG_EXTS, 'glob');
     }
 
     protected function configureRoutes(RouteCollectionBuilder $routes): void
     {
-        $confDir = $this->getProjectDir().'/config';
+        $confDir = $this->getProjectDir() . '/config';
 
-        $routes->import($confDir.'/{routes}/'.$this->environment.'/*'.self::CONFIG_EXTS, '/', 'glob');
-        $routes->import($confDir.'/{routes}/*'.self::CONFIG_EXTS, '/', 'glob');
-        $routes->import($confDir.'/{routes}'.self::CONFIG_EXTS, '/', 'glob');
+        $routes->import($confDir . '/{routes}/' . $this->environment . '/*' . self::CONFIG_EXTS, '/', 'glob');
+        $routes->import($confDir . '/{routes}/*' . self::CONFIG_EXTS, '/', 'glob');
+        $routes->import($confDir . '/{routes}' . self::CONFIG_EXTS, '/', 'glob');
     }
 }

src/Surfnet/StepupGateway/SecondFactorOnlyBundle/Service/Gateway/ResponseValidator.php

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
             if ($subjectNameIdFromResponse !== $secondFactor->secondFactorIdentifier) {
                 throw new ReceivedInvalidSubjectNameIdException(
                     sprintf(
-                        'The nameID received from the GSSP (%s) did not match the selected second factor (%s). This '.
+                        'The nameID received from the GSSP (%s) did not match the selected second factor (%s). This ' .
                         'might be an indication someone is tampering with a GSSP. The authentication was started by %s',
                         $subjectNameIdFromResponse,
                         $secondFactor->secondFactorIdentifier,

src/Surfnet/StepupGateway/SecondFactorOnlyBundle/Controller/SecondFactorOnlyController.php

Spacing +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
         } else {
             // Render the regular SAML response, we do not return it yet, the SSO on 2FA handler will use it to store
             // the SSO on 2FA cookie.
-            $httpResponse =  $responseRendering->renderResponse($responseContext, $response, $request);
+            $httpResponse = $responseRendering->renderResponse($responseContext, $response, $request);
         }
 
         if ($response->isSuccess()) {

tests/features/bootstrap/FeatureContext.php

Switch Indentation +32 added lines, -32 removed lines

@@ -83,15 +83,15 @@ 
     public function aUserIdentifiedByWithAVettedToken($institution, $nameId, $tokenType)
     {
         switch (strtolower($tokenType)) {
-        case "yubikey":
-            $this->currentToken = $this->fixtureService->registerYubikeyToken($nameId, $institution);
-            break;
-        case "sms":
-            $this->currentToken = $this->fixtureService->registerSmsToken($nameId, $institution);
-            break;
-        case "tiqr":
-            $this->currentToken = $this->fixtureService->registerTiqrToken($nameId, $institution);
-            break;
+            case "yubikey":
+                $this->currentToken = $this->fixtureService->registerYubikeyToken($nameId, $institution);
+                break;
+            case "sms":
+                $this->currentToken = $this->fixtureService->registerSmsToken($nameId, $institution);
+                break;
+            case "tiqr":
+                $this->currentToken = $this->fixtureService->registerTiqrToken($nameId, $institution);
+                break;
         }
     }
 
@@ -101,15 +101,15 @@ 
     public function aUserIdentifiedByWithASelfAssertedToken($institution, $nameId, $tokenType)
     {
         switch (strtolower($tokenType)) {
-        case "yubikey":
-            $this->currentToken = $this->fixtureService->registerYubikeyToken($nameId, $institution, true);
-            break;
-        case "sms":
-            $this->currentToken = $this->fixtureService->registerSmsToken($nameId, $institution, true);
-            break;
-        case "tiqr":
-            $this->currentToken = $this->fixtureService->registerTiqrToken($nameId, $institution, true);
-            break;
+            case "yubikey":
+                $this->currentToken = $this->fixtureService->registerYubikeyToken($nameId, $institution, true);
+                break;
+            case "sms":
+                $this->currentToken = $this->fixtureService->registerSmsToken($nameId, $institution, true);
+                break;
+            case "tiqr":
+                $this->currentToken = $this->fixtureService->registerTiqrToken($nameId, $institution, true);
+                break;
         }
     }
 
@@ -197,11 +197,11 @@ 
     public function anInstitutionThatAllows(string $institution, string $option)
     {
         switch(true) {
-        case $option === 'sso_on_2fa':
-            $optionColumnName = 'sso_on2fa_enabled';
-            break;
-        default:
-            throw new RuntimeException(sprintf('Option "%s" is not supported', $option));
+            case $option === 'sso_on_2fa':
+                $optionColumnName = 'sso_on2fa_enabled';
+                break;
+            default:
+                throw new RuntimeException(sprintf('Option "%s" is not supported', $option));
         }
         $this->fixtureService->configureBoolean($institution, $optionColumnName, true);
     }
@@ -212,15 +212,15 @@ 
     public function iShouldSelectMyTokenOnTheWAYG($tokenType)
     {
         switch (strtolower($tokenType)) {
-        case "yubikey":
-            $this->minkContext->pressButton('gateway_choose_second_factor_choose_yubikey');
-            break;
-        case "sms":
-            $this->minkContext->pressButton('gateway_choose_second_factor_choose_sms');
-            break;
-        case "tiqr":
-            $this->minkContext->pressButton('gateway_choose_second_factor_choose_tiqr');
-            break;
+            case "yubikey":
+                $this->minkContext->pressButton('gateway_choose_second_factor_choose_yubikey');
+                break;
+            case "sms":
+                $this->minkContext->pressButton('gateway_choose_second_factor_choose_sms');
+                break;
+            case "tiqr":
+                $this->minkContext->pressButton('gateway_choose_second_factor_choose_tiqr');
+                break;
         }
     }
 

Spacing +2 added lines, -2 removed lines

@@ -196,7 +196,7 @@ 
      */
     public function anInstitutionThatAllows(string $institution, string $option)
     {
-        switch(true) {
+        switch (true) {
         case $option === 'sso_on_2fa':
             $optionColumnName = 'sso_on2fa_enabled';
             break;
@@ -364,7 +364,7 @@ 
     private function getCookieNames(array $responseCookieHeaders): array
     {
         $response = [];
-        foreach($responseCookieHeaders as $cookie) {
+        foreach ($responseCookieHeaders as $cookie) {
             $parts = explode('=', $cookie);
             $response[] = array_shift($parts);
         }