ServiceProvider::mayUseGateway() - Code Metrics - Inspection of "Feature/second factor only" - OpenConext/Stepup-Gateway - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#91)

by Boy

created 2016-05-26 10:18 UTC

ServiceProvider::mayUseGateway() A

↳ Parent: ServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Surfnet\StepupGateway\GatewayBundle\Entity;

use Surfnet\SamlBundle\Entity\ServiceProvider as BaseServiceProvider;

class ServiceProvider extends BaseServiceProvider
{
    /**
     * @return bool
     */
    public function mayUseGateway()
    {
        return !$this->mayUseSecondFactorOnly();
    }

    /**
     * @return bool
     */
    public function mayUseSecondFactorOnly()
    {
        return (bool) $this->get('secondFactorOnly', false);
    }

    /**
     * @param string $nameId
     * @return bool
     */
    public function isAllowedToUseSecondFactorOnlyFor($nameId)
    {
        if (empty($nameId)) {
            return false;
        }

        if (!$this->mayUseSecondFactorOnly()) {
            return false;
        }

        $nameIdPatterns = $this->get('secondFactorOnlyNameIdPatterns');
        foreach ($nameIdPatterns as $nameIdPattern) {
            if (fnmatch($nameIdPattern, $nameId)) {
                return true;
            }
        }
        return false;
    }
}


1			<?php
2
3			namespace Surfnet\StepupGateway\GatewayBundle\Entity;
4
5			use Surfnet\SamlBundle\Entity\ServiceProvider as BaseServiceProvider;
6
7			class ServiceProvider extends BaseServiceProvider
8			{
9			/**
10			* @return bool
11			*/
12			public function mayUseGateway()
13			{
14			return !$this->mayUseSecondFactorOnly();
15			}
16
17			/**
18			* @return bool
19			*/
20			public function mayUseSecondFactorOnly()
21			{
22			return (bool) $this->get('secondFactorOnly', false);
23			}
24
25			/**
26			* @param string $nameId
27			* @return bool
28			*/
29			public function isAllowedToUseSecondFactorOnlyFor($nameId)
30			{
31			if (empty($nameId)) {
32			return false;
33			}
34
35			if (!$this->mayUseSecondFactorOnly()) {
36			return false;
37			}
38
39			$nameIdPatterns = $this->get('secondFactorOnlyNameIdPatterns');
40			foreach ($nameIdPatterns as $nameIdPattern) {
41			if (fnmatch($nameIdPattern, $nameId)) {
42			return true;
43			}
44			}
45			return false;
46			}
47			}
48

OpenConext / Stepup-Gateway

Pull Request — develop (#91)

ServiceProvider::mayUseGateway() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like