SecondFactorOnlyNameIdValidationService::validate() - Code Metrics - Inspection of "Second Factor Only" - OpenConext/Stepup-Gateway - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#93)

by Boy

created 2016-06-01 09:07 UTC

validate() B

↳ Parent: SecondFactorOnlyNameIdValidationService

Complexity

Conditions	3
Paths	3

Size

Total Lines	32
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	32
rs	8.8571
cc	3
eloc	19
nc	3
nop	2

<?php

namespace Surfnet\StepupGateway\SecondFactorOnlyBundle\Service;

use Psr\Log\LoggerInterface;
use Surfnet\StepupGateway\GatewayBundle\Service\SamlEntityService;

final class SecondFactorOnlyNameIdValidationService
{
    /**
     * @var LoggerInterface
     */
    private $logger;

    /**
     * @var SamlEntityService
     */
    private $entityService;

    public function __construct(LoggerInterface $logger, SamlEntityService $entityService)
    {
        $this->logger = $logger;
        $this->entityService = $entityService;
    }

    /**
     * @param LoggerInterface $logger
     * @return $this
     */
    public function with(LoggerInterface $logger)
    {
        $this->logger = $logger;
        return $this;
    }

    /**
     * Is the given SP allowed to authenticate via Second Factor Only for the given NameID?
     *
     * @param string $spEntityId
     * @param string $nameId
     * @return bool
     */
    public function validate($spEntityId, $nameId)
    {
        if (!$nameId) {
            $this->logger->info(
                'No NameID provided, sending response with status Requester Error'
            );
            return false;
        }

        $serviceProvider = $this->entityService->getServiceProvider($spEntityId);

        if (!$serviceProvider->isAllowedToUseSecondFactorOnlyFor($nameId)) {
            $this->logger->info(
                sprintf(
                    'SP "%s" may not use SecondFactorOnly mode for nameid "%s", sending response with status Requester Error',

                    $spEntityId,
                    $nameId
                )
            );
            return false;
        }

        $this->logger->info(
            sprintf(
                'SP "%s" is allowed to use SecondFactorOnly mode for nameid "%s"',
                $spEntityId,
                $nameId
            )
        );

        return true;
    }
}


1			<?php
2
3			namespace Surfnet\StepupGateway\SecondFactorOnlyBundle\Service;
4
5			use Psr\Log\LoggerInterface;
6			use Surfnet\StepupGateway\GatewayBundle\Service\SamlEntityService;
7
8			final class SecondFactorOnlyNameIdValidationService
9			{
10			/**
11			* @var LoggerInterface
12			*/
13			private $logger;
14
15			/**
16			* @var SamlEntityService
17			*/
18			private $entityService;
19
20			public function __construct(LoggerInterface $logger, SamlEntityService $entityService)
21			{
22			$this->logger = $logger;
23			$this->entityService = $entityService;
24			}
25
26			/**
27			* @param LoggerInterface $logger
28			* @return $this
29			*/
30			public function with(LoggerInterface $logger)
31			{
32			$this->logger = $logger;
33			return $this;
34			}
35
36			/**
37			* Is the given SP allowed to authenticate via Second Factor Only for the given NameID?
38			*
39			* @param string $spEntityId
40			* @param string $nameId
41			* @return bool
42			*/
43			public function validate($spEntityId, $nameId)
44			{
45			if (!$nameId) {
46			$this->logger->info(
47			'No NameID provided, sending response with status Requester Error'
48			);
49			return false;
50			}
51
52			$serviceProvider = $this->entityService->getServiceProvider($spEntityId);
53
54			if (!$serviceProvider->isAllowedToUseSecondFactorOnlyFor($nameId)) {
55			$this->logger->info(
56			sprintf(
57			'SP "%s" may not use SecondFactorOnly mode for nameid "%s", sending response with status Requester Error',
			0 ignored issues – show Coding Style introduced 2016-05-31 20:12 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 126 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
58			$spEntityId,
59			$nameId
60			)
61			);
62			return false;
63			}
64
65			$this->logger->info(
66			sprintf(
67			'SP "%s" is allowed to use SecondFactorOnly mode for nameid "%s"',
68			$spEntityId,
69			$nameId
70			)
71			);
72
73			return true;
74			}
75			}
76

OpenConext / Stepup-Gateway

Pull Request — develop (#93)

validate() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like