MetadataController::metadataAction() - Code Metrics - Inspection of "Replace 'fnmatch' with custom implementation" - OpenConext/Stepup-Gateway - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/second-factor-only-2 ( 838e43 )

by Boy

created 2016-05-31 14:15 UTC

MetadataController::metadataAction() A

↳ Parent: MetadataController

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	8

Duplication

Lines	7
Ratio	46.67 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	7
loc	15
rs	9.4285
cc	2
eloc	8
nc	2
nop	0

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupGateway\SecondFactorOnlyBundle\Controller;

use Surfnet\SamlBundle\Http\XMLResponse;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;

class MetadataController extends Controller
{
    public function metadataAction()
    {
        if (!$this->get('service_container')->getParameter('second_factor_only')) {

            $this->get('logger')->notice(sprintf(
                'Access to %s denied, second_factor_only parameter set to false.',
                __METHOD__
            ));
            throw $this->createAccessDeniedException('Second Factor Only feature disabled');
        }

        /** @var \Surfnet\SamlBundle\Metadata\MetadataFactory $metadataFactory */
        $metadataFactory = $this->get('second_factor_only.metadata_factory');

        return new XMLResponse($metadataFactory->generate());
    }
}


1		<?php
2
3		/**
4		* Copyright 2014 SURFnet bv
5		*
6		* Licensed under the Apache License, Version 2.0 (the "License");
7		* you may not use this file except in compliance with the License.
8		* You may obtain a copy of the License at
9		*
10		* http://www.apache.org/licenses/LICENSE-2.0
11		*
12		* Unless required by applicable law or agreed to in writing, software
13		* distributed under the License is distributed on an "AS IS" BASIS,
14		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15		* See the License for the specific language governing permissions and
16		* limitations under the License.
17		*/
18
19		namespace Surfnet\StepupGateway\SecondFactorOnlyBundle\Controller;
20
21		use Surfnet\SamlBundle\Http\XMLResponse;
22		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
23
24		class MetadataController extends Controller
25		{
26		public function metadataAction()
27		{
28	View Code Duplication	if (!$this->get('service_container')->getParameter('second_factor_only')) {
		0 ignored issues – show Duplication introduced 2016-05-31 07:28 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		$this->get('logger')->notice(sprintf(
30		'Access to %s denied, second_factor_only parameter set to false.',
31		__METHOD__
32		));
33		throw $this->createAccessDeniedException('Second Factor Only feature disabled');
34		}
35
36		/** @var \Surfnet\SamlBundle\Metadata\MetadataFactory $metadataFactory */
37		$metadataFactory = $this->get('second_factor_only.metadata_factory');
38
39		return new XMLResponse($metadataFactory->generate());
40		}
41		}
42

OpenConext / Stepup-Gateway

Push — feature/second-factor-only-2 ( 838e43 )

MetadataController::metadataAction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like