Surfnet\StepupGateway\ApiBundle\Sms\MessageBirdService

Complexity

Total Complexity

3

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	send()	0	12	2

<?php

/**
 * Copyright 2021 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

PHP version not specified

Missing @category tag in file comment

Missing @package tag in file comment

Missing @author tag in file comment

Missing @license tag in file comment

Missing @link tag in file comment

namespace Surfnet\StepupGateway\ApiBundle\Sms;

use Psr\Log\LoggerInterface;
use Surfnet\MessageBirdApiClient\Messaging\Message;
use Surfnet\MessageBirdApiClientBundle\Service\MessagingService;
use Surfnet\StepupGateway\ApiBundle\Dto\SmsMessage;

class MessageBirdService implements SmsAdapterInterface

Missing doc comment for class MessageBirdService

{
    /**

Missing short description in doc comment

     * @var MessagingService
     */
    private $messagingService;

Private member variable "messagingService" must be prefixed with an underscore

    /**

Missing short description in doc comment

     * @var LoggerInterface
     */
    private $logger;

Private member variable "logger" must be prefixed with an underscore

    public function __construct(MessagingService $messagingService, LoggerInterface $logger)

Missing doc comment for function __construct()

    {
        $this->messagingService = $messagingService;
        $this->logger = $logger;
    }

    public function send(SmsMessage $message): SmsMessageResultInterface

Missing doc comment for function send()

    {
        $this->logger->notice('Using MessageBird to send an SMS');

        $message = new Message($message->originator, $message->recipient, $message->body);
        $result = $this->messagingService->send($message);

        if (!$result->isSuccess()) {
            $this->logger->warning('Sending OTP per SMS failed.');
        }

        return new MessageBirdMessageResult($result);
    }
}