Surfnet\StepupGateway\GatewayBundle\Saml\ResponseContext::getAuthenticatingIdp()

Complexity

Conditions	4
Paths	4

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	ResponseContext::saveSelectedSecondFactor()	0	5	1

<?php

/**
 * Copyright 2014 SURFnet bv
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

PHP version not specified

Missing @category tag in file comment

Missing @package tag in file comment

Missing @author tag in file comment

Missing @license tag in file comment

Missing @link tag in file comment

namespace Surfnet\StepupGateway\GatewayBundle\Saml;

use DateTime;
use DateTimeZone;
use DOMDocument;
use Exception;
use Psr\Log\LoggerInterface;
use SAML2\Assertion;
use SAML2\XML\saml\Issuer;
use Surfnet\SamlBundle\Entity\IdentityProvider;
use Surfnet\StepupGateway\GatewayBundle\Entity\SecondFactor;
use Surfnet\StepupGateway\GatewayBundle\Entity\ServiceProvider;
use Surfnet\StepupGateway\GatewayBundle\Saml\Exception\RuntimeException;
use Surfnet\StepupGateway\GatewayBundle\Saml\Proxy\ProxyStateHandler;
use Surfnet\StepupGateway\GatewayBundle\Service\SamlEntityService;
use Surfnet\StepupGateway\SecondFactorOnlyBundle\Adfs\Exception\AcsLocationNotAllowedException;

/**

Missing short description in doc comment

 * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
 */

Missing @category tag in class comment

Missing @package tag in class comment

Missing @author tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

class ResponseContext
{
    /**

Missing short description in doc comment

     * @var IdentityProvider
     */
    private $hostedIdentityProvider;

Private member variable "hostedIdentityProvider" must be prefixed with an underscore

    /**

Missing short description in doc comment

     * @var SamlEntityService
     */
    private $samlEntityService;

Private member variable "samlEntityService" must be prefixed with an underscore

    /**

Missing short description in doc comment

     * @var ProxyStateHandler
     */
    private $stateHandler;

Private member variable "stateHandler" must be prefixed with an underscore

    /**

Missing short description in doc comment

     * @var LoggerInterface
     */
    private $logger;

Private member variable "logger" must be prefixed with an underscore

    /**

Missing short description in doc comment

     * @var DateTime
     */
    private $generationTime;

Private member variable "generationTime" must be prefixed with an underscore

    /**

Missing short description in doc comment

     * @var ServiceProvider
     */
    private $targetServiceProvider;

Private member variable "targetServiceProvider" must be prefixed with an underscore

    /**

Missing short description in doc comment

Parameter $identityProvider should have a doc-comment as per coding-style.

Parameter $samlEntityService should have a doc-comment as per coding-style.

Parameter $stateHandler should have a doc-comment as per coding-style.

Parameter $logger should have a doc-comment as per coding-style.

Parameter $now should have a doc-comment as per coding-style.

     * @throws Exception
     */
    public function __construct(
        IdentityProvider $identityProvider,
        SamlEntityService $samlEntityService,
        ProxyStateHandler $stateHandler,
        LoggerInterface $logger,
        DateTime $now = null
    ) {
        $this->hostedIdentityProvider = $identityProvider;
        $this->samlEntityService      = $samlEntityService;
        $this->stateHandler           = $stateHandler;
        $this->logger                 = $logger;
        $this->generationTime         = is_null($now) ? new DateTime('now', new DateTimeZone('UTC')): $now;
    }

    /**

Missing short description in doc comment

     * @return string|null
     */
    public function getDestination(): ?string
    {
        $requestAcsUrl = $this->stateHandler->getRequestAssertionConsumerServiceUrl();

        return $this->getServiceProvider()->determineAcsLocation($requestAcsUrl, $this->logger);
    }

    /**

Missing short description in doc comment

     * @return string
     * @throws AcsLocationNotAllowedException
     */
    public function getDestinationForAdfs(): string
    {
        $requestAcsUrl = $this->stateHandler->getRequestAssertionConsumerServiceUrl();

        return $this->getServiceProvider()->determineAcsLocationForAdfs($requestAcsUrl);
    }

    public function getIssuer(): Issuer

Missing doc comment for function getIssuer()

    {
        $issuer = new Issuer();
        $issuer->setValue($this->hostedIdentityProvider->getEntityId());

It seems like $this->hostedIdentityProvider->getEntityId() can also be of type null; however, parameter $value of SAML2\XML\saml\NameIDType::setValue() does only seem to accept string, maybe add an additional type check?

        return $issuer;
    }

    /**

Missing short description in doc comment

     * @return int
     */
    public function getIssueInstant(): int
    {
        return $this->generationTime->getTimestamp();
    }

    /**

Missing short description in doc comment

     * @return null|string
     */
    public function getInResponseTo(): ?string
    {
        return $this->stateHandler->getRequestId();
    }

    /**

Missing short description in doc comment

     * @return null|string
     */
    public function getExpectedInResponseTo(): ?string
    {
        return $this->stateHandler->getGatewayRequestId();
    }

    /**

Missing short description in doc comment

     * @return null|string
     */
    public function getRequiredLoa(): ?string
    {
        return $this->stateHandler->getRequiredLoaIdentifier();
    }

    /**

Missing short description in doc comment

     * @return IdentityProvider
     */
    public function getIdentityProvider(): IdentityProvider
    {
        return $this->hostedIdentityProvider;
    }

    /**

Missing short description in doc comment

     * @return null|ServiceProvider
     */
    public function getServiceProvider(): ?ServiceProvider
    {
        if (isset($this->targetServiceProvider)) {
            return $this->targetServiceProvider;
        }

        $serviceProviderId = $this->stateHandler->getRequestServiceProvider();

        return $this->targetServiceProvider = $this->samlEntityService->getServiceProvider($serviceProviderId);
    }

    /**

Missing short description in doc comment

     * @return null|string
     */
    public function getRelayState(): ?string
    {
        return $this->stateHandler->getRelayState();
    }

    /**

Missing short description in doc comment

     * @param Assertion $assertion

Missing parameter comment

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @throws Exception

Tag @throws cannot be grouped with parameter tags in a doc comment

     */

Missing @return tag in function comment

    public function saveAssertion(Assertion $assertion): void
    {
        $this->stateHandler->saveIdentityNameId($this->resolveNameIdValue($assertion));
        // same for the entityId of the authenticating Authority
        $authenticatingAuthorities = $assertion->getAuthenticatingAuthority();
        if (!empty($authenticatingAuthorities)) {
            $this->stateHandler->setAuthenticatingIdp(reset($authenticatingAuthorities));
        }

        // And also attempt to save the user's schacHomeOrganization
        $attributes = $assertion->getAttributes();
        if (!empty($attributes['urn:mace:terena.org:attribute-def:schacHomeOrganization'])) {
            $schacHomeOrganization = $attributes['urn:mace:terena.org:attribute-def:schacHomeOrganization'];
            $this->stateHandler->setSchacHomeOrganization(reset($schacHomeOrganization));
        }

        $this->stateHandler->saveAssertion($assertion->toXML()->ownerDocument->saveXML());

The method saveXML() does not exist on null.

    }

    /**

Missing short description in doc comment

     * @return Assertion
     * @throws Exception
     */
    public function reconstituteAssertion(): Assertion
    {
        $assertionAsXML    = $this->stateHandler->getAssertion();
        $assertionDocument = new DOMDocument();
        $assertionDocument->loadXML($assertionAsXML);

        return new Assertion($assertionDocument->documentElement);
    }

    /**

Missing short description in doc comment

     * @return null|string
     */
    public function getIdentityNameId(): string
    {
        return $this->stateHandler->getIdentityNameId();
    }

    /**
     * Return the lower-cased schacHomeOrganization value from the assertion.
     *
     * Comparisons on SHO values should always be case-insensitive. Stepup
     * configuration always contains SHO values lower-cased, so this getter
     * can be used to compare the SHO with configured values.
     *
     * @see StepUpAuthenticationService::resolveHighestRequiredLoa()
     *
     * @return null|string
     */
    public function getNormalizedSchacHomeOrganization(): ?string
    {
        return strtolower(
            $this->stateHandler->getSchacHomeOrganization()

It seems like $this->stateHandler->getSchacHomeOrganization() can also be of type null; however, parameter $string of strtolower() does only seem to accept string, maybe add an additional type check?

        );
    }

    /**

Missing short description in doc comment

     * @param SecondFactor $secondFactor

Missing parameter comment

     */

Missing @return tag in function comment

    public function saveSelectedSecondFactor(SecondFactor $secondFactor): void
    {
        $this->stateHandler->setSelectedSecondFactorId($secondFactor->secondFactorId);
        $this->stateHandler->setSecondFactorVerified(false);
        $this->stateHandler->setPreferredLocale($secondFactor->displayLocale);
    }

    /**

Missing short description in doc comment

     * @return null|string
     */
    public function getSelectedSecondFactor(): ?string
    {
        return $this->stateHandler->getSelectedSecondFactorId();
    }

    public function markSecondFactorVerified(): void

Missing doc comment for function markSecondFactorVerified()

    {
        $this->stateHandler->setSecondFactorVerified(true);
    }

    public function finalizeAuthentication(): void

Missing doc comment for function finalizeAuthentication()

    {
        // The second factor ID is used right before sending the response to verify if the SSO on
        // 2FA cookies Second Factor is still known on the platform Thats why it is forgotten at
        // this point during authentication.
        $this->stateHandler->setSelectedSecondFactorId(null);
        // Right before sending the response, we check if we need to update the SSO on 2FA cookie
        // One of the triggers for storing a new cookie is if the authentication was performed with
        // a real Second Factor token. That's why this value is purged from state at this very late
        // point in time.
        $this->stateHandler->setVerifiedBySsoOn2faCookie(null);
    }

    /**

Missing short description in doc comment

     * @return bool
     */
    public function isSecondFactorVerified(): bool
    {
        return $this->stateHandler->getSelectedSecondFactorId() && $this->stateHandler->isSecondFactorVerified();
    }

    public function getResponseAction(): ?string

Missing doc comment for function getResponseAction()

    {
        return $this->stateHandler->getResponseAction();
    }

    /**
     * Resets some state after the response is sent
     * (e.g. resets which second factor was selected and whether it was verified).
     */

Missing @return tag in function comment

    public function responseSent()
    {
        $this->stateHandler->setSecondFactorVerified(false);
        $this->stateHandler->setSsoOn2faCookieFingerprint('');
    }

    /**
     * Retrieve the ResponseContextServiceId from state
     *
     * Used to determine we are dealing with an SFO or regular authentication. Both have different ResponseContext
     * instances, and it's imperative that successive consumers use the correct service.
     *
     * @return string|null
     */
    public function getResponseContextServiceId(): ?string
    {
        return $this->stateHandler->getResponseContextServiceId();
    }

    /**

Parameter $assertion should have a doc-comment as per coding-style.

     * Either gets the internal-collabPersonId if present or falls back on the regular name id attribute
     * @throws Exception

There must be exactly one blank line before the tags in a doc comment

     */

Missing @return tag in function comment

    private function resolveNameIdValue(Assertion $assertion): string

Private method name "ResponseContext::resolveNameIdValue" must be prefixed with an underscore

    {
        $attributes = $assertion->getAttributes();
        if (array_key_exists('urn:mace:surf.nl:attribute-def:internal-collabPersonId', $attributes)) {
            return reset($attributes['urn:mace:surf.nl:attribute-def:internal-collabPersonId']);
        }
        $nameId = $assertion->getNameId();
        if ($nameId && is_string($nameId->getValue())) {
            return $nameId->getValue();
        }

        throw new RuntimeException('Unable to resolve an identifier from internalCollabPersonId or the Subject NameId');
    }

    public function isForceAuthn(): bool

Missing doc comment for function isForceAuthn()

    {
        return $this->stateHandler->isForceAuthn();
    }

    public function markVerifiedBySsoOn2faCookie(string $fingerprint)

Missing doc comment for function markVerifiedBySsoOn2faCookie()

    {
        $this->logger->notice('Marking markVerifiedBySsoOn2faCookie');
        $this->stateHandler->setVerifiedBySsoOn2faCookie(true);
        $this->stateHandler->setSsoOn2faCookieFingerprint($fingerprint);
    }

    public function isVerifiedBySsoOn2faCookie(): bool

Missing doc comment for function isVerifiedBySsoOn2faCookie()

    {
        $isVerified = $this->stateHandler->isVerifiedBySsoOn2faCookie() ? 'YES': 'NO';
        $this->logger->notice(sprintf('Read isVerifiedBySsoOn2faCookie %s', $isVerified));
        return $this->stateHandler->isVerifiedBySsoOn2faCookie();
    }
}