1 | <?php |
||
32 | class SamlEntity |
||
33 | { |
||
34 | /** |
||
35 | * Constants denoting the type of SamlEntity. Also used in the middleware to make that distinction |
||
36 | */ |
||
37 | const TYPE_IDP = 'idp'; |
||
38 | const TYPE_SP = 'sp'; |
||
39 | |||
40 | /** |
||
41 | * @var string |
||
42 | * |
||
43 | * @ORM\Id |
||
44 | * @ORM\Column(length=36) |
||
45 | */ |
||
46 | private $id; |
||
47 | |||
48 | /** |
||
49 | * @ORM\Column |
||
50 | * |
||
51 | * @var string |
||
52 | */ |
||
53 | private $entityId; |
||
54 | |||
55 | /** |
||
56 | * @ORM\Column |
||
57 | * |
||
58 | * @var string |
||
59 | */ |
||
60 | private $type; |
||
61 | |||
62 | /** |
||
63 | * @ORM\Column(type="text") |
||
64 | * |
||
65 | * @var string the configuration as json string |
||
66 | */ |
||
67 | private $configuration; |
||
68 | |||
69 | /** |
||
70 | * @return IdentityProvider |
||
71 | */ |
||
72 | public function toIdentityProvider() |
||
73 | { |
||
74 | if (!$this->type === self::TYPE_IDP) { |
||
75 | throw new RuntimeException(sprintf( |
||
76 | 'Cannot cast a SAMLEntity to an IdentityProvider if it is not of the type "%s", current type: "%s"', |
||
77 | self::TYPE_IDP, |
||
78 | $this->type |
||
79 | )); |
||
80 | } |
||
81 | |||
82 | $decodedConfiguration = $this->decodeConfiguration(); |
||
83 | |||
84 | // index based will be supported later on |
||
85 | $configuration['entityId'] = $this->entityId; |
||
|
|||
86 | $configuration['configuredLoas'] = $decodedConfiguration['loa']; |
||
87 | |||
88 | return new IdentityProvider($configuration); |
||
89 | } |
||
90 | |||
91 | /** |
||
92 | * @return ServiceProvider |
||
93 | */ |
||
94 | public function toServiceProvider() |
||
95 | { |
||
96 | if (!$this->type === self::TYPE_SP) { |
||
97 | throw new RuntimeException(sprintf( |
||
98 | 'Cannot cast a SAMLEntity to a ServiceProvider if it is not of the type "%s", current type: "%s"', |
||
99 | self::TYPE_SP, |
||
100 | $this->type |
||
101 | )); |
||
102 | } |
||
103 | |||
104 | $decodedConfiguration = $this->decodeConfiguration(); |
||
105 | |||
106 | // index based will be supported later on |
||
107 | $configuration['assertionConsumerUrl'] = reset($decodedConfiguration['acs']); |
||
108 | $configuration['certificateData'] = $decodedConfiguration['public_key']; |
||
109 | $configuration['entityId'] = $this->entityId; |
||
110 | $configuration['configuredLoas'] = $decodedConfiguration['loa']; |
||
111 | |||
112 | $configuration['secondFactorOnly'] = false; |
||
113 | if (isset($decodedConfiguration['second_factor_only'])) { |
||
114 | $configuration['secondFactorOnly'] = $decodedConfiguration['second_factor_only']; |
||
115 | } |
||
116 | $configuration['secondFactorOnlyNameIdPatterns'] = []; |
||
117 | if (isset($decodedConfiguration['second_factor_only_nameid_patterns'])) { |
||
118 | $configuration['secondFactorOnlyNameIdPatterns'] = |
||
119 | $decodedConfiguration['second_factor_only_nameid_patterns']; |
||
120 | } |
||
121 | |||
122 | return new ServiceProvider($configuration); |
||
123 | } |
||
124 | |||
125 | /** |
||
126 | * Returns the decoded configuration |
||
127 | * |
||
128 | * @return array |
||
129 | */ |
||
130 | private function decodeConfiguration() |
||
134 | } |
||
135 |
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArray
is initialized the first time when the foreach loop is entered. You can also see that the value of thebar
key is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.