OpenConext / Stepup-Gateway

src/Surfnet/StepupGateway/GatewayBundle/Form/Type/SendSmsChallengeType.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
     {
         $builder->add('send_challenge', SubmitType::class, [
             'label' => 'gateway.form.gateway_send_sms_challenge.button.send_challenge',
-            'attr' => [ 'class' => 'btn btn-primary' ],
+            'attr' => ['class' => 'btn btn-primary'],
         ]);
     }
 

src/Surfnet/StepupGateway/GatewayBundle/Sso2fa/Http/CookieHelper.php

Spacing +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
         return new Cookie(
             $this->configuration->getName(),
             $value,
-            $this->configuration->isPersistent() ? $this->getTimestamp($this->configuration->getLifetime()): 0,
+            $this->configuration->isPersistent() ? $this->getTimestamp($this->configuration->getLifetime()) : 0,
             '/',
             null,
             true,

src/Surfnet/StepupGateway/SecondFactorOnlyBundle/Controller/SecondFactorOnlyController.php

Spacing +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
         } else {
             // Render the regular SAML response, we do not return it yet, the SSO on 2FA handler will use it to store
             // the SSO on 2FA cookie.
-            $httpResponse =  $responseRendering->renderResponse($responseContext, $response, $request);
+            $httpResponse = $responseRendering->renderResponse($responseContext, $response, $request);
         }
 
         if ($response->isSuccess()) {

src/Surfnet/StepupGateway/GatewayBundle/Service/ProxyResponseService.php

Spacing +1 added lines, -1 removed lines

@@ -160,7 +160,7 @@
     private function addAuthenticationStatementTo(Assertion $newAssertion, Assertion $assertion): void
     {
         $newAssertion->setAuthnInstant($assertion->getAuthnInstant());
-        $newAssertion->setAuthnContextClassRef((string)$this->intrinsicLoa);
+        $newAssertion->setAuthnContextClassRef((string) $this->intrinsicLoa);
 
         $authority = $assertion->getAuthenticatingAuthority();
         $newAssertion->setAuthenticatingAuthority(

tests/features/bootstrap/FeatureContext.php

Spacing +2 added lines, -2 removed lines

@@ -197,7 +197,7 @@ 
      */
     public function anInstitutionThatAllows(string $institution, string $option): void
     {
-        switch(true) {
+        switch (true) {
             case $option === 'sso_on_2fa':
                 $optionColumnName = 'sso_on2fa_enabled';
                 break;
@@ -365,7 +365,7 @@ 
     private function getCookieNames(array $responseCookieHeaders): array
     {
         $response = [];
-        foreach($responseCookieHeaders as $cookie) {
+        foreach ($responseCookieHeaders as $cookie) {
             $parts = explode('=', $cookie);
             $response[] = array_shift($parts);
         }

src/Surfnet/StepupGateway/SamlStepupProviderBundle/DependencyInjection/SurfnetStepupGatewaySamlStepupProviderExtension.php

Spacing +3 added lines, -3 removed lines

@@ -42,7 +42,7 @@ 
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.yml');
 
         $connectedServiceProviders = $container->getDefinition('gssp.allowed_sps');
@@ -137,7 +137,7 @@ 
         $hostedDefinition = $this->buildHostedEntityDefinition($provider, $configuration, $routes);
         $container->setDefinition('gssp.provider.' . $provider . '.hosted_entities', $hostedDefinition);
 
-        $hostedSpDefinition  = (new Definition())
+        $hostedSpDefinition = (new Definition())
             ->setClass(\Surfnet\SamlBundle\Entity\ServiceProvider::class)
             ->setFactory([new Reference('gssp.provider.' . $provider . '.hosted_entities'), 'getServiceProvider'])
             ->setPublic(false);
@@ -190,7 +190,7 @@ 
      */
     private function createRemoteDefinition($provider, array $configuration, ContainerBuilder $container): void
     {
-        $definition    = new Definition(\Surfnet\SamlBundle\Entity\IdentityProvider::class, [
+        $definition = new Definition(\Surfnet\SamlBundle\Entity\IdentityProvider::class, [
             [
                 'entityId'        => $configuration['entity_id'],
                 'ssoUrl'          => $configuration['sso_url'],

ci/qa/phpstan-baseline.php

Spacing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare(strict_types = 1);
+<?php declare(strict_types=1);
 
 $ignoreErrors = [];
 $ignoreErrors[] = [

Indentation +8 added lines, -8 removed lines

@@ -2,17 +2,17 @@
 
 $ignoreErrors = [];
 $ignoreErrors[] = [
-	// identifier: function.deprecated
-	'message' => '#^Call to deprecated function GuzzleHttp\\\\json_decode\\(\\)\\:
+    // identifier: function.deprecated
+    'message' => '#^Call to deprecated function GuzzleHttp\\\\json_decode\\(\\)\\:
 json_decode will be removed in guzzlehttp/guzzle\\:8\\.0\\. Use Utils\\:\\:jsonDecode instead\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/../../src/Surfnet/StepupGateway/GatewayBundle/Entity/SamlEntity.php',
+    'count' => 1,
+    'path' => __DIR__ . '/../../src/Surfnet/StepupGateway/GatewayBundle/Entity/SamlEntity.php',
 ];
 $ignoreErrors[] = [
-	// identifier: parameter.requiredAfterOptional
-	'message' => '#^Deprecated in PHP 8\\.0\\: Required parameter \\$value follows optional parameter \\$propertyPath\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/../../src/Surfnet/StepupGateway/GatewayBundle/Exception/AssertionFailedException.php',
+    // identifier: parameter.requiredAfterOptional
+    'message' => '#^Deprecated in PHP 8\\.0\\: Required parameter \\$value follows optional parameter \\$propertyPath\\.$#',
+    'count' => 1,
+    'path' => __DIR__ . '/../../src/Surfnet/StepupGateway/GatewayBundle/Exception/AssertionFailedException.php',
 ];
 
 return ['parameters' => ['ignoreErrors' => $ignoreErrors]];

tests/src/Controller/IdentityProviderController.php

Spacing +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
     {
         $newAssertion = new Assertion();
         $newAssertion->setNotBefore(time());
-        $newAssertion->setNotOnOrAfter(time() + (60 * 5));//
+        $newAssertion->setNotOnOrAfter(time() + (60 * 5)); //
         $newAssertion->setAttributes(['urn:mace:dir:attribute-def:eduPersonTargetedID' => [NameID::fromArray($nameId)]]);
         $newAssertion->setIssuer('https://idp.dev.openconext.local/');
         $newAssertion->setIssueInstant(time());

tests/src/Repository/SamlEntityRepository.php

Indentation +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
                 sprintf(
                     'Unable to insert the new SP saml_entity. PDO raised this error: "%s"',
                     $stmt->errorInfo()[2]
-               )
+                )
             );
         } else {
             // Return the SP data