OpenConext / Stepup-Gateway

src/Surfnet/StepupGateway/SamlStepupProviderBundle/DependencyInjection/SurfnetStepupGatewaySamlStepupProviderExtension.php

Spacing +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.yml');
 
         $connectedServiceProviders = $container->getDefinition('gssp.allowed_sps');
@@ -136,7 +136,7 @@ 
         $hostedDefinition = $this->buildHostedEntityDefinition($provider, $configuration, $routes);
         $container->setDefinition('gssp.provider.' . $provider . '.hosted_entities', $hostedDefinition);
 
-        $hostedSpDefinition  = (new Definition())
+        $hostedSpDefinition = (new Definition())
             ->setClass('Surfnet\SamlBundle\Entity\ServiceProvider')
             ->setFactory([new Reference('gssp.provider.' . $provider . '.hosted_entities'), 'getServiceProvider'])
             ->setPublic(false);
@@ -189,7 +189,7 @@ 
      */
     private function createRemoteDefinition($provider, array $configuration, ContainerBuilder $container)
     {
-        $definition    = new Definition('Surfnet\SamlBundle\Entity\IdentityProvider', [
+        $definition = new Definition('Surfnet\SamlBundle\Entity\IdentityProvider', [
             [
                 'entityId'        => $configuration['entity_id'],
                 'ssoUrl'          => $configuration['sso_url'],

src/Surfnet/StepupGateway/SamlStepupProviderBundle/DependencyInjection/Configuration.php

Spacing +3 added lines, -3 removed lines

@@ -56,7 +56,7 @@ 
                     ->scalarNode('sso')
                         ->isRequired()
                         ->validate()
-                            ->ifTrue(function ($v) {
+                            ->ifTrue(function($v) {
                                 return !is_string($v) || strlen($v) === 0;
                             })
                             ->thenInvalid('SSO route must be a non-empty string')
@@ -65,7 +65,7 @@ 
                     ->scalarNode('consume_assertion')
                         ->isRequired()
                         ->validate()
-                            ->ifTrue(function ($v) {
+                            ->ifTrue(function($v) {
                                 return !is_string($v) || strlen($v) === 0;
                             })
                             ->thenInvalid('Consume assertion route must be a non-empty string')
@@ -74,7 +74,7 @@ 
                     ->scalarNode('metadata')
                         ->isRequired()
                         ->validate()
-                            ->ifTrue(function ($v) {
+                            ->ifTrue(function($v) {
                                 return !is_string($v) || strlen($v) === 0;
                             })
                             ->thenInvalid('Metadata route must be a non-empty string')

src/Surfnet/StepupGateway/SamlStepupProviderBundle/DependencyInjection/Compiler/ViewConfigCollectionPass.php

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
         $taggedServices = array_keys($taggedServices);
 
         foreach ($taggedServices as $id) {
-            $gsspIdMatches= [];
+            $gsspIdMatches = [];
             preg_match('/^gssp\.view_config\.(\w+)$/', $id, $gsspIdMatches);
             if (!is_array($gsspIdMatches)) {
                 throw new InvalidConfigurationException('A manually tagged view config service was named incorrectly.');

src/Surfnet/StepupGateway/SamlStepupProviderBundle/Saml/ProxyResponseFactory.php

Spacing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
         $this->stateHandler            = $stateHandler;
         $this->assertionSigningService = $assertionSigningService;
 
-        $this->currentTime = is_null($now) ? new DateTime('now', new DateTimeZone('UTC')): $now;
+        $this->currentTime = is_null($now) ? new DateTime('now', new DateTimeZone('UTC')) : $now;
     }
 
     /**

src/Surfnet/StepupGateway/SamlStepupProviderBundle/Provider/ConnectedServiceProviders.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
     public function getConfigurationOf(string $serviceProvider): ServiceProvider
     {
         if (!$this->isConnected($serviceProvider)) {
-            throw UnknownProviderException::create($serviceProvider, (string )$this->allowed);
+            throw UnknownProviderException::create($serviceProvider, (string) $this->allowed);
         }
 
         return $this->samlEntityService->getServiceProvider($serviceProvider);

src/Surfnet/StepupGateway/GatewayBundle/Service/Gateway/RespondService.php

Spacing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
         $response = $this->responseProxy->createProxyResponse(
             $responseContext->reconstituteAssertion(),
             $responseContext->getDestination(),
-            (string)$grantedLoa
+            (string) $grantedLoa
         );
 
         $logger->notice(sprintf(

src/Surfnet/StepupGateway/GatewayBundle/Service/ProxyResponseService.php

Spacing +1 added lines, -1 removed lines

@@ -160,7 +160,7 @@
     private function addAuthenticationStatementTo(Assertion $newAssertion, Assertion $assertion)
     {
         $newAssertion->setAuthnInstant($assertion->getAuthnInstant());
-        $newAssertion->setAuthnContextClassRef((string)$this->intrinsicLoa);
+        $newAssertion->setAuthnContextClassRef((string) $this->intrinsicLoa);
 
         $authority = $assertion->getAuthenticatingAuthority();
         $newAssertion->setAuthenticatingAuthority(

src/Surfnet/StepupGateway/GatewayBundle/Monolog/Logger/AuthenticationLogger.php

Spacing +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
             'institution'           => $secondFactor->institution,
             'authentication_result' => $stateHandler->isSecondFactorVerified() ? 'OK' : 'FAILED',
             'resulting_loa'         => (string) $loa,
-            'sso' => $stateHandler->isVerifiedBySsoOn2faCookie() ? 'YES': 'NO',
+            'sso' => $stateHandler->isVerifiedBySsoOn2faCookie() ? 'YES' : 'NO',
         ];
 
         if ($stateHandler->isVerifiedBySsoOn2faCookie()) {

src/Surfnet/StepupGateway/GatewayBundle/Saml/ResponseBuilder.php

Spacing +6 added lines, -6 removed lines

@@ -95,20 +95,20 @@
     private function isValidResponseStatus($status)
     {
         return in_array($status, [
-            Constants::STATUS_SUCCESS,            // weeee!
-            Constants::STATUS_REQUESTER,          // Something is wrong with the AuthnRequest
-            Constants::STATUS_RESPONDER,          // Something went wrong with the Response
-            Constants::STATUS_VERSION_MISMATCH,   // The version of the request message was incorrect
+            Constants::STATUS_SUCCESS, // weeee!
+            Constants::STATUS_REQUESTER, // Something is wrong with the AuthnRequest
+            Constants::STATUS_RESPONDER, // Something went wrong with the Response
+            Constants::STATUS_VERSION_MISMATCH, // The version of the request message was incorrect
         ]);
     }
 
     private function isValidResponseSubStatus($subStatus)
     {
         return in_array($subStatus, [
-            Constants::STATUS_AUTHN_FAILED,               // failed authentication
+            Constants::STATUS_AUTHN_FAILED, // failed authentication
             Constants::STATUS_INVALID_ATTR,
             Constants::STATUS_INVALID_NAMEID_POLICY,
-            Constants::STATUS_NO_AUTHN_CONTEXT,           // insufficient Loa or Loa cannot be met
+            Constants::STATUS_NO_AUTHN_CONTEXT, // insufficient Loa or Loa cannot be met
             Constants::STATUS_NO_AVAILABLE_IDP,
             Constants::STATUS_NO_PASSIVE,
             Constants::STATUS_NO_SUPPORTED_IDP,