FeatureContext::iShouldSeeTheTiqrAuthenticationScreen() - Code Metrics - Inspection of "Write SFO error response test" - OpenConext/Stepup-Gateway - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — bugfix/saml-error-response-0-t... ( f7f4ec...d5527a )

by Michiel

created 2020-04-14 07:09 UTC

iShouldSeeTheTiqrAuthenticationScreen() A

↳ Parent: FeatureContext

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

/**
 * Copyright 2020 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupGateway\Behat;

use Behat\Behat\Context\Context;
use Behat\Behat\Hook\Scope\BeforeFeatureScope;
use Behat\Behat\Hook\Scope\BeforeScenarioScope;
use Surfnet\StepupGateway\Behat\Service\FixtureService;

class FeatureContext implements Context
{
    /**
     * @var FixtureService
     */
    private $fixtureService;

    private $whitelistedInstitutions = [];

    /**
     * @var MinkContext
     */
    private $minkContext;

    /**
     * @var array
     */
    private $currentToken;

    public function __construct(FixtureService $fixtureService)
    {
        $this->fixtureService = $fixtureService;
    }

    /**
     * @BeforeFeature
     */
    public static function setupDatabase(BeforeFeatureScope $scope)

    {
        // Generate test databases
        echo "Preparing test schemas\n";
        shell_exec("/var/www/app/console doctrine:schema:drop --env=webtest --force");
        shell_exec("/var/www/app/console doctrine:schema:create --env=webtest");
    }

    /**
     * @BeforeScenario
     */
    public function gatherContexts(BeforeScenarioScope $scope)
    {
        $environment = $scope->getEnvironment();
        $this->minkContext = $environment->getContext(MinkContext::class);
    }

    /**
     * @Given /^a user from ([^"]*) identified by ([^"]*) with a vetted ([^"]*) token$/
     */
    public function aUserIdentifiedByWithAVettedToken($institution, $nameId, $tokenType)
    {
        switch (strtolower($tokenType)) {
            case "yubikey":
                $this->currentToken = $this->fixtureService->registerYubikeyToken($nameId, $institution);
                break;
            case "sms":
                $this->currentToken = $this->fixtureService->registerSmsToken($nameId, $institution);
                break;
            case "tiqr":
                $this->currentToken = $this->fixtureService->registerTiqrToken($nameId, $institution);
                break;
        }
    }

    /**
     * @Given /^a user from ([^"]*) identified by ([^"]*)$/
     */
    public function aUserIdentifiedBy($institution, $nameId)

    {
        // For now, do nothing, this user is not known to Gateway, but might exist.
    }

    /**
     * @Then I should see the Yubikey OTP screen
     */
    public function iShouldSeeTheYubikeyOtpScreen()
    {
        $this->minkContext->assertPageContainsText('Log in with YubiKey');
        $this->minkContext->assertPageContainsText('Your YubiKey-code');
    }

    /**
     * @Then I should see the SMS verification screen
     */
    public function iShouldSeeTheSMSScreen()
    {
        $this->minkContext->assertPageContainsText('Log in with SMS');
        $this->minkContext->assertPageContainsText('Enter the received code on the next page');
        $this->minkContext->pressButton('gateway_send_sms_challenge_send_challenge');
        $this->minkContext->assertPageContainsText('Enter the received SMS-code');
        $this->minkContext->assertPageContainsText('Send again');
    }

    /**
     * @Given /^I should see the Tiqr authentication screen$/
     */
    public function iShouldSeeTheTiqrAuthenticationScreen()
    {
        $this->minkContext->pressButton('Submit');
        $this->minkContext->printLastResponse(); die;
        $this->minkContext->assertPageContainsText('Log in with Tiqr');
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    /**
     * @When I enter the OTP
     */
    public function iEnterTheOtp()
    {
        $this->minkContext->fillField('gateway_verify_yubikey_otp_otp', 'bogus-otp-we-use-a-mock-yubikey-service');
        $this->minkContext->pressButton('gateway_verify_yubikey_otp_submit');
        $this->minkContext->pressButton('Submit');
    }

    /**
     * @When I enter the SMS verification code
     */
    public function iEnterTheSmsVerificationCode()
    {
        $this->minkContext->fillField('gateway_verify_sms_challenge_challenge', '432543');
        $this->minkContext->pressButton('gateway_verify_sms_challenge_verify_challenge');
        $this->minkContext->pressButton('Submit');
    }


    /**
     * @When I finish the Tiqr authentication
     */
    public function iFinishGsspAuthentication()
    {
        $this->minkContext->pressButton('Submit');
        $this->minkContext->pressButton('Submit');
        $this->minkContext->printLastResponse(); die;
    }



    /**
     * @Given /^a whitelisted institution ([^"]*)$/
     */
    public function aWhitelistedInstitution($institution)
    {
        $this->whitelistedInstitutions[] = $this->fixtureService->whitelist($institution)['institution'];
    }

    /**
     * @Then /^I select my ([^"]*) token on the WAYG$/
     */
    public function iShouldSelectMyTokenOnTheWAYG($tokenType)
    {
        switch (strtolower($tokenType)) {
            case "yubikey":
                $this->minkContext->pressButton('gateway_choose_second_factor_choose_yubikey');
                break;
            case "sms":
                $this->minkContext->pressButton('gateway_choose_second_factor_choose_sms');
                break;
            case "tiqr":
                $this->minkContext->pressButton('gateway_choose_second_factor_choose_tiqr');
                break;
        }
    }

    /**
     * @Then /^I should be on the WAYG$/
     */
    public function iShouldBeOnTheWAYG()
    {
        $this->minkContext->assertPageContainsText('Choose a token for login');
    }
}


1			<?php
2
3			/**
4			* Copyright 2020 SURFnet B.V.
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19			namespace Surfnet\StepupGateway\Behat;
20
21			use Behat\Behat\Context\Context;
22			use Behat\Behat\Hook\Scope\BeforeFeatureScope;
23			use Behat\Behat\Hook\Scope\BeforeScenarioScope;
24			use Surfnet\StepupGateway\Behat\Service\FixtureService;
25
26			class FeatureContext implements Context
27			{
28			/**
29			* @var FixtureService
30			*/
31			private $fixtureService;
32
33			private $whitelistedInstitutions = [];
34
35			/**
36			* @var MinkContext
37			*/
38			private $minkContext;
39
40			/**
41			* @var array
42			*/
43			private $currentToken;
44
45			public function __construct(FixtureService $fixtureService)
46			{
47			$this->fixtureService = $fixtureService;
48			}
49
50			/**
51			* @BeforeFeature
52			*/
53			public static function setupDatabase(BeforeFeatureScope $scope)
			0 ignored issues – show Unused Code introduced 2020-03-26 20:34 UTC by Report Bug Copy Issue Report The parameter `$scope` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
54			{
55			// Generate test databases
56			echo "Preparing test schemas\n";
57			shell_exec("/var/www/app/console doctrine:schema:drop --env=webtest --force");
58			shell_exec("/var/www/app/console doctrine:schema:create --env=webtest");
59			}
60
61			/**
62			* @BeforeScenario
63			*/
64			public function gatherContexts(BeforeScenarioScope $scope)
65			{
66			$environment = $scope->getEnvironment();
67			$this->minkContext = $environment->getContext(MinkContext::class);
68			}
69
70			/**
71			* @Given /^a user from ([^"]) identified by ([^"]) with a vetted ([^"]*) token$/
72			*/
73			public function aUserIdentifiedByWithAVettedToken($institution, $nameId, $tokenType)
74			{
75			switch (strtolower($tokenType)) {
76			case "yubikey":
77			$this->currentToken = $this->fixtureService->registerYubikeyToken($nameId, $institution);
78			break;
79			case "sms":
80			$this->currentToken = $this->fixtureService->registerSmsToken($nameId, $institution);
81			break;
82			case "tiqr":
83			$this->currentToken = $this->fixtureService->registerTiqrToken($nameId, $institution);
84			break;
85			}
86			}
87
88			/**
89			* @Given /^a user from ([^"]) identified by ([^"])$/
90			*/
91			public function aUserIdentifiedBy($institution, $nameId)
			0 ignored issues – show Unused Code introduced 2020-04-14 07:11 UTC by Report Bug Copy Issue Report The parameter `$institution` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2020-04-14 07:11 UTC by Report Bug Copy Issue Report The parameter `$nameId` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
92			{
93			// For now, do nothing, this user is not known to Gateway, but might exist.
94			}
95
96			/**
97			* @Then I should see the Yubikey OTP screen
98			*/
99			public function iShouldSeeTheYubikeyOtpScreen()
100			{
101			$this->minkContext->assertPageContainsText('Log in with YubiKey');
102			$this->minkContext->assertPageContainsText('Your YubiKey-code');
103			}
104
105			/**
106			* @Then I should see the SMS verification screen
107			*/
108			public function iShouldSeeTheSMSScreen()
109			{
110			$this->minkContext->assertPageContainsText('Log in with SMS');
111			$this->minkContext->assertPageContainsText('Enter the received code on the next page');
112			$this->minkContext->pressButton('gateway_send_sms_challenge_send_challenge');
113			$this->minkContext->assertPageContainsText('Enter the received SMS-code');
114			$this->minkContext->assertPageContainsText('Send again');
115			}
116
117			/**
118			* @Given /^I should see the Tiqr authentication screen$/
119			*/
120			public function iShouldSeeTheTiqrAuthenticationScreen()
121			{
122			$this->minkContext->pressButton('Submit');
123			$this->minkContext->printLastResponse(); die;
124			$this->minkContext->assertPageContainsText('Log in with Tiqr');
			0 ignored issues – show Unused Code introduced 2020-04-02 15:14 UTC by Report Bug Copy Issue Report `$this->minkContext->asse...xt('Log in with Tiqr');` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
125			}
126
127			/**
128			* @When I enter the OTP
129			*/
130			public function iEnterTheOtp()
131			{
132			$this->minkContext->fillField('gateway_verify_yubikey_otp_otp', 'bogus-otp-we-use-a-mock-yubikey-service');
133			$this->minkContext->pressButton('gateway_verify_yubikey_otp_submit');
134			$this->minkContext->pressButton('Submit');
135			}
136
137			/**
138			* @When I enter the SMS verification code
139			*/
140			public function iEnterTheSmsVerificationCode()
141			{
142			$this->minkContext->fillField('gateway_verify_sms_challenge_challenge', '432543');
143			$this->minkContext->pressButton('gateway_verify_sms_challenge_verify_challenge');
144			$this->minkContext->pressButton('Submit');
145			}
146
147
148			/**
149			* @When I finish the Tiqr authentication
150			*/
151			public function iFinishGsspAuthentication()
152			{
153			$this->minkContext->pressButton('Submit');
154			$this->minkContext->pressButton('Submit');
155			$this->minkContext->printLastResponse(); die;
156			}
157
158
159
160			/**
161			* @Given /^a whitelisted institution ([^"]*)$/
162			*/
163			public function aWhitelistedInstitution($institution)
164			{
165			$this->whitelistedInstitutions[] = $this->fixtureService->whitelist($institution)['institution'];
166			}
167
168			/**
169			* @Then /^I select my ([^"]*) token on the WAYG$/
170			*/
171			public function iShouldSelectMyTokenOnTheWAYG($tokenType)
172			{
173			switch (strtolower($tokenType)) {
174			case "yubikey":
175			$this->minkContext->pressButton('gateway_choose_second_factor_choose_yubikey');
176			break;
177			case "sms":
178			$this->minkContext->pressButton('gateway_choose_second_factor_choose_sms');
179			break;
180			case "tiqr":
181			$this->minkContext->pressButton('gateway_choose_second_factor_choose_tiqr');
182			break;
183			}
184			}
185
186			/**
187			* @Then /^I should be on the WAYG$/
188			*/
189			public function iShouldBeOnTheWAYG()
190			{
191			$this->minkContext->assertPageContainsText('Choose a token for login');
192			}
193			}
194

OpenConext / Stepup-Gateway

Push — bugfix/saml-error-response-0-t... ( f7f4ec...d5527a )

iShouldSeeTheTiqrAuthenticationScreen() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like