FeatureContext::aUserIdentifiedBy() - Code Metrics - Inspection of "Remove useless step definition" - OpenConext/Stepup-Gateway - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — bugfix/saml-error-response-0-t... ( 396402...4bab03 )

by Michiel

created 2020-04-15 09:39 UTC

FeatureContext::aUserIdentifiedBy() A

↳ Parent: FeatureContext::iShouldSeeTheYubikeyOtpScreen()

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

/**
 * Copyright 2020 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupGateway\Behat;

use Behat\Behat\Context\Context;
use Behat\Behat\Hook\Scope\BeforeFeatureScope;
use Behat\Behat\Hook\Scope\BeforeScenarioScope;
use Behat\Behat\Tester\Exception\PendingException;
use Surfnet\StepupGateway\Behat\Service\FixtureService;

class FeatureContext implements Context
{
    /**
     * @var FixtureService
     */
    private $fixtureService;

    private $whitelistedInstitutions = [];

    /**
     * @var MinkContext
     */
    private $minkContext;

    /**
     * @var array
     */
    private $currentToken;

    public function __construct(FixtureService $fixtureService)
    {
        $this->fixtureService = $fixtureService;
    }

    /**
     * @BeforeFeature
     */
    public static function setupDatabase(BeforeFeatureScope $scope)

    {
        // Generate test databases
        echo "Preparing test schemas\n";
        shell_exec("/var/www/app/console doctrine:schema:drop --env=webtest --force");
        shell_exec("/var/www/app/console doctrine:schema:create --env=webtest");
    }

    /**
     * @BeforeScenario
     */
    public function gatherContexts(BeforeScenarioScope $scope)
    {
        $environment = $scope->getEnvironment();
        $this->minkContext = $environment->getContext(MinkContext::class);
    }

    /**
     * @Given /^a user from "([^"]*)" identified by "([^"]*)" with a vetted "([^"]*)" token$/
     */
    public function aUserIdentifiedByWithAVettedToken($institution, $nameId, $tokenType)
    {
        switch (strtolower($tokenType)) {
            case "yubikey":
                $this->currentToken = $this->fixtureService->registerYubikeyToken($nameId, $institution);
                break;
            case "sms":
                $this->currentToken = $this->fixtureService->registerSmsToken($nameId, $institution);
                break;
            case "tiqr":
                $this->currentToken = $this->fixtureService->registerTiqrToken($nameId, $institution);
                break;
        }
    }

    /**
     * @Then I should see the Yubikey OTP screen
     */
    public function iShouldSeeTheYubikeyOtpScreen()
    {
        $this->minkContext->assertPageContainsText('Log in with YubiKey');
        $this->minkContext->assertPageContainsText('Your YubiKey-code');
    }

    /**
     * @Then I should see the SMS verification screen
     */
    public function iShouldSeeTheSMSScreen()
    {
        $this->minkContext->assertPageContainsText('Log in with SMS');
        $this->minkContext->assertPageContainsText('Enter the received code on the next page');
        $this->minkContext->pressButton('gateway_send_sms_challenge_send_challenge');
        $this->minkContext->assertPageContainsText('Enter the received SMS-code');
        $this->minkContext->assertPageContainsText('Send again');
    }

    /**
     * @Given /^I should see the Tiqr authentication screen$/
     */
    public function iShouldSeeTheTiqrAuthenticationScreen()
    {
        $this->minkContext->pressButton('Submit');
        $this->minkContext->printLastResponse(); die;
        $this->minkContext->assertPageContainsText('Log in with Tiqr');
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    /**
     * @When I enter the OTP
     */
    public function iEnterTheOtp()
    {
        $this->minkContext->fillField('gateway_verify_yubikey_otp_otp', 'bogus-otp-we-use-a-mock-yubikey-service');
        $this->minkContext->pressButton('gateway_verify_yubikey_otp_submit');
        $this->minkContext->pressButton('Submit');
    }

    /**
     * @When I enter the SMS verification code
     */
    public function iEnterTheSmsVerificationCode()
    {
        $this->minkContext->fillField('gateway_verify_sms_challenge_challenge', '432543');
        $this->minkContext->pressButton('gateway_verify_sms_challenge_verify_challenge');
        $this->minkContext->pressButton('Submit');
    }


    /**
     * @When I finish the Tiqr authentication
     */
    public function iFinishGsspAuthentication()
    {
        $this->minkContext->pressButton('Submit');
        $this->minkContext->pressButton('Submit');
        $this->minkContext->printLastResponse(); die;
    }



    /**
     * @Given /^a whitelisted institution ([^"]*)$/
     */
    public function aWhitelistedInstitution($institution)
    {
        $this->whitelistedInstitutions[] = $this->fixtureService->whitelist($institution)['institution'];
    }

    /**
     * @Then /^I select my ([^"]*) token on the WAYG$/
     */
    public function iShouldSelectMyTokenOnTheWAYG($tokenType)
    {
        switch (strtolower($tokenType)) {
            case "yubikey":
                $this->minkContext->pressButton('gateway_choose_second_factor_choose_yubikey');
                break;
            case "sms":
                $this->minkContext->pressButton('gateway_choose_second_factor_choose_sms');
                break;
            case "tiqr":
                $this->minkContext->pressButton('gateway_choose_second_factor_choose_tiqr');
                break;
        }
    }

    /**
     * @Then /^I should be on the WAYG$/
     */
    public function iShouldBeOnTheWAYG()
    {
        $this->minkContext->assertPageContainsText('Choose a token for login');
    }

    /**
     * @Then /^an error response is posted back to the SP$/
     */
    public function anErrorResponseIsPostedBackToTheSP()
    {
        $this->minkContext->pressButton('Submit');
    }

    /**
     * @Given /^I cancel the authentication$/
     */
    public function iCancelTheAuthentication()
    {
        $this->minkContext->pressButton('Cancel');
    }
}


1			<?php
2
3			/**
4			* Copyright 2020 SURFnet B.V.
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19			namespace Surfnet\StepupGateway\Behat;
20
21			use Behat\Behat\Context\Context;
22			use Behat\Behat\Hook\Scope\BeforeFeatureScope;
23			use Behat\Behat\Hook\Scope\BeforeScenarioScope;
24			use Behat\Behat\Tester\Exception\PendingException;
25			use Surfnet\StepupGateway\Behat\Service\FixtureService;
26
27			class FeatureContext implements Context
28			{
29			/**
30			* @var FixtureService
31			*/
32			private $fixtureService;
33
34			private $whitelistedInstitutions = [];
35
36			/**
37			* @var MinkContext
38			*/
39			private $minkContext;
40
41			/**
42			* @var array
43			*/
44			private $currentToken;
45
46			public function __construct(FixtureService $fixtureService)
47			{
48			$this->fixtureService = $fixtureService;
49			}
50
51			/**
52			* @BeforeFeature
53			*/
54			public static function setupDatabase(BeforeFeatureScope $scope)
			0 ignored issues – show Unused Code introduced 2020-03-26 20:34 UTC by Report Bug Copy Issue Report The parameter `$scope` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
55			{
56			// Generate test databases
57			echo "Preparing test schemas\n";
58			shell_exec("/var/www/app/console doctrine:schema:drop --env=webtest --force");
59			shell_exec("/var/www/app/console doctrine:schema:create --env=webtest");
60			}
61
62			/**
63			* @BeforeScenario
64			*/
65			public function gatherContexts(BeforeScenarioScope $scope)
66			{
67			$environment = $scope->getEnvironment();
68			$this->minkContext = $environment->getContext(MinkContext::class);
69			}
70
71			/**
72			* @Given /^a user from "([^"])" identified by "([^"])" with a vetted "([^"]*)" token$/
73			*/
74			public function aUserIdentifiedByWithAVettedToken($institution, $nameId, $tokenType)
75			{
76			switch (strtolower($tokenType)) {
77			case "yubikey":
78			$this->currentToken = $this->fixtureService->registerYubikeyToken($nameId, $institution);
79			break;
80			case "sms":
81			$this->currentToken = $this->fixtureService->registerSmsToken($nameId, $institution);
82			break;
83			case "tiqr":
84			$this->currentToken = $this->fixtureService->registerTiqrToken($nameId, $institution);
85			break;
86			}
87			}
88
89			/**
90			* @Then I should see the Yubikey OTP screen
91			*/
92			public function iShouldSeeTheYubikeyOtpScreen()
93			{
94			$this->minkContext->assertPageContainsText('Log in with YubiKey');
95			$this->minkContext->assertPageContainsText('Your YubiKey-code');
96			}
97
98			/**
99			* @Then I should see the SMS verification screen
100			*/
101			public function iShouldSeeTheSMSScreen()
102			{
103			$this->minkContext->assertPageContainsText('Log in with SMS');
104			$this->minkContext->assertPageContainsText('Enter the received code on the next page');
105			$this->minkContext->pressButton('gateway_send_sms_challenge_send_challenge');
106			$this->minkContext->assertPageContainsText('Enter the received SMS-code');
107			$this->minkContext->assertPageContainsText('Send again');
108			}
109
110			/**
111			* @Given /^I should see the Tiqr authentication screen$/
112			*/
113			public function iShouldSeeTheTiqrAuthenticationScreen()
114			{
115			$this->minkContext->pressButton('Submit');
116			$this->minkContext->printLastResponse(); die;
117			$this->minkContext->assertPageContainsText('Log in with Tiqr');
			0 ignored issues – show Unused Code introduced 2020-04-02 15:14 UTC by Report Bug Copy Issue Report `$this->minkContext->asse...xt('Log in with Tiqr');` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
118			}
119
120			/**
121			* @When I enter the OTP
122			*/
123			public function iEnterTheOtp()
124			{
125			$this->minkContext->fillField('gateway_verify_yubikey_otp_otp', 'bogus-otp-we-use-a-mock-yubikey-service');
126			$this->minkContext->pressButton('gateway_verify_yubikey_otp_submit');
127			$this->minkContext->pressButton('Submit');
128			}
129
130			/**
131			* @When I enter the SMS verification code
132			*/
133			public function iEnterTheSmsVerificationCode()
134			{
135			$this->minkContext->fillField('gateway_verify_sms_challenge_challenge', '432543');
136			$this->minkContext->pressButton('gateway_verify_sms_challenge_verify_challenge');
137			$this->minkContext->pressButton('Submit');
138			}
139
140
141			/**
142			* @When I finish the Tiqr authentication
143			*/
144			public function iFinishGsspAuthentication()
145			{
146			$this->minkContext->pressButton('Submit');
147			$this->minkContext->pressButton('Submit');
148			$this->minkContext->printLastResponse(); die;
149			}
150
151
152
153			/**
154			* @Given /^a whitelisted institution ([^"]*)$/
155			*/
156			public function aWhitelistedInstitution($institution)
157			{
158			$this->whitelistedInstitutions[] = $this->fixtureService->whitelist($institution)['institution'];
159			}
160
161			/**
162			* @Then /^I select my ([^"]*) token on the WAYG$/
163			*/
164			public function iShouldSelectMyTokenOnTheWAYG($tokenType)
165			{
166			switch (strtolower($tokenType)) {
167			case "yubikey":
168			$this->minkContext->pressButton('gateway_choose_second_factor_choose_yubikey');
169			break;
170			case "sms":
171			$this->minkContext->pressButton('gateway_choose_second_factor_choose_sms');
172			break;
173			case "tiqr":
174			$this->minkContext->pressButton('gateway_choose_second_factor_choose_tiqr');
175			break;
176			}
177			}
178
179			/**
180			* @Then /^I should be on the WAYG$/
181			*/
182			public function iShouldBeOnTheWAYG()
183			{
184			$this->minkContext->assertPageContainsText('Choose a token for login');
185			}
186
187			/**
188			* @Then /^an error response is posted back to the SP$/
189			*/
190			public function anErrorResponseIsPostedBackToTheSP()
191			{
192			$this->minkContext->pressButton('Submit');
193			}
194
195			/**
196			* @Given /^I cancel the authentication$/
197			*/
198			public function iCancelTheAuthentication()
199			{
200			$this->minkContext->pressButton('Cancel');
201			}
202			}
203

OpenConext / Stepup-Gateway

Push — bugfix/saml-error-response-0-t... ( 396402...4bab03 )

FeatureContext::aUserIdentifiedBy() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like