FeatureContext::iShouldSeeTheSMSScreen() - Code Metrics - Inspection of "Create a SFO behat test" - OpenConext/Stepup-Gateway - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — feature/acceptance-tests (#191)

by Michiel

created 2020-03-30 12:57 UTC

FeatureContext::iShouldSeeTheSMSScreen() A

↳ Parent: FeatureContext

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

/**
 * Copyright 2020 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace Surfnet\StepupGateway\Behat;

use Behat\Behat\Context\Context;
use Behat\Behat\Hook\Scope\BeforeFeatureScope;
use Behat\Behat\Hook\Scope\BeforeScenarioScope;
use Behat\Behat\Tester\Exception\PendingException;
use Surfnet\StepupGateway\Behat\Service\FixtureService;

class FeatureContext implements Context
{
    /**
     * @var FixtureService
     */
    private $fixtureService;

    private $whitelistedInstitutions = [];

    /**
     * @var MinkContext
     */
    private $minkContext;

    /**
     * @var array
     */
    private $currentToken;

    public function __construct(FixtureService $fixtureService)
    {
        $this->fixtureService = $fixtureService;
    }

    /**
     * @BeforeFeature
     */
    public static function setupDatabase(BeforeFeatureScope $scope)

    {
        // Generate test databases
        echo "Preparing test schemas\n";
        shell_exec("/var/www/app/console doctrine:schema:drop --env=test --force");
        shell_exec("/var/www/app/console doctrine:schema:create --env=test");
    }

    /**
     * @BeforeScenario
     */
    public function gatherContexts(BeforeScenarioScope $scope)
    {
        $environment = $scope->getEnvironment();
        $this->minkContext = $environment->getContext(MinkContext::class);
    }

    /**
     * @Given /^a user from ([^"]*) identified by ([^"]*) with a vetted ([^"]*) token$/
     */
    public function aUserIdentifiedByWithAVettedToken($institution, $nameId, $tokenType)
    {
        switch (strtolower($tokenType)) {
            case "yubikey":
                $this->currentToken = $this->fixtureService->registerYubikeyToken($nameId, $institution);
                break;
            case "sms":
                $this->currentToken = $this->fixtureService->registerSmsToken($nameId, $institution);
                break;
        }
    }

    /**
     * @Then I should see the Yubikey OTP screen
     */
    public function iShouldSeeTheYubikeyOtpScreen()
    {
        $this->minkContext->printLastResponse(); die;
        $this->minkContext->assertPageContainsText('Log in with YubiKey');
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        $this->minkContext->assertPageContainsText('Your YubiKey-code');
    }

    /**
     * @Then I should see the SMS verification screen
     */
    public function iShouldSeeTheSMSScreen()
    {
        $this->minkContext->assertPageContainsText('Log in with SMS');
        $this->minkContext->assertPageContainsText('Enter the received code on the next page');
        $this->minkContext->pressButton('gateway_send_sms_challenge_send_challenge');
        $this->minkContext->assertPageContainsText('Enter the received SMS-code');
        $this->minkContext->assertPageContainsText('Send again');

    }

    /**
     * @When I enter the OTP
     */
    public function iEnterTheOtp()
    {
        $this->minkContext->fillField('gateway_verify_yubikey_otp_otp', 'bogus-otp-we-use-a-mock-yubikey-service');
        $this->minkContext->pressButton('gateway_verify_yubikey_otp_submit');
        $this->minkContext->pressButton('Submit');
    }

    /**
     * @When I enter the SMS verification code
     */
    public function iEnterTheSmsVerificationCode()
    {
        $this->minkContext->fillField('gateway_verify_sms_challenge_challenge', '432543');
        $this->minkContext->pressButton('gateway_verify_sms_challenge_verify_challenge');
        $this->minkContext->pressButton('Submit');
    }

    /**
     * @Given /^a whitelisted institution ([^"]*)$/
     */
    public function aWhitelistedInstitution($institution)
    {
        $this->whitelistedInstitutions[] = $this->fixtureService->whitelist($institution)['institution'];
    }

    /**
     * @Then /^I select my ([^"]*) token on the WAYG$/
     */
    public function iShouldSelectMyTokenOnTheWAYG($tokenType)
    {
        $this->minkContext->assertPageContainsText('Choose a token for login');
        switch (strtolower($tokenType)) {
            case "yubikey":
                $this->minkContext->pressButton('gateway_choose_second_factor_choose_yubikey');
                break;
            case "sms":
                $this->minkContext->pressButton('gateway_choose_second_factor_choose_sms');
                break;
        }
    }
}


1			<?php
2
3			/**
4			* Copyright 2020 SURFnet B.V.
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19			namespace Surfnet\StepupGateway\Behat;
20
21			use Behat\Behat\Context\Context;
22			use Behat\Behat\Hook\Scope\BeforeFeatureScope;
23			use Behat\Behat\Hook\Scope\BeforeScenarioScope;
24			use Behat\Behat\Tester\Exception\PendingException;
25			use Surfnet\StepupGateway\Behat\Service\FixtureService;
26
27			class FeatureContext implements Context
28			{
29			/**
30			* @var FixtureService
31			*/
32			private $fixtureService;
33
34			private $whitelistedInstitutions = [];
35
36			/**
37			* @var MinkContext
38			*/
39			private $minkContext;
40
41			/**
42			* @var array
43			*/
44			private $currentToken;
45
46			public function __construct(FixtureService $fixtureService)
47			{
48			$this->fixtureService = $fixtureService;
49			}
50
51			/**
52			* @BeforeFeature
53			*/
54			public static function setupDatabase(BeforeFeatureScope $scope)
			0 ignored issues – show Unused Code introduced 2020-03-26 20:34 UTC by Report Bug Copy Issue Report The parameter `$scope` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
55			{
56			// Generate test databases
57			echo "Preparing test schemas\n";
58			shell_exec("/var/www/app/console doctrine:schema:drop --env=test --force");
59			shell_exec("/var/www/app/console doctrine:schema:create --env=test");
60			}
61
62			/**
63			* @BeforeScenario
64			*/
65			public function gatherContexts(BeforeScenarioScope $scope)
66			{
67			$environment = $scope->getEnvironment();
68			$this->minkContext = $environment->getContext(MinkContext::class);
69			}
70
71			/**
72			* @Given /^a user from ([^"]) identified by ([^"]) with a vetted ([^"]*) token$/
73			*/
74			public function aUserIdentifiedByWithAVettedToken($institution, $nameId, $tokenType)
75			{
76			switch (strtolower($tokenType)) {
77			case "yubikey":
78			$this->currentToken = $this->fixtureService->registerYubikeyToken($nameId, $institution);
79			break;
80			case "sms":
81			$this->currentToken = $this->fixtureService->registerSmsToken($nameId, $institution);
82			break;
83			}
84			}
85
86			/**
87			* @Then I should see the Yubikey OTP screen
88			*/
89			public function iShouldSeeTheYubikeyOtpScreen()
90			{
91			$this->minkContext->printLastResponse(); die;
92			$this->minkContext->assertPageContainsText('Log in with YubiKey');
			0 ignored issues – show Unused Code introduced 2020-03-30 12:59 UTC by Report Bug Copy Issue Report `$this->minkContext->asse...'Log in with YubiKey');` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
93			$this->minkContext->assertPageContainsText('Your YubiKey-code');
94			}
95
96			/**
97			* @Then I should see the SMS verification screen
98			*/
99			public function iShouldSeeTheSMSScreen()
100			{
101			$this->minkContext->assertPageContainsText('Log in with SMS');
102			$this->minkContext->assertPageContainsText('Enter the received code on the next page');
103			$this->minkContext->pressButton('gateway_send_sms_challenge_send_challenge');
104			$this->minkContext->assertPageContainsText('Enter the received SMS-code');
105			$this->minkContext->assertPageContainsText('Send again');
106
107			}
108
109			/**
110			* @When I enter the OTP
111			*/
112			public function iEnterTheOtp()
113			{
114			$this->minkContext->fillField('gateway_verify_yubikey_otp_otp', 'bogus-otp-we-use-a-mock-yubikey-service');
115			$this->minkContext->pressButton('gateway_verify_yubikey_otp_submit');
116			$this->minkContext->pressButton('Submit');
117			}
118
119			/**
120			* @When I enter the SMS verification code
121			*/
122			public function iEnterTheSmsVerificationCode()
123			{
124			$this->minkContext->fillField('gateway_verify_sms_challenge_challenge', '432543');
125			$this->minkContext->pressButton('gateway_verify_sms_challenge_verify_challenge');
126			$this->minkContext->pressButton('Submit');
127			}
128
129			/**
130			* @Given /^a whitelisted institution ([^"]*)$/
131			*/
132			public function aWhitelistedInstitution($institution)
133			{
134			$this->whitelistedInstitutions[] = $this->fixtureService->whitelist($institution)['institution'];
135			}
136
137			/**
138			* @Then /^I select my ([^"]*) token on the WAYG$/
139			*/
140			public function iShouldSelectMyTokenOnTheWAYG($tokenType)
141			{
142			$this->minkContext->assertPageContainsText('Choose a token for login');
143			switch (strtolower($tokenType)) {
144			case "yubikey":
145			$this->minkContext->pressButton('gateway_choose_second_factor_choose_yubikey');
146			break;
147			case "sms":
148			$this->minkContext->pressButton('gateway_choose_second_factor_choose_sms');
149			break;
150			}
151			}
152			}
153

OpenConext / Stepup-Gateway

Pull Request — feature/acceptance-tests (#191)

FeatureContext::iShouldSeeTheSMSScreen() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like