UserRepository - Code Metrics - Inspection of "Make locales more configuration based" - OpenConext/OpenConext-profile - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#28)

by A.

created 2015-12-09 16:15 UTC

UserRepository A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	33
wmc	4
lcom	1
cbo	0
rs	10

3 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	findUser()	8	2
A	save()	4	1

<?php

/**
 * Copyright 2015 SURFnet B.V.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace OpenConext\ProfileBundle\Profile\Repository;

use OpenConext\Profile\Api\User;
use OpenConext\Profile\Repository\UserRepository as UserRepositoryInterface;
use Symfony\Component\HttpFoundation\Session\Attribute\NamespacedAttributeBag;
use Symfony\Component\HttpFoundation\Session\SessionBagInterface;

class UserRepository implements UserRepositoryInterface
{
    /**
     * @var SessionBagInterface
     */
    private $namespacedAttributeBag;

    public function __construct(NamespacedAttributeBag $namespacedAttributeBag)
    {
        $this->namespacedAttributeBag = $namespacedAttributeBag;
    }

    /**
     * @return User
     */
    public function findUser()
    {
        if (!$this->namespacedAttributeBag->has('user')) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return null;
        }

        return unserialize($this->namespacedAttributeBag->get('user'));
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * @param User $user
     * @return void
     */
    public function save(User $user)
    {
        $this->namespacedAttributeBag->set('user', serialize($user));
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}


1			<?php
2
3			/**
4			* Copyright 2015 SURFnet B.V.
5			*
6			* Licensed under the Apache License, Version 2.0 (the "License");
7			* you may not use this file except in compliance with the License.
8			* You may obtain a copy of the License at
9			*
10			* http://www.apache.org/licenses/LICENSE-2.0
11			*
12			* Unless required by applicable law or agreed to in writing, software
13			* distributed under the License is distributed on an "AS IS" BASIS,
14			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			* See the License for the specific language governing permissions and
16			* limitations under the License.
17			*/
18
19			namespace OpenConext\ProfileBundle\Profile\Repository;
20
21			use OpenConext\Profile\Api\User;
22			use OpenConext\Profile\Repository\UserRepository as UserRepositoryInterface;
23			use Symfony\Component\HttpFoundation\Session\Attribute\NamespacedAttributeBag;
24			use Symfony\Component\HttpFoundation\Session\SessionBagInterface;
25
26			class UserRepository implements UserRepositoryInterface
27			{
28			/**
29			* @var SessionBagInterface
30			*/
31			private $namespacedAttributeBag;
32
33			public function __construct(NamespacedAttributeBag $namespacedAttributeBag)
34			{
35			$this->namespacedAttributeBag = $namespacedAttributeBag;
36			}
37
38			/**
39			* @return User
40			*/
41			public function findUser()
42			{
43			if (!$this->namespacedAttributeBag->has('user')) {
			0 ignored issues – show Bug introduced 2015-12-09 16:21 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\HttpFo...ion\SessionBagInterface` as the method `has()` does only exist in the following implementations of said interface: `Symfony\Component\HttpFo...\Attribute\AttributeBag`, `Symfony\Component\HttpFo...\NamespacedAttributeBag`, `Symfony\Component\HttpFo...lash\AutoExpireFlashBag`, `Symfony\Component\HttpFo...\Session\Flash\FlashBag`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
44			return null;
45			}
46
47			return unserialize($this->namespacedAttributeBag->get('user'));
			0 ignored issues – show Bug introduced 2015-12-09 16:21 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\HttpFo...ion\SessionBagInterface` as the method `get()` does only exist in the following implementations of said interface: `Symfony\Component\HttpFo...\Attribute\AttributeBag`, `Symfony\Component\HttpFo...\NamespacedAttributeBag`, `Symfony\Component\HttpFo...lash\AutoExpireFlashBag`, `Symfony\Component\HttpFo...\Session\Flash\FlashBag`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
48			}
49
50			/**
51			* @param User $user
52			* @return void
53			*/
54			public function save(User $user)
55			{
56			$this->namespacedAttributeBag->set('user', serialize($user));
			0 ignored issues – show Bug introduced 2015-12-09 16:21 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\HttpFo...ion\SessionBagInterface` as the method `set()` does only exist in the following implementations of said interface: `Symfony\Component\HttpFo...\Attribute\AttributeBag`, `Symfony\Component\HttpFo...\NamespacedAttributeBag`, `Symfony\Component\HttpFo...lash\AutoExpireFlashBag`, `Symfony\Component\HttpFo...\Session\Flash\FlashBag`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
57			}
58			}
59

OpenConext / OpenConext-profile

Pull Request — develop (#28)

UserRepository A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like