Migration_Driver_Mysql_Column::sql() - Code Metrics - OpenBuildings/timestamped-migrations - Measure and Improve Code Quality continuously with Scrutinizer

Migration_Driver_Mysql_Column::sql() B
last analyzed 2017-11-14 23:04 UTC

↳ Parent: Migration_Driver_Mysql_Column

Complexity

Conditions	14
Paths	1

Size

Total Lines	18
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	17.9747

Importance

Changes

Metric	Value
dl	0
loc	18
ccs	8
cts	11
cp	0.7272
rs	7.37
c	0
b	0
f	0
cc	14
eloc	14
nc	1
nop	0
crap	17.9747

How to fix Complexity

<?php defined('SYSPATH') OR die('No direct script access.');

class Migration_Driver_Mysql_Column extends Migration_Driver_Column
{
	/**
	 * Valid types
	 * @var array
	 */
	static protected $types = array
	(
		'primary_key' => array('type' => 'INT', 'null' => FALSE, 'auto' => TRUE, 'primary' => TRUE),
		'string' => array('type' => 'VARCHAR', 'limit' => 255),
		'text' => array('type' => 'TEXT'),
		'integer' => array('type' => 'INT'),
		'float' => array('type' => 'FLOAT', 'limit' => 10, 'precision' => 2),
		'long' => array('type' => 'BIGINT'),
		'decimal' => array('type' => 'DECIMAL', 'limit' => 10, 'precision' => 2),
		'datetime' => array('type' => 'DATETIME'),
		'timestamp' => array('type' => 'TIMESTAMP'),
		'time' => array('type' => 'TIME'),
		'date' => array('type' => 'DATE'),
		'binary' => array('type' => 'BLOB', 'limit' => 255),
		'boolean' => array('type' => 'TINYINT', 'limit' => 1, 'null' => FALSE, 'default' => 0),
		'enum' => array('type' => 'ENUM', 'values' => array()),
	);

	static protected $native_types = array
	(
		'char' => 'string',
		'varchar' => 'string',
		'text' => 'text',
		'int' => 'integer',
		'integer' => 'integer',
		'tinyint' => 'boolean',
		'bigint' => 'integer',
		'float' => 'float',
		'decimal' => 'decimal',
		'datetime' => 'datetime',
		'timestamp' => 'timestamp',
		'time' => 'time',
		'date' => 'date',
		'blob' => 'binary',
		'enum' => 'enum',
	);

	public function column_params_for($column)
	{
		return Arr::get(self::$types, $column, array());
	}

	public function load($table_name)
	{
		if (is_string($table_name))
		{
			try
			{
				$result = $this->driver->pdo->query("SHOW COLUMNS FROM `$table_name` LIKE '{$this->name}'");

			}
			catch (PDOException $e)
			{
				$result = NULL;
			}

			if ( ! $result OR $result->rowCount() !== 1)
			{
				throw new Migration_Exception("Column :column was not found in table :table", array(':column' => $this->name, ':table' => $this->name));
			}

			$result = $result->fetchObject();
		}
		else
		{
			$result = $table_name;
		}

		if (preg_match('/([^\(]+)(\((\d+)\))?( UNSIGNED)?/', $result->Type, $type))
		{
			$limit = Arr::get($type, 3);
			$unsigned = isset($type[4]) ? TRUE : NULL;
			$type = $type[1];
			$values = NULL;
		}

		if (preg_match('/enum\(([^\)]+)\)/', $result->Type, $enum_type))
		{
			$type = 'ENUM';
			$limit = NULL;
			$unsigned = NULL;
			$values = explode(',', $enum_type[1]);
			foreach ($values as & $value)
			{
				$value = trim($value, "'");
			}
		}

		$this->params(array(
			'type' => $type,
			'limit' => $limit,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			'unsigned' => $unsigned,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			'values' => $values,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			'null' => $result->Null == 'NO' ? FALSE : TRUE,
			'default' => $result->Default ? $result->Default : NULL,
			'auto' => $result->Extra == 'auto_increment',
			'primary' => $result->Key == 'PRI',
		));

		return $this;
	}

	public function type()
	{
		return Arr::get(self::native_types, strtolower($this->type));
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}

	public function sql()
	{
		extract(Arr::extract($this->params, Migration_Driver_Column::$available_params));


		return join(' ', array_filter(array(
			"`{$this->name}`",
			$type,
			$limit ? ($precision ? ( "({$limit}, {$precision})" ) : "({$limit})") : NULL,
			$values ? ('('.join(', ', array_map(array($this->driver->pdo, 'quote'), $values)).')') : NULL,

			$unsigned ? ("UNSIGNED") : NULL,
			($default OR $default === 0 OR $default === '0') ? ("DEFAULT ".$this->driver->pdo->quote($default)) : NULL,
			$null !== NULL ? ($null ? "NULL" : "NOT NULL") : NULL,
			$auto ? ("AUTO_INCREMENT") : NULL,
			$comment ? ("COMMENT '{$comment}'") : NULL,
			$after ? ("AFTER `{$after}`") : NULL,
			$first ? ("FIRST") : NULL,
		)));
	}
}


1		<?php defined('SYSPATH') OR die('No direct script access.');
2
3		class Migration_Driver_Mysql_Column extends Migration_Driver_Column
4		{
5		/**
6		* Valid types
7		* @var array
8		*/
9		static protected $types = array
10		(
11		'primary_key' => array('type' => 'INT', 'null' => FALSE, 'auto' => TRUE, 'primary' => TRUE),
12		'string' => array('type' => 'VARCHAR', 'limit' => 255),
13		'text' => array('type' => 'TEXT'),
14		'integer' => array('type' => 'INT'),
15		'float' => array('type' => 'FLOAT', 'limit' => 10, 'precision' => 2),
16		'long' => array('type' => 'BIGINT'),
17		'decimal' => array('type' => 'DECIMAL', 'limit' => 10, 'precision' => 2),
18		'datetime' => array('type' => 'DATETIME'),
19		'timestamp' => array('type' => 'TIMESTAMP'),
20		'time' => array('type' => 'TIME'),
21		'date' => array('type' => 'DATE'),
22		'binary' => array('type' => 'BLOB', 'limit' => 255),
23		'boolean' => array('type' => 'TINYINT', 'limit' => 1, 'null' => FALSE, 'default' => 0),
24		'enum' => array('type' => 'ENUM', 'values' => array()),
25		);
26
27		static protected $native_types = array
28		(
29		'char' => 'string',
30		'varchar' => 'string',
31		'text' => 'text',
32		'int' => 'integer',
33		'integer' => 'integer',
34		'tinyint' => 'boolean',
35		'bigint' => 'integer',
36		'float' => 'float',
37		'decimal' => 'decimal',
38		'datetime' => 'datetime',
39		'timestamp' => 'timestamp',
40		'time' => 'time',
41		'date' => 'date',
42		'blob' => 'binary',
43		'enum' => 'enum',
44		);
45
46		public function column_params_for($column)
47		{
48		return Arr::get(self::$types, $column, array());
49		}
50
51		public function load($table_name)
52		{
53		if (is_string($table_name))
54	27	{
55		try
56	27	{
57		$result = $this->driver->pdo->query("SHOW COLUMNS FROM `$table_name` LIKE '{$this->name}'");
		0 ignored issues – show Bug introduced 2017-01-25 19:44 UTC by Report Bug Copy Issue Report The property `pdo` does not seem to exist in `Migration_Driver`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
58		}
59	2	catch (PDOException $e)
60		{
61	2	$result = NULL;
62	2	}
63
64		if ( ! $result OR $result->rowCount() !== 1)
65	2	{
66		throw new Migration_Exception("Column :column was not found in table :table", array(':column' => $this->name, ':table' => $this->name));
67	2	}
68
69	2	$result = $result->fetchObject();
70		}
71		else
72	2	{
73	2	$result = $table_name;
74	2	}
75
76		if (preg_match('/([^\(]+)(\((\d+)\))?( UNSIGNED)?/', $result->Type, $type))
77		{
78		$limit = Arr::get($type, 3);
79		$unsigned = isset($type[4]) ? TRUE : NULL;
80		$type = $type[1];
81		$values = NULL;
82		}
83
84		if (preg_match('/enum\(([^\)]+)\)/', $result->Type, $enum_type))
85		{
86		$type = 'ENUM';
87		$limit = NULL;
88		$unsigned = NULL;
89		$values = explode(',', $enum_type[1]);
90		foreach ($values as & $value)
91		{
92		$value = trim($value, "'");
93		}
94		}
95
96		$this->params(array(
97		'type' => $type,
98		'limit' => $limit,
		0 ignored issues – show Bug introduced 2017-01-25 19:44 UTC by Report Bug Copy Issue Report The variable `$limit` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
99		'unsigned' => $unsigned,
		0 ignored issues – show Bug introduced 2017-01-25 19:44 UTC by Report Bug Copy Issue Report The variable `$unsigned` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
100		'values' => $values,
		0 ignored issues – show Bug introduced 2017-01-25 19:44 UTC by Report Bug Copy Issue Report The variable `$values` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
101		'null' => $result->Null == 'NO' ? FALSE : TRUE,
102		'default' => $result->Default ? $result->Default : NULL,
103		'auto' => $result->Extra == 'auto_increment',
104		'primary' => $result->Key == 'PRI',
105		));
106
107		return $this;
108		}
109
110		public function type()
111		{
112		return Arr::get(self::native_types, strtolower($this->type));
		0 ignored issues – show Bug introduced 2017-01-25 19:44 UTC by Report Bug Copy Issue Report The property `type` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
113		}
114
115		public function sql()
116		{
117		extract(Arr::extract($this->params, Migration_Driver_Column::$available_params));
		0 ignored issues – show Bug introduced 2017-11-14 22:27 UTC by Report Bug Copy Issue Report `\Arr::extract($this->par...umn::$available_params)` cannot be passed to `extract()` as the parameter `$var_array` expects a reference. Loading history...
118
119		return join(' ', array_filter(array(
120		"`{$this->name}`",
121		$type,
122		$limit ? ($precision ? ( "({$limit}, {$precision})" ) : "({$limit})") : NULL,
123	28	$values ? ('('.join(', ', array_map(array($this->driver->pdo, 'quote'), $values)).')') : NULL,
		0 ignored issues – show Bug introduced 2017-01-25 19:44 UTC by Report Bug Copy Issue Report The property `pdo` does not seem to exist in `Migration_Driver`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
124		$unsigned ? ("UNSIGNED") : NULL,
125	28	($default OR $default === 0 OR $default === '0') ? ("DEFAULT ".$this->driver->pdo->quote($default)) : NULL,
126		$null !== NULL ? ($null ? "NULL" : "NOT NULL") : NULL,
127	28	$auto ? ("AUTO_INCREMENT") : NULL,
128	28	$comment ? ("COMMENT '{$comment}'") : NULL,
129	28	$after ? ("AFTER `{$after}`") : NULL,
130	28	$first ? ("FIRST") : NULL,
131	28	)));
132	28	}
133		}
134

OpenBuildings / timestamped-migrations

Migration_Driver_Mysql_Column::sql() B last analyzed 2017-11-14 23:04 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Migration_Driver_Mysql_Column::sql() B
last analyzed 2017-11-14 23:04 UTC