Migration_Driver_Mysql_Table

Complexity

Total Complexity

10

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

84.21%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	params()	0	17	3
A	load()	0	23	3
B	sql()	0	25	4

<?php defined('SYSPATH') OR die('No direct script access.');

class Migration_Driver_Mysql_Table extends Migration_Driver_Table
{

	public function params(array $columns = NULL, array $options = NULL)
	{
		$columns = (array) $columns;
		$this->options = Arr::get( (array) $options, 'options');

It seems like \Arr::get((array) $options, 'options') of type * is incompatible with the declared type array of property $options.

		if (Arr::get((array) $options, 'id', TRUE))
		{
			$columns = array_merge(array('id' => 'primary_key'), $columns);
		}

		foreach ($columns as $column_name => $params)
		{
			$this->columns[$column_name] = $this->driver->column($column_name)->params($params);
		}

		return $this;
	}

	public function load()
	{
		$this->columns = array();
		$this->options = array();
		$this->keys = array();

The property keys does not exist. Did you maybe forget to declare it?

		$result = $this->driver->pdo->query("SHOW TABLE STATUS LIKE '{$this->name}'");

The property pdo does not seem to exist in Migration_Driver.

		if ($result->rowCount() !== 1)
		{
			throw new Migration_Exception(":table does not exist", array(':table' => $this->name));
		}

		$table->options[] = 'ENGINE='.$result->fetchObject()->Engine;

The variable $table does not exist. Did you forget to declare it?

		$fields_reuslt = $this->driver->pdo->query("SHOW COLUMNS FROM `{$this->name}`");

		while($result = $fields_reuslt->fetchObject())
		{
			$this->columns[$result->Field] = $this->driver->column($result->Field)->load($result);
		}
		return $this;
	}

	public function sql()
	{
		$primary_keys = array();
		$columns = array();

		foreach ($this->columns as $column)
		{
			$columns[] = $column->sql();
			if ($column->param('primary'))
			{
				$primary_keys[] = "`".$column->name()."`";
			}
		}

		if ($primary_keys)

The expression $primary_keys of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

		{
			$columns[] = 'PRIMARY KEY ('.join(', ', $primary_keys).')';
		}

		return join(' ', array_filter(array(
			"CREATE TABLE `{$this->name}`",
			'('. join(', ', $columns).')',
			$this->options
		)));
	}
}