Driver_Simple_Xpath::find() - Code Metrics - Inspection of "Add opportunity to set custom phantomjs binary loc..." - OpenBuildings/spiderling - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#26)

by Evstati

created 2016-12-09 12:42 UTC

Driver_Simple_Xpath::find() B

↳ Parent: Driver_Simple_Xpath

Complexity

Conditions	5
Paths	7

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	0
cts	9
cp	0
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	9
nc	7
nop	2
crap	30

<?php

namespace Openbuildings\Spiderling;

/**
 * Xpath extension for simple driver
 *
 * @package    Openbuildings\Spiderling
 * @author     Ivan Kerin
 * @copyright  (c) 2013 OpenBuildings Ltd.
 * @license    http://spdx.org/licenses/BSD-3-Clause
 */
class Driver_Simple_Xpath extends \DOMXpath
{
	/**
	 * Find a DOMElement wit ha given xpath expression, optionally provide parent DOMNode to use as context.
	 * @param  string $expression
	 * @param  DOMNode $contextnode
	 * @return DOMNode
	 * @throws Exception_Xpath If no elements were found
	 */
	public function find($expression, $contextnode = NULL)
	{
		if ($expression instanceof \DOMNode)
			return $expression;

		@ $items = $contextnode ? $this->query($expression, $contextnode) : $this->query($expression);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

		if ( ! $items)
			throw new Exception_Xpath('Error in expression: ":expression"', array(':expression' => $expression));

		if ($items->length == 0)
			throw new Exception_Xpath('No element for selector ":expression"', array(':expression' => $expression));

		return $items->item(0);

	}
}


1			<?php
2
3			namespace Openbuildings\Spiderling;
4
5			/**
6			* Xpath extension for simple driver
7			*
8			* @package Openbuildings\Spiderling
9			* @author Ivan Kerin
10			* @copyright (c) 2013 OpenBuildings Ltd.
11			* @license http://spdx.org/licenses/BSD-3-Clause
12			*/
13			class Driver_Simple_Xpath extends \DOMXpath
14			{
15			/**
16			* Find a DOMElement wit ha given xpath expression, optionally provide parent DOMNode to use as context.
17			* @param string $expression
18			* @param DOMNode $contextnode
19			* @return DOMNode
20			* @throws Exception_Xpath If no elements were found
21			*/
22			public function find($expression, $contextnode = NULL)
23			{
24			if ($expression instanceof \DOMNode)
25			return $expression;
26
27			@ $items = $contextnode ? $this->query($expression, $contextnode) : $this->query($expression);
			0 ignored issues – show Security Best Practice introduced 2016-03-10 09:26 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
28
29			if ( ! $items)
30			throw new Exception_Xpath('Error in expression: ":expression"', array(':expression' => $expression));
31
32			if ($items->length == 0)
33			throw new Exception_Xpath('No element for selector ":expression"', array(':expression' => $expression));
34
35			return $items->item(0);
36
37			}
38			}
39

OpenBuildings / spiderling

Pull Request — master (#26)

Driver_Simple_Xpath::find() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like