Driver_Phantomjs_Connection::__construct() - Code Metrics - Inspection of "Add support for Symfony 3 components" - OpenBuildings/spiderling - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#20)

by Haralan

created 2016-08-27 08:19 UTC

Driver_Phantomjs_Connection::__construct() A

↳ Parent: Driver_Phantomjs_Connection

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.0625

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	7
ccs	3
cts	4
cp	0.75
rs	9.4285
cc	2
eloc	3
nc	2
nop	1
crap	2.0625

<?php

namespace Openbuildings\Spiderling;

/**
 * Connect to phantomjs service, optionally start one if not present on a new port.
 * Send requests to phantomjs
 *
 * @package    Openbuildings\Spiderling
 * @author     Ivan Kerin
 * @copyright  (c) 2013 OpenBuildings Ltd.
 * @license    http://spdx.org/licenses/BSD-3-Clause
 */
class Driver_Phantomjs_Connection {

	/**
	 * The file storing the pid of the current phantomjs server process
	 * @var string
	 */
	protected $_pid_file;

	/**
	 * The pid of the current phantomjs server process
	 * @var string
	 */
	protected $_pid;

	/**
	 * Ulr of the phantomjs server
	 * @var string
	 */
	protected $_server = 'http://localhost';

	/**
	 * Port of the phantomjs server
	 * @var string
	 */
	protected $_port;

	/**
	 * Getter / Setter of the phantomjs server port.
	 * If none is set it tries to fine an unused port between 4445 and 5000
	 * @param  string $port
	 * @return string|Driver_Phantomjs_Connection
	 */
	public function port($port = NULL)
	{
		if ($port !== NULL)
		{
			$this->_port = $port;
			return $this;
		}

		if ( ! $this->_port)
		{
			$this->_port = Network::ephimeral_port($this->host(), 4445, 5000);

		}

		return $this->_port;
	}

	/**
	 * Getter / Setter of the current phantomjs server url
	 * @param  string $server
	 * @return string|Driver_Phantomjs_Connection
	 */
	public function server($server = NULL)
	{
		if ($server !== NULL)
		{
			$this->_server = $server;
			return $this;
		}
		return $this->_server;
	}

	/**
	 * Get the host of the current phantomjs server (without the protocol part)
	 * @return string
	 */
	public function host()
	{
		return parse_url($this->server(), PHP_URL_HOST);
	}

	/**
	 * Getter, get the current phantomjs server process pid
	 * @return string
	 */
	public function pid()
	{
		return $this->_pid;
	}

	public function __construct($server = NULL)
	{
		if ($server)
		{
			$this->server($server);
		}
	}

	/**
	 * Start a new phantomjs server, optionally provide pid_file and log file.
	 * If you provide a pid_file, it will kill the process currently running on that pid, before starting the new one
	 * If the start is unsuccessfull it will return FALSE
	 * @param  string $pid_file
	 * @param  string $log_file
	 * @return boolean
	 */
	public function start($pid_file = NULL, $log_file = '/dev/null')
	{
		if ($pid_file)
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
		{
			$this->_pid_file = $pid_file;
			if (is_file($this->_pid_file))
			{
				Phantomjs::kill(file_get_contents($pid_file));
				unlink($this->_pid_file);
			}
		}

		$this->_pid = Phantomjs::start('phantom.js', $this->port(), 'phantomjs-connection.js', $log_file);

		if ($this->_pid_file)
		{
			file_put_contents($this->_pid_file, $this->_pid);
		}

		$self = $this;

		return Attempt::make(function() use ($self) {
			return $self->is_running();
		});
	}

	/**
	 * Check if the phantomjs server has been started
	 * @return boolean
	 */
	public function is_started()
	{
		return (bool) $this->_pid;
	}

	/**
	 * Check if the phantomjs server is actually running (the port is taken)
	 * @return boolean
	 */
	public function is_running()
	{
		return ! Network::is_port_open($this->host(), $this->port());

	}

	/**
	 * Gracefully stop the phantomjs server. Return FALSE on failure. Clear the pid_file if set
	 * @return boolean
	 */
	public function stop()
	{
		if ($this->is_started())
		{
			$this->delete('session');
			$this->_pid = NULL;
		}

		if ($this->_pid_file AND is_file($this->_pid_file))
		{
			unlink($this->_pid_file);
		}
		$self = $this;

		return Attempt::make(function() use ($self) {
			return ! $self->is_running();
		});
	}

	/**
	 * Getter - get the current pid_file
	 * @return string
	 */
	public function pid_file()
	{
		return $this->_pid_file;
	}

	/**
	 * Perform a get request on the phantomjs server
	 * @param  string $command
	 * @return mixed
	 */
	public function get($command)
	{
		return $this->call($command);
	}

	/**
	 * Perform a post request on the phantomjs server
	 * @param  string $command
	 * @param  array  $params
	 * @return mixed
	 */
	public function post($command, array $params)
	{
		$options = array();
		$options[CURLOPT_POST] = TRUE;
		$options[CURLOPT_POSTFIELDS] = http_build_query($params);

		return $this->call($command, $options);
	}

	/**
	 * Perform a delete request on the phantomjs server
	 * @param  string $command
	 * @return mixed
	 */
	public function delete($command)
	{
		$options = array();
		$options[CURLOPT_CUSTOMREQUEST] = 'DELETE';

		return $this->call($command, $options);
	}

	/**
	 * Get the full url of a command (including server and port)
	 * @param  string $command
	 * @return string
	 */
	public function command_url($command)
	{
		return rtrim($this->server(), '/').':'.$this->port().'/'.$command;
	}

	/**
	 * Perform a custom request on the phantomjs server, using curl
	 * @param  string $command
	 * @param  array  $options
	 * @return mixed
	 */
	protected function call($command, array $options = array())
	{
		$curl = curl_init();
		$options[CURLOPT_URL] = $this->command_url($command);
		$options[CURLOPT_RETURNTRANSFER] = TRUE;
		$options[CURLOPT_FOLLOWLOCATION] = TRUE;

		curl_setopt_array($curl, $options);

		$raw = '';

		Attempt::make(function() use ($curl, & $raw) {
			$raw = trim(curl_exec($curl));
			return curl_getinfo($curl, CURLINFO_HTTP_CODE) == 200;
		});

		$error = curl_error($curl);
		$code = curl_getinfo($curl, CURLINFO_HTTP_CODE);

		curl_close($curl);

		if ($error)
			throw new Exception_Driver('Curl ":command" throws exception :error', array(':command' => $command, ':error' => $error));

		if ($code != 200)
			throw new Exception_Driver('Unexpected response from the panthomjs for :command: :code', array(':command' => $command, ':code' => $code));

		$result = json_decode($raw, TRUE);

		return $result;
	}
}


1		<?php
2
3		namespace Openbuildings\Spiderling;
4
5		/**
6		* Connect to phantomjs service, optionally start one if not present on a new port.
7		* Send requests to phantomjs
8		*
9		* @package Openbuildings\Spiderling
10		* @author Ivan Kerin
11		* @copyright (c) 2013 OpenBuildings Ltd.
12		* @license http://spdx.org/licenses/BSD-3-Clause
13		*/
14		class Driver_Phantomjs_Connection {
15
16		/**
17		* The file storing the pid of the current phantomjs server process
18		* @var string
19		*/
20		protected $_pid_file;
21
22		/**
23		* The pid of the current phantomjs server process
24		* @var string
25		*/
26		protected $_pid;
27
28		/**
29		* Ulr of the phantomjs server
30		* @var string
31		*/
32		protected $_server = 'http://localhost';
33
34		/**
35		* Port of the phantomjs server
36		* @var string
37		*/
38		protected $_port;
39
40		/**
41		* Getter / Setter of the phantomjs server port.
42		* If none is set it tries to fine an unused port between 4445 and 5000
43		* @param string $port
44		* @return string\|Driver_Phantomjs_Connection
45		*/
46	4	public function port($port = NULL)
47		{
48	3	if ($port !== NULL)
49		{
50	2	$this->_port = $port;
51	2	return $this;
52		}
53
54	4	if ( ! $this->_port)
55		{
56		$this->_port = Network::ephimeral_port($this->host(), 4445, 5000);
		0 ignored issues – show Security Bug introduced 2016-03-10 09:26 UTC by Report Bug Copy Issue Report It seems like `$this->host()` targeting `Openbuildings\Spiderling...omjs_Connection::host()` can also be of type `false`; however, `Openbuildings\Spiderling\Network::ephimeral_port()` does only seem to accept `string`, did you maybe forget to handle an error condition? Loading history... Documentation Bug introduced 2016-03-10 09:26 UTC by Report Bug Copy Issue Report It seems like `\Openbuildings\Spiderlin...is->host(), 4445, 5000)` of type `integer` or `boolean` is incompatible with the declared type `string` of property `$_port`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
57		}
58
59	4	return $this->_port;
60	4	}
61
62		/**
63		* Getter / Setter of the current phantomjs server url
64		* @param string $server
65		* @return string\|Driver_Phantomjs_Connection
66		*/
67	4	public function server($server = NULL)
68		{
69	3	if ($server !== NULL)
70		{
71	1	$this->_server = $server;
72	1	return $this;
73		}
74	4	return $this->_server;
75	4	}
76
77		/**
78		* Get the host of the current phantomjs server (without the protocol part)
79		* @return string
80		*/
81		public function host()
82		{
83		return parse_url($this->server(), PHP_URL_HOST);
84		}
85
86		/**
87		* Getter, get the current phantomjs server process pid
88		* @return string
89		*/
90	1	public function pid()
91		{
92	1	return $this->_pid;
93		}
94
95	2	public function __construct($server = NULL)
96		{
97	2	if ($server)
98		{
99		$this->server($server);
100		}
101	2	}
102
103		/**
104		* Start a new phantomjs server, optionally provide pid_file and log file.
105		* If you provide a pid_file, it will kill the process currently running on that pid, before starting the new one
106		* If the start is unsuccessfull it will return FALSE
107		* @param string $pid_file
108		* @param string $log_file
109		* @return boolean
110		*/
111	2	public function start($pid_file = NULL, $log_file = '/dev/null')
112		{
113	2	if ($pid_file)
		0 ignored issues – show Bug Best Practice introduced 2016-03-10 09:26 UTC by Report Bug Copy Issue Report The expression `$pid_file` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
114		{
115	1	$this->_pid_file = $pid_file;
116		if (is_file($this->_pid_file))
117		{
118		Phantomjs::kill(file_get_contents($pid_file));
119		unlink($this->_pid_file);
120		}
121		}
122
123		$this->_pid = Phantomjs::start('phantom.js', $this->port(), 'phantomjs-connection.js', $log_file);
124
125	2	if ($this->_pid_file)
126		{
127		file_put_contents($this->_pid_file, $this->_pid);
128		}
129
130	2	$self = $this;
131
132		return Attempt::make(function() use ($self) {
133		return $self->is_running();
134		});
135	1	}
136
137		/**
138		* Check if the phantomjs server has been started
139		* @return boolean
140		*/
141	1	public function is_started()
142		{
143	1	return (bool) $this->_pid;
144		}
145
146		/**
147		* Check if the phantomjs server is actually running (the port is taken)
148		* @return boolean
149		*/
150		public function is_running()
151		{
152		return ! Network::is_port_open($this->host(), $this->port());
		0 ignored issues – show Security Bug introduced 2016-03-10 09:26 UTC by Report Bug Copy Issue Report It seems like `$this->host()` targeting `Openbuildings\Spiderling...omjs_Connection::host()` can also be of type `false`; however, `Openbuildings\Spiderling\Network::is_port_open()` does only seem to accept `string`, did you maybe forget to handle an error condition? Loading history...
153		}
154
155		/**
156		* Gracefully stop the phantomjs server. Return FALSE on failure. Clear the pid_file if set
157		* @return boolean
158		*/
159	2	public function stop()
160		{
161		if ($this->is_started())
162		{
163		$this->delete('session');
164	2	$this->_pid = NULL;
165		}
166
167	1	if ($this->_pid_file AND is_file($this->_pid_file))
168		{
169		unlink($this->_pid_file);
170		}
171	2	$self = $this;
172
173		return Attempt::make(function() use ($self) {
174		return ! $self->is_running();
175		});
176		}
177
178		/**
179		* Getter - get the current pid_file
180		* @return string
181		*/
182		public function pid_file()
183		{
184		return $this->_pid_file;
185		}
186
187		/**
188		* Perform a get request on the phantomjs server
189		* @param string $command
190		* @return mixed
191		*/
192		public function get($command)
193		{
194		return $this->call($command);
195		}
196
197		/**
198		* Perform a post request on the phantomjs server
199		* @param string $command
200		* @param array $params
201		* @return mixed
202		*/
203	2	public function post($command, array $params)
204		{
205	2	$options = array();
206	2	$options[CURLOPT_POST] = TRUE;
207		$options[CURLOPT_POSTFIELDS] = http_build_query($params);
208
209		return $this->call($command, $options);
210	2	}
211
212		/**
213		* Perform a delete request on the phantomjs server
214		* @param string $command
215		* @return mixed
216		*/
217	3	public function delete($command)
218		{
219	3	$options = array();
220	3	$options[CURLOPT_CUSTOMREQUEST] = 'DELETE';
221
222		return $this->call($command, $options);
223		}
224
225		/**
226		* Get the full url of a command (including server and port)
227		* @param string $command
228		* @return string
229		*/
230		public function command_url($command)
231		{
232		return rtrim($this->server(), '/').':'.$this->port().'/'.$command;
233		}
234
235		/**
236		* Perform a custom request on the phantomjs server, using curl
237		* @param string $command
238		* @param array $options
239		* @return mixed
240		*/
241	5	protected function call($command, array $options = array())
242		{
243		$curl = curl_init();
244		$options[CURLOPT_URL] = $this->command_url($command);
245	5	$options[CURLOPT_RETURNTRANSFER] = TRUE;
246	5	$options[CURLOPT_FOLLOWLOCATION] = TRUE;
247
248		curl_setopt_array($curl, $options);
249
250	5	$raw = '';
251
252		Attempt::make(function() use ($curl, & $raw) {
253		$raw = trim(curl_exec($curl));
254		return curl_getinfo($curl, CURLINFO_HTTP_CODE) == 200;
255		});
256
257		$error = curl_error($curl);
258		$code = curl_getinfo($curl, CURLINFO_HTTP_CODE);
259
260		curl_close($curl);
261
262	5	if ($error)
263		throw new Exception_Driver('Curl ":command" throws exception :error', array(':command' => $command, ':error' => $error));
264
265	5	if ($code != 200)
266		throw new Exception_Driver('Unexpected response from the panthomjs for :command: :code', array(':command' => $command, ':code' => $code));
267
268		$result = json_decode($raw, TRUE);
269
270	5	return $result;
271	5	}
272		}
273

OpenBuildings / spiderling

Pull Request — master (#20)

Driver_Phantomjs_Connection::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like