Openbuildings\Spiderling\Driver_Simple_Xpath

Complexity

Total Complexity

5

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

88.89%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	find()	0	16	5

<?php

namespace Openbuildings\Spiderling;

/**
 * Xpath extension for simple driver
 *
 * @package    Openbuildings\Spiderling
 * @author     Ivan Kerin
 * @copyright  (c) 2013 OpenBuildings Ltd.
 * @license    http://spdx.org/licenses/BSD-3-Clause
 */
class Driver_Simple_Xpath extends \DOMXpath
{
	/**
	 * Find a DOMElement wit ha given xpath expression, optionally provide parent DOMNode to use as context.
	 * @param  string $expression
	 * @param  DOMNode $contextnode
	 * @return DOMNode
	 * @throws Exception_Xpath If no elements were found
	 */
	public function find($expression, $contextnode = NULL)
	{
		if ($expression instanceof \DOMNode)
			return $expression;

		@ $items = $contextnode ? $this->query($expression, $contextnode) : $this->query($expression);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

		if ( ! $items)
			throw new Exception_Xpath('Error in expression: ":expression"', array(':expression' => $expression));

		if ($items->length == 0)
			throw new Exception_Xpath('No element for selector ":expression"', array(':expression' => $expression));

		return $items->item(0);

	}
}