LocatorConstraint::failureDescription() - Code Metrics - Inspection of "Update PHPUnit @group annotations in tests" - OpenBuildings/phpunit-spiderling - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — update ( 3c072c...67888e )

by Haralan

created 2017-03-22 00:37 UTC

LocatorConstraint::failureDescription() B

↳ Parent: LocatorConstraint

Complexity

Conditions	4
Paths	5

Size

Total Lines	22
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	8.9197
c	0
b	0
f	0
cc	4
eloc	10
nc	5
nop	1

<?php

namespace Openbuildings\PHPUnitSpiderling\Constraint;

use Openbuildings\Spiderling\Exception_Notfound;

class LocatorConstraint extends \PHPUnit\Framework\Constraint\Constraint {

	protected $_type;
	protected $_selector;
	protected $_filters;

	function __construct($type, $selector, array $filters = array())

	{
		$this->_type = $type;
		$this->_selector = $selector;
		$this->_filters = $filters;
	}

	protected function matches($other)
	{
		try
		{
			$other->find(array($this->_type, $this->_selector, $this->_filters));
			return TRUE;
		}
		catch (Exception_Notfound $excption)
		{
			return FALSE;
		}
	}

	public function failureDescription($other)
	{
		if ($other->is_root())
		{
			$node_string = 'HTML page';
		}
		else
		{
			$node_string = $other->tag_name();

			if ($id = $other->attribute('id'))
			{
				$node_string .= '#'.$id;
			}

			if ($class = $other->attribute('class'))
			{
				$node_string .= '.'.join('.', explode(' ', $class));
			}
		}
		return "$node_string ".$this->toString();
	}

	/**
	 * Returns a string representation of the constraint.
	 *
	 * @return string
	 */
	public function toString()
	{
		return "has '{$this->_type}' selector '{$this->_selector}', filter ".json_encode($this->_filters);
	}
}


1			<?php
2
3			namespace Openbuildings\PHPUnitSpiderling\Constraint;
4
5			use Openbuildings\Spiderling\Exception_Notfound;
6
7			class LocatorConstraint extends \PHPUnit\Framework\Constraint\Constraint {
8
9			protected $_type;
10			protected $_selector;
11			protected $_filters;
12
13			function __construct($type, $selector, array $filters = array())
			0 ignored issues – show Best Practice introduced 2017-03-22 00:43 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
14			{
15			$this->_type = $type;
16			$this->_selector = $selector;
17			$this->_filters = $filters;
18			}
19
20			protected function matches($other)
21			{
22			try
23			{
24			$other->find(array($this->_type, $this->_selector, $this->_filters));
25			return TRUE;
26			}
27			catch (Exception_Notfound $excption)
28			{
29			return FALSE;
30			}
31			}
32
33			public function failureDescription($other)
34			{
35			if ($other->is_root())
36			{
37			$node_string = 'HTML page';
38			}
39			else
40			{
41			$node_string = $other->tag_name();
42
43			if ($id = $other->attribute('id'))
44			{
45			$node_string .= '#'.$id;
46			}
47
48			if ($class = $other->attribute('class'))
49			{
50			$node_string .= '.'.join('.', explode(' ', $class));
51			}
52			}
53			return "$node_string ".$this->toString();
54			}
55
56			/**
57			* Returns a string representation of the constraint.
58			*
59			* @return string
60			*/
61			public function toString()
62			{
63			return "has '{$this->_type}' selector '{$this->_selector}', filter ".json_encode($this->_filters);
64			}
65			}
66

OpenBuildings / phpunit-spiderling

Push — update ( 3c072c...67888e )

LocatorConstraint::failureDescription() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like