Issues in Server.php (master) - Issues in master - OpenBuildings/jam - Measure and Improve Code Quality continuously with Scrutinizer

Issues (279)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

classes/Kohana/Upload/Server.php (2 issues)

Labels

Documentation 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Abstract Class for manupulating a server
 *
 * @package    Jam
 * @author     Ivan Kerin
 * @copyright  (c) 2011-2012 Despark Ltd.
 * @license    http://creativecommons.org/licenses/by-sa/3.0/legalcode
 */
abstract class Kohana_Upload_Server
{
	/**
	 * @var  string  default instance name
	 */
	public static $default = 'default';

	/**
	 * @var  array  Database instances
	 */
	public static $instances = array();

	/**
	 * Get a singleton Upload_Server instance. If configuration is not specified,
	 * it will be loaded from the Upload_Server configuration file using the same
	 * group as the name.
	 *
	 *     // Load the default server
	 *     $server = Upload_Server::instance();
	 *
	 *     // Create a custom configured instance
	 *     $server = Upload_Server::instance('custom', $config);
	 *
	 * @param   string   instance name
	 * @param   array    configuration parameters
	 * @return  Database
	 */
	public static function instance($name = NULL, array $config = NULL)
	{
		if ($name === NULL)
		{
			// Use the default instance name
			$name = Upload_Server::$default;
		}

		if ( ! isset(Upload_Server::$instances[$name]))
		{
			if ($config === NULL)
			{
				// Load the configuration for this database
				$config = Arr::get(Kohana::$config->load('jam.upload.servers'), $name);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			}

			$validation = Validation::factory($config)
				->rule('type', 'not_empty')
				->rule('params', 'not_empty')
				->rule('params', 'is_array');

			if ( ! $validation->check())
				throw new Kohana_Exception('Upload server config had errors: :errors',
					array(':errors' => join(', ', $validation->errors('upload_server'))));

			$server = 'server_'.$validation['type'];
			Upload_Server::$instances[$name] = Upload_Server::$server($validation['params']);
		}

		return Upload_Server::$instances[$name];
	}

	public static function server_local(array $params = array())
	{
		$validation = Validation::factory($params)
			->rule('path', 'not_empty')
			->rule('path', 'is_dir')
			->rule('web', 'not_empty')
			->rule('url_type', 'in_array', array(':value', array(Flex\Storage\Server::URL_HTTP, Flex\Storage\Server::URL_SSL, Flex\Storage\Server::URL_STREAMING)));

		if ( ! $validation->check())
			throw new Kohana_Exception('Upload server local params had errors: :errors',
				array(':errors' => join(', ', Arr::flatten($validation->errors()))));

		$server = new Flex\Storage\Server_Local($validation['path'], $validation['web']);

		if (isset($validation['url_type']))
		{
			$server->url_type($validation['url_type']);
		}

		return $server;
	}

	public static function server_rackspace(array $params = array())
	{
		$validation = Validation::factory($params)
			->rule('username', 'not_empty')
			->rule('api_key', 'not_empty')
			->rule('container', 'not_empty')
			->rule('url_type', 'in_array', array(':value', array(Flex\Storage\Server::URL_HTTP, Flex\Storage\Server::URL_SSL, Flex\Storage\Server::URL_STREAMING)))
			->rule('cdn_uri', 'url')
			->rule('cdn_ssl', 'url')
			->rule('cdn_streaming', 'url');

		if ( ! $validation->check())
			throw new Kohana_Exception('Upload server local params had errors: :errors',
				array(':errors' => join(', ', $validation->errors('upload_server'))));

		$server = new Flex\Storage\Server_Rackspace($validation['container'], $validation['region'], array(
			'username' => $validation['username'],
			'apiKey' => $validation['api_key'],
		));

		foreach (array('cdn_uri', 'cdn_ssl', 'cdn_streaming', 'url_type') as $param)
		{
			if (isset($validation[$param]))
			{
				$server->$param($validation[$param]);
			}
		}

		return $server;
	}

	public static function server_local_fallback(array $params = array())
	{
		$validation = Validation::factory($params)
			->rule('path', 'not_empty')
			->rule('fallback', 'not_empty')
			->rule('path', 'is_dir')
			->rule('url_type', 'in_array', array(':value', array(Flex\Storage\Server::URL_HTTP, Flex\Storage\Server::URL_SSL, Flex\Storage\Server::URL_STREAMING)))
			->rule('web', 'not_empty');

		if ( ! $validation->check())
			throw new Kohana_Exception('Upload server local params had errors: :errors',
				array(':errors' => join(', ', $validation->errors('upload_server'))));

		$server = new Flex\Storage\Server_Local_Fallback($validation['path'], $validation['web']);
		$server->fallback(Upload_Server::instance($validation['fallback']));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		if (isset($validation['url_type']))
		{
			$server->url_type($validation['url_type']);
		}

		return $server;
	}

	public static function server_local_placeholdit(array $params = array())
	{
		$validation = Validation::factory($params)
			->rule('path', 'not_empty')
			->rule('path', 'is_dir')
			->rule('placeholder', 'url')
			->rule('url_type', 'in_array', array(':value', array(Flex\Storage\Server::URL_HTTP, Flex\Storage\Server::URL_SSL, Flex\Storage\Server::URL_STREAMING)))
			->rule('web', 'not_empty');

		if ( ! $validation->check())
			throw new Kohana_Exception('Upload server local params had errors: :errors',
				array(':errors' => join(', ', $validation->errors('upload_server'))));

		$server = new Flex\Storage\Server_Local_Placeholdit($validation['path'], $validation['web']);

		if (isset($validation['placeholder'])) {
			$server->placeholder($validation['placeholder']);
		}

		if (isset($validation['url_type']))
		{
			$server->url_type($validation['url_type']);
		}

		return $server;
	}
}


1		<?php
2		/**
3		* Abstract Class for manupulating a server
4		*
5		* @package Jam
6		* @author Ivan Kerin
7		* @copyright (c) 2011-2012 Despark Ltd.
8		* @license http://creativecommons.org/licenses/by-sa/3.0/legalcode
9		*/
10		abstract class Kohana_Upload_Server
11		{
12		/**
13		* @var string default instance name
14		*/
15		public static $default = 'default';
16
17		/**
18		* @var array Database instances
19		*/
20		public static $instances = array();
21
22		/**
23		* Get a singleton Upload_Server instance. If configuration is not specified,
24		* it will be loaded from the Upload_Server configuration file using the same
25		* group as the name.
26		*
27		* // Load the default server
28		* $server = Upload_Server::instance();
29		*
30		* // Create a custom configured instance
31		* $server = Upload_Server::instance('custom', $config);
32		*
33		* @param string instance name
34		* @param array configuration parameters
35		* @return Database
36		*/
37	4	public static function instance($name = NULL, array $config = NULL)
38		{
39	4	if ($name === NULL)
40		{
41		// Use the default instance name
42		$name = Upload_Server::$default;
43		}
44
45	4	if ( ! isset(Upload_Server::$instances[$name]))
46		{
47	2	if ($config === NULL)
48		{
49		// Load the configuration for this database
50	2	$config = Arr::get(Kohana::$config->load('jam.upload.servers'), $name);
		0 ignored issues – show Documentation introduced 2015-11-24 23:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\Kohana::$config->load('jam.upload.servers')` is of type `object<Kohana_Config_Group>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
51		}
52
53	2	$validation = Validation::factory($config)
54	2	->rule('type', 'not_empty')
55	2	->rule('params', 'not_empty')
56	2	->rule('params', 'is_array');
57
58	2	if ( ! $validation->check())
59		throw new Kohana_Exception('Upload server config had errors: :errors',
60		array(':errors' => join(', ', $validation->errors('upload_server'))));
61
62	2	$server = 'server_'.$validation['type'];
63	2	Upload_Server::$instances[$name] = Upload_Server::$server($validation['params']);
64		}
65
66	4	return Upload_Server::$instances[$name];
67		}
68
69	2	public static function server_local(array $params = array())
70		{
71	2	$validation = Validation::factory($params)
72	2	->rule('path', 'not_empty')
73	2	->rule('path', 'is_dir')
74	2	->rule('web', 'not_empty')
75	2	->rule('url_type', 'in_array', array(':value', array(Flex\Storage\Server::URL_HTTP, Flex\Storage\Server::URL_SSL, Flex\Storage\Server::URL_STREAMING)));
76
77	2	if ( ! $validation->check())
78		throw new Kohana_Exception('Upload server local params had errors: :errors',
79		array(':errors' => join(', ', Arr::flatten($validation->errors()))));
80
81	2	$server = new Flex\Storage\Server_Local($validation['path'], $validation['web']);
82
83	2	if (isset($validation['url_type']))
84		{
85		$server->url_type($validation['url_type']);
86		}
87
88	2	return $server;
89		}
90
91		public static function server_rackspace(array $params = array())
92		{
93		$validation = Validation::factory($params)
94		->rule('username', 'not_empty')
95		->rule('api_key', 'not_empty')
96		->rule('container', 'not_empty')
97		->rule('url_type', 'in_array', array(':value', array(Flex\Storage\Server::URL_HTTP, Flex\Storage\Server::URL_SSL, Flex\Storage\Server::URL_STREAMING)))
98		->rule('cdn_uri', 'url')
99		->rule('cdn_ssl', 'url')
100		->rule('cdn_streaming', 'url');
101
102		if ( ! $validation->check())
103		throw new Kohana_Exception('Upload server local params had errors: :errors',
104		array(':errors' => join(', ', $validation->errors('upload_server'))));
105
106		$server = new Flex\Storage\Server_Rackspace($validation['container'], $validation['region'], array(
107		'username' => $validation['username'],
108		'apiKey' => $validation['api_key'],
109		));
110
111		foreach (array('cdn_uri', 'cdn_ssl', 'cdn_streaming', 'url_type') as $param)
112		{
113		if (isset($validation[$param]))
114		{
115		$server->$param($validation[$param]);
116		}
117		}
118
119		return $server;
120		}
121
122		public static function server_local_fallback(array $params = array())
123		{
124		$validation = Validation::factory($params)
125		->rule('path', 'not_empty')
126		->rule('fallback', 'not_empty')
127		->rule('path', 'is_dir')
128		->rule('url_type', 'in_array', array(':value', array(Flex\Storage\Server::URL_HTTP, Flex\Storage\Server::URL_SSL, Flex\Storage\Server::URL_STREAMING)))
129		->rule('web', 'not_empty');
130
131		if ( ! $validation->check())
132		throw new Kohana_Exception('Upload server local params had errors: :errors',
133		array(':errors' => join(', ', $validation->errors('upload_server'))));
134
135		$server = new Flex\Storage\Server_Local_Fallback($validation['path'], $validation['web']);
136		$server->fallback(Upload_Server::instance($validation['fallback']));
		0 ignored issues – show Documentation introduced 2015-11-24 23:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\Upload_Server::instance($validation['fallback'])` is of type `object<Database>`, but the function expects a `null\|object<Flex\Storage\Server>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
137
138		if (isset($validation['url_type']))
139		{
140		$server->url_type($validation['url_type']);
141		}
142
143		return $server;
144		}
145
146		public static function server_local_placeholdit(array $params = array())
147		{
148		$validation = Validation::factory($params)
149		->rule('path', 'not_empty')
150		->rule('path', 'is_dir')
151		->rule('placeholder', 'url')
152		->rule('url_type', 'in_array', array(':value', array(Flex\Storage\Server::URL_HTTP, Flex\Storage\Server::URL_SSL, Flex\Storage\Server::URL_STREAMING)))
153		->rule('web', 'not_empty');
154
155		if ( ! $validation->check())
156		throw new Kohana_Exception('Upload server local params had errors: :errors',
157		array(':errors' => join(', ', $validation->errors('upload_server'))));
158
159		$server = new Flex\Storage\Server_Local_Placeholdit($validation['path'], $validation['web']);
160
161		if (isset($validation['placeholder'])) {
162		$server->placeholder($validation['placeholder']);
163		}
164
165		if (isset($validation['url_type']))
166		{
167		$server->url_type($validation['url_type']);
168		}
169
170		return $server;
171		}
172		}
173

OpenBuildings / jam

Issues (279)

Security Analysis no request data

classes/Kohana/Upload/Server.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like