Kohana_Jam_Array_Model - Code Metrics - Inspection of "Prevent side effects from count_with_subquery" - OpenBuildings/jam - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — count-subquery-clone ( d5815f...6cc328 )

by Haralan

created 2016-06-14 10:22 UTC

Kohana_Jam_Array_Model D

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	460
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

94.12%

Importance

Changes	3
Bugs	1	Features	1

Metric	Value
wmc	85
c	3
b	1
f	1
lcom	1
cbo	8
dl	0
loc	460
ccs	208
cts	221
cp	0.9412
rs	4.8717

31 Methods

Rating	Name	Size	Complexity
A	_find_item()	4	1
D	_load_item()	44	10
B	_id()	14	7
A	build()	11	2
A	create()	4	1
B	check_changed()	15	5
A	clear()	8	1
A	clear_changed()	7	1
A	factory()	4	1
A	convert_collection_to_array()	16	4
A	model()	9	2
A	meta()	7	2
A	collection()	10	2
B	_load_content()	24	5
A	reload()	6	1
B	search()	22	5
A	as_array()	13	4
A	ids()	6	2
A	load_fields()	5	1
A	original()	4	1
A	original_ids()	6	2
A	has()	4	1
A	set()	9	2
A	add()	11	2
A	remove()	14	3
B	save_changed()	13	5
A	__toString()	7	2
A	__call()	7	2
B	changed()	15	6
A	serialize()	15	1
A	unserialize()	12	1

How to fix Complexity

<?php defined('SYSPATH') OR die('No direct script access.');

/**
 * Represents an array of models. Lazy loaded from a Jam_Query_Builder_Collection, and can be changed, checked and saved at once.
 *
 * @package    Jam
 * @category   Associations
 * @author     Ivan Kerin
 * @copyright  (c) 2011-2012 Despark Ltd.
 * @license    http://www.opensource.org/licenses/isc-license.txt
 */
abstract class Kohana_Jam_Array_Model extends Jam_Array {

	public static function factory()
	{
		return new Jam_Array_Model();
	}

	/**
	 * Convert a collection to an array, keep an array or make a Jam_Model to an array(Jam_Model)
	 * @param  mixed $collection
	 * @return array
	 */
	public static function convert_collection_to_array($collection)
	{
		if ($collection instanceof Jam_Query_Builder_Collection OR $collection instanceof Jam_Array_Model)
		{
			$array = $collection->as_array();
		}
		elseif ( ! is_array($collection))
		{
			$array = array($collection);
		}
		else
		{
			$array = $collection;
		}
		return array_values(array_filter($array));
	}

	/**
	 * A collection used to load the content
	 * @var Jam_Query_Builder_Collection
	 */
	protected $_collection;

	/**
	 * The name of the models in this iterator
	 * @var string
	 */
	protected $_model;

	/**
	 * The original content, loaded from the database
	 * @var array
	 */
	protected $_original;

	/**
	 * This is set if the whole collection has been replaced.
	 * @var boolean
	 */
	protected $_replace = FALSE;

	/**
	 * Getter / Setter of the model name
	 * @param  string $model
	 * @return string
	 */
	public function model($model = NULL)
	{
		if ($model !== NULL)
		{
			$this->_model = $model;
			return $this;
		}
		return $this->_model;
	}

	/**
	 * Getter of the meta object for this iterator (based on $_model)
	 * @return Jam_Model
	 * @throws Kohana_Exception If $_model not present
	 */
	public function meta()
	{
		if ( ! $this->model())
			throw new Kohana_Exception('Model not set');

		return Jam::meta($this->model());

	}

	/**
	 * Getter / Setter of the collection, used to lazy load the data for this iterator
	 * @param  Jam_Query_Builder_Collection $collection
	 * @return Jam_Query_Builder_Collection
	 */
	public function collection(Jam_Query_Builder_Collection $collection = NULL)
	{
		if ($collection !== NULL)
		{
			$this->_collection = $collection;
			return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
		}

		return $this->_collection;
	}

	/**
	 * Load the content from the database, using $_collection.
	 * If some items have been added to the iterator before it has been loaded, merge the results
	 * @throws Kohana_Exception If the $_collection has not been loaded
	 */
	protected function _load_content()
	{
		if ($this->_original === NULL)
		{
			if ( ! $this->collection())
				throw new Kohana_Exception('Cannot load content because collection not loaded for Jam_Array(:model)', array(':model' => $this->model()));

			$collection = clone $this->collection();

			$this->_original = $collection->result()->as_array();

			if ( ! $this->_replace)
			{
				if ($this->_content !== NULL)
				{
					$this->_content = array_merge($this->_content, $this->_original);
				}
				else
				{
					$this->_content = $this->_original;
				}
			}
		}
	}

	public function reload()
	{
		$this->_original = NULL;

		$this->_replace = FALSE;
		return parent::reload();
	}

	/**
	 * Load an item from the database, based on a unique key
	 * @param  string $key
	 * @return Jam_Model
	 */
	protected function _find_item($key)
	{
		return Jam::find($this->model(), $key);

	}

	/**
	 * Convert an item from the $_content to a Jam_Model
	 * @param  mixed $value
	 * @param  boolean $is_changed
	 * @param  int $offset
	 * @return Jam_Model
	 */
	protected function _load_item($value, $is_changed, $offset)
	{
		if ($value instanceof Jam_Model OR ! $value)
		{
			$item = $value;
		}
		elseif ( ! is_array($value))
		{
			$item = $this->_find_item($value);
		}
		elseif (is_array($value) AND $is_changed)
		{
			$key = $this->meta()->primary_key();
			if (isset($value[$key]) AND $value[$key])
			{
				$item_key = is_array($value[$key]) ? reset($value[$key]) : $value[$key];

				$model = $this->_find_item($item_key);
				if ( ! $model)
				{
					$model = clone Jam::build_template($this->model(), $value);
				}
				else
				{
					unset($value[$key]);
				}
			}
			else
			{
				$model = clone Jam::build_template($this->model(), $value);
			}

			$item = $model->set($value);
		}
		else
		{
			$item = clone Jam::build_template($this->model(), $value);
			$item = $item->load_fields($value);
		}

		$this->_content[$offset] = $item;

		return $item;
	}

	/**
	 * Find out the primary_key of an item of the $_content
	 * @param  mixed $value
	 * @return int
	 */
	protected function _id($value)
	{
		if ($value instanceof Jam_Model)
			return $value->id();

		if (is_numeric($value))
			return (int) $value;

		if (is_string($value) AND $item = $this->_find_item($value))
			return $item->id();

		if (is_array($value) AND isset($value[$this->meta()->primary_key()]))
			return (int) $value[$this->meta()->primary_key()];
	}

	public function search($item)
	{
		$search_id = $this->_id($item);

		if ( ! $search_id)
			return NULL;

		$this->_load_content();

		if ($this->_content)

		{
			foreach ($this->_content as $offset => $current)
			{
				if ($this->_id($current) === $search_id)
				{
					return (int) $offset;
				}
			}
		}

		return NULL;
	}

	public function as_array($key = NULL, $value = NULL)
	{
		$results = array();
		$key = Jam_Query_Builder::resolve_meta_attribute($key, $this->meta());
		$value = Jam_Query_Builder::resolve_meta_attribute($value, $this->meta());

		foreach ($this as $i => $item)
		{
			$results[$key ? $item->$key : $i] = $value ? $item->$value : $item;
		}

		return $results;
	}

	public function ids()
	{
		$this->_load_content();

		return $this->_content ? array_filter(array_map(array($this, '_id'), $this->_content)) : array();
	}

	public function load_fields(array $data)
	{
		$this->_content = $this->_original = $data;
		return $this;
	}

	public function original()
	{
		return $this->_original;
	}

	public function original_ids()
	{
		$this->_load_content();

		return $this->_original ? array_filter(array_map(array($this, '_id'), $this->_original)) : array();
	}

	public function has($item)
	{
		return $this->search($item) !== NULL;
	}

	public function set($items)
	{
		$this->_content = Jam_Array_Model::convert_collection_to_array($items);
		$this->_changed = count($this->_content) ? array_fill(0, count($this->_content), TRUE) : array();
		$this->_replace = TRUE;
		$this->_removed = TRUE;

		return $this;
	}

	public function add($items)
	{
		$items = Jam_Array_Model::convert_collection_to_array($items);

		foreach ($items as $item)
		{
			$this->offsetSet($this->search($item), $item);
		}

		return $this;
	}

	public function remove($items)
	{
		$items = Jam_Array_Model::convert_collection_to_array($items);

		foreach ($items as $item)
		{
			if (($offset = $this->search($item)) !== NULL)
			{
				$this->offsetUnset($offset);
			}
		}

		return $this;
	}

	/**
	 * Build a new Jam Model, add it to the collection and return the newly built model
	 * @param  array $values set values on the new model
	 * @return Jam_Model
	 */
	public function build(array $values = NULL)
	{
		$item = clone Jam::build_template($this->model(), $values);
		if ($values)
		{
			$item->set($values);
		}
		$this->add($item);

		return $item;
	}

	/**
	 * The same as build but saves the model in the database
	 * @param  array $values
	 * @return Jam_Model
	 */
	public function create(array $values = NULL)
	{
		return $this->build($values)->save();
	}

	public function check_changed()
	{
		$check = TRUE;

		foreach ($this->_changed as $offset => $is_changed)
		{
			$item = $this->offsetGet($offset);
			if ($is_changed AND $item AND ! $item->check())
			{
				$check = FALSE;
			}
		}

		return $check;
	}

	public function save_changed()
	{
		foreach ($this->_changed as $offset => $is_changed)
		{
			$item = $this->offsetGet($offset);
			if ($is_changed AND $item AND ! $item->is_saving())
			{
				$item->save();
			}
		}

		return $this;
	}

	public function clear()
	{
		$this->_changed =
		$this->_original =
		$this->_content = array();

		return $this;
	}

	public function clear_changed()
	{
		$this->_changed = array();
		$this->_original = $this->_content;

		return $this;
	}

	public function __toString()
	{
		if ( ! $this->collection())
			return 'Jam_Array ('.$this->model().')[NOT LOADED COLLECTION]';

		return $this->collection()->__toString();
	}

	public function __call($method, $args)
	{
		if ( ! $this->collection())
			throw new Kohana_Exception('Cannot call method :method on collection because collection not loaded for Jam_Array(:model)', array(':method' => $method, ':model' => $this->model()));

		return call_user_func_array(array(clone $this->collection(), $method), $args);
	}

	/**
	 * Getter for the changed array - check if any or a particular item has been changed
	 * @param  int $offset
	 * @return bool
	 */
	public function changed($offset = NULL)
	{
		if ($this->_content)

		{
			foreach ($this->_content as $key => $value)
			{
				if ( ! isset($this->_changed[$key]) AND $value instanceof Jam_Model AND $value->changed())
				{
					$this->_changed[$key] = TRUE;
				}
			}
		}

		return parent::changed($offset);
	}

	public function serialize()
	{
		$this->_load_content();


		return serialize(array(
			'original' => $this->_original,
			'model'    => $this->_model,
			'replace'  => $this->_replace,
			'changed'  => $this->_changed,
			'content'  => $this->_content,
			'removed'  => $this->_removed,
			'current'  => $this->_current,
		));
	}

	public function unserialize($data)
	{
		$data = unserialize($data);

		$this->_original = $data['original'];
		$this->_model    = $data['model'];
		$this->_replace  = $data['replace'];
		$this->_changed  = $data['changed'];
		$this->_content  = $data['content'];
		$this->_removed  = $data['removed'];
		$this->_current  = $data['current'];
	}
}


1		<?php defined('SYSPATH') OR die('No direct script access.');
2
3		/**
4		* Represents an array of models. Lazy loaded from a Jam_Query_Builder_Collection, and can be changed, checked and saved at once.
5		*
6		* @package Jam
7		* @category Associations
8		* @author Ivan Kerin
9		* @copyright (c) 2011-2012 Despark Ltd.
10		* @license http://www.opensource.org/licenses/isc-license.txt
11		*/
12		abstract class Kohana_Jam_Array_Model extends Jam_Array {
13
14		public static function factory()
15		{
16		return new Jam_Array_Model();
17		}
18
19		/**
20		* Convert a collection to an array, keep an array or make a Jam_Model to an array(Jam_Model)
21		* @param mixed $collection
22		* @return array
23		*/
24	21	public static function convert_collection_to_array($collection)
25		{
26	21	if ($collection instanceof Jam_Query_Builder_Collection OR $collection instanceof Jam_Array_Model)
27	21	{
28	6	$array = $collection->as_array();
29	6	}
30	20	elseif ( ! is_array($collection))
31		{
32	13	$array = array($collection);
33	13	}
34		else
35		{
36	10	$array = $collection;
37		}
38	21	return array_values(array_filter($array));
39		}
40
41		/**
42		* A collection used to load the content
43		* @var Jam_Query_Builder_Collection
44		*/
45		protected $_collection;
46
47		/**
48		* The name of the models in this iterator
49		* @var string
50		*/
51		protected $_model;
52
53		/**
54		* The original content, loaded from the database
55		* @var array
56		*/
57		protected $_original;
58
59		/**
60		* This is set if the whole collection has been replaced.
61		* @var boolean
62		*/
63		protected $_replace = FALSE;
64
65		/**
66		* Getter / Setter of the model name
67		* @param string $model
68		* @return string
69		*/
70	637	public function model($model = NULL)
71		{
72	637	if ($model !== NULL)
73	637	{
74	637	$this->_model = $model;
75	637	return $this;
76		}
77	25	return $this->_model;
78		}
79
80		/**
81		* Getter of the meta object for this iterator (based on $_model)
82		* @return Jam_Model
83		* @throws Kohana_Exception If $_model not present
84		*/
85	19	public function meta()
86		{
87	19	if ( ! $this->model())
88	19	throw new Kohana_Exception('Model not set');
89
90	19	return Jam::meta($this->model());
		0 ignored issues – show Bug introduced 2015-11-24 23:50 UTC by Report Bug Copy Issue Report It seems like `$this->model()` targeting `Kohana_Jam_Array_Model::model()` can also be of type `this<Kohana_Jam_Array_Model>`; however, `Kohana_Jam::meta()` does only seem to accept `string\|object<Jam_Model>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
91		}
92
93		/**
94		* Getter / Setter of the collection, used to lazy load the data for this iterator
95		* @param Jam_Query_Builder_Collection $collection
96		* @return Jam_Query_Builder_Collection
97		*/
98	29	public function collection(Jam_Query_Builder_Collection $collection = NULL)
99		{
100	18	if ($collection !== NULL)
101	18	{
102	18	$this->_collection = $collection;
103	18	return $this;
		0 ignored issues – show Bug Best Practice introduced 2015-11-24 23:50 UTC by Report Bug Copy Issue Report The return type of `return $this;` (`Kohana_Jam_Array_Model`) is incompatible with the return type documented by `Kohana_Jam_Array_Model::collection` of type `Jam_Query_Builder_Collection`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
104		}
105
106	29	return $this->_collection;
107		}
108
109		/**
110		* Load the content from the database, using $_collection.
111		* If some items have been added to the iterator before it has been loaded, merge the results
112		* @throws Kohana_Exception If the $_collection has not been loaded
113		*/
114	28	protected function _load_content()
115		{
116	28	if ($this->_original === NULL)
117	28	{
118	28	if ( ! $this->collection())
119	28	throw new Kohana_Exception('Cannot load content because collection not loaded for Jam_Array(:model)', array(':model' => $this->model()));
120
121	28	$collection = clone $this->collection();
122
123	28	$this->_original = $collection->result()->as_array();
124
125	28	if ( ! $this->_replace)
126	28	{
127	23	if ($this->_content !== NULL)
128	23	{
129	1	$this->_content = array_merge($this->_content, $this->_original);
130	1	}
131		else
132		{
133	22	$this->_content = $this->_original;
134		}
135	23	}
136	28	}
137	28	}
138
139		public function reload()
140		{
141		$this->_original = NULL;
		0 ignored issues – show Documentation Bug introduced 2015-11-24 23:50 UTC by Report Bug Copy Issue Report It seems like `NULL` of type `null` is incompatible with the declared type `array` of property `$_original`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
142		$this->_replace = FALSE;
143		return parent::reload();
144		}
145
146		/**
147		* Load an item from the database, based on a unique key
148		* @param string $key
149		* @return Jam_Model
150		*/
151	1	protected function _find_item($key)
152		{
153	1	return Jam::find($this->model(), $key);
		0 ignored issues – show Bug introduced 2015-11-24 23:50 UTC by Report Bug Copy Issue Report It seems like `$this->model()` targeting `Kohana_Jam_Array_Model::model()` can also be of type `this<Kohana_Jam_Array_Model>`; however, `Kohana_Jam::find()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
154		}
155
156		/**
157		* Convert an item from the $_content to a Jam_Model
158		* @param mixed $value
159		* @param boolean $is_changed
160		* @param int $offset
161		* @return Jam_Model
162		*/
163	20	protected function _load_item($value, $is_changed, $offset)
164		{
165	20	if ($value instanceof Jam_Model OR ! $value)
166	20	{
167	13	$item = $value;
168	13	}
169	13	elseif ( ! is_array($value))
170		{
171	1	$item = $this->_find_item($value);
172	1	}
173	13	elseif (is_array($value) AND $is_changed)
174		{
175	1	$key = $this->meta()->primary_key();
176	1	if (isset($value[$key]) AND $value[$key])
177	1	{
178	1	$item_key = is_array($value[$key]) ? reset($value[$key]) : $value[$key];
179
180	1	$model = $this->_find_item($item_key);
181	1	if ( ! $model)
182	1	{
183		$model = clone Jam::build_template($this->model(), $value);
184		}
185		else
186		{
187	1	unset($value[$key]);
188		}
189	1	}
190		else
191		{
192	1	$model = clone Jam::build_template($this->model(), $value);
193		}
194
195	1	$item = $model->set($value);
196	1	}
197		else
198		{
199	13	$item = clone Jam::build_template($this->model(), $value);
200	13	$item = $item->load_fields($value);
201		}
202
203	20	$this->_content[$offset] = $item;
204
205	20	return $item;
206		}
207
208		/**
209		* Find out the primary_key of an item of the $_content
210		* @param mixed $value
211		* @return int
212		*/
213	22	protected function _id($value)
214		{
215	22	if ($value instanceof Jam_Model)
216	22	return $value->id();
217
218	16	if (is_numeric($value))
219	16	return (int) $value;
220
221	14	if (is_string($value) AND $item = $this->_find_item($value))
222	14	return $item->id();
223
224	14	if (is_array($value) AND isset($value[$this->meta()->primary_key()]))
225	14	return (int) $value[$this->meta()->primary_key()];
226		}
227
228	16	public function search($item)
229		{
230	16	$search_id = $this->_id($item);
231
232	16	if ( ! $search_id)
233	16	return NULL;
234
235	11	$this->_load_content();
236
237	11	if ($this->_content)
		0 ignored issues – show Bug Best Practice introduced 2015-11-24 23:50 UTC by Report Bug Copy Issue Report The expression `$this->_content` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
238	11	{
239	11	foreach ($this->_content as $offset => $current)
240		{
241	11	if ($this->_id($current) === $search_id)
242	11	{
243	9	return (int) $offset;
244		}
245	8	}
246	4	}
247
248	5	return NULL;
249		}
250
251	12	public function as_array($key = NULL, $value = NULL)
252		{
253	12	$results = array();
254	12	$key = Jam_Query_Builder::resolve_meta_attribute($key, $this->meta());
255	12	$value = Jam_Query_Builder::resolve_meta_attribute($value, $this->meta());
256
257	12	foreach ($this as $i => $item)
258		{
259	9	$results[$key ? $item->$key : $i] = $value ? $item->$value : $item;
260	12	}
261
262	12	return $results;
263		}
264
265	7	public function ids()
266		{
267	7	$this->_load_content();
268
269	7	return $this->_content ? array_filter(array_map(array($this, '_id'), $this->_content)) : array();
270		}
271
272	7	public function load_fields(array $data)
273		{
274	7	$this->_content = $this->_original = $data;
275	7	return $this;
276		}
277
278		public function original()
279		{
280		return $this->_original;
281		}
282
283	2	public function original_ids()
284		{
285	2	$this->_load_content();
286
287	2	return $this->_original ? array_filter(array_map(array($this, '_id'), $this->_original)) : array();
288		}
289
290	4	public function has($item)
291		{
292	4	return $this->search($item) !== NULL;
293		}
294
295	9	public function set($items)
296		{
297	9	$this->_content = Jam_Array_Model::convert_collection_to_array($items);
298	9	$this->_changed = count($this->_content) ? array_fill(0, count($this->_content), TRUE) : array();
299	9	$this->_replace = TRUE;
300	9	$this->_removed = TRUE;
301
302	9	return $this;
303		}
304
305	8	public function add($items)
306		{
307	8	$items = Jam_Array_Model::convert_collection_to_array($items);
308
309	8	foreach ($items as $item)
310		{
311	8	$this->offsetSet($this->search($item), $item);
312	8	}
313
314	8	return $this;
315		}
316
317	6	public function remove($items)
318		{
319	6	$items = Jam_Array_Model::convert_collection_to_array($items);
320
321	6	foreach ($items as $item)
322		{
323	6	if (($offset = $this->search($item)) !== NULL)
324	6	{
325	5	$this->offsetUnset($offset);
326	5	}
327	6	}
328
329	6	return $this;
330		}
331
332		/**
333		* Build a new Jam Model, add it to the collection and return the newly built model
334		* @param array $values set values on the new model
335		* @return Jam_Model
336		*/
337	1	public function build(array $values = NULL)
338		{
339	1	$item = clone Jam::build_template($this->model(), $values);
340		if ($values)
341	1	{
342	1	$item->set($values);
343	1	}
344	1	$this->add($item);
345
346	1	return $item;
347		}
348
349		/**
350		* The same as build but saves the model in the database
351		* @param array $values
352		* @return Jam_Model
353		*/
354		public function create(array $values = NULL)
355		{
356		return $this->build($values)->save();
357		}
358
359	2	public function check_changed()
360		{
361	2	$check = TRUE;
362
363	2	foreach ($this->_changed as $offset => $is_changed)
364		{
365	2	$item = $this->offsetGet($offset);
366	2	if ($is_changed AND $item AND ! $item->check())
367	2	{
368	1	$check = FALSE;
369	1	}
370	2	}
371
372	2	return $check;
373		}
374
375	2	public function save_changed()
376		{
377	2	foreach ($this->_changed as $offset => $is_changed)
378		{
379	2	$item = $this->offsetGet($offset);
380	2	if ($is_changed AND $item AND ! $item->is_saving())
381	2	{
382	2	$item->save();
383	2	}
384	2	}
385
386	2	return $this;
387		}
388
389	1	public function clear()
390		{
391	1	$this->_changed =
392	1	$this->_original =
393	1	$this->_content = array();
394
395	1	return $this;
396		}
397
398	1	public function clear_changed()
399		{
400	1	$this->_changed = array();
401	1	$this->_original = $this->_content;
402
403	1	return $this;
404		}
405
406	16	public function __toString()
407		{
408	16	if ( ! $this->collection())
409	16	return 'Jam_Array ('.$this->model().')[NOT LOADED COLLECTION]';
410
411	16	return $this->collection()->__toString();
412		}
413
414	2	public function __call($method, $args)
415		{
416	2	if ( ! $this->collection())
417	2	throw new Kohana_Exception('Cannot call method :method on collection because collection not loaded for Jam_Array(:model)', array(':method' => $method, ':model' => $this->model()));
418
419	2	return call_user_func_array(array(clone $this->collection(), $method), $args);
420		}
421
422		/**
423		* Getter for the changed array - check if any or a particular item has been changed
424		* @param int $offset
425		* @return bool
426		*/
427	7	public function changed($offset = NULL)
428		{
429	7	if ($this->_content)
		0 ignored issues – show Bug Best Practice introduced 2015-11-24 23:50 UTC by Report Bug Copy Issue Report The expression `$this->_content` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
430	7	{
431	7	foreach ($this->_content as $key => $value)
432		{
433	7	if ( ! isset($this->_changed[$key]) AND $value instanceof Jam_Model AND $value->changed())
434	7	{
435	1	$this->_changed[$key] = TRUE;
436	1	}
437	7	}
438	7	}
439
440	7	return parent::changed($offset);
441		}
442
443	637	public function serialize()
444		{
445	637	$this->_load_content();
446
447
448	637	return serialize(array(
449	637	'original' => $this->_original,
450	637	'model' => $this->_model,
451	637	'replace' => $this->_replace,
452	637	'changed' => $this->_changed,
453	637	'content' => $this->_content,
454	637	'removed' => $this->_removed,
455	637	'current' => $this->_current,
456	637	));
457		}
458
459	637	public function unserialize($data)
460		{
461	637	$data = unserialize($data);
462
463	637	$this->_original = $data['original'];
464	637	$this->_model = $data['model'];
465	637	$this->_replace = $data['replace'];
466	637	$this->_changed = $data['changed'];
467	637	$this->_content = $data['content'];
468	637	$this->_removed = $data['removed'];
469	637	$this->_current = $data['current'];
470	637	}
471		}
472

OpenBuildings / jam

Push — count-subquery-clone ( d5815f...6cc328 )

Kohana_Jam_Array_Model D

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

31 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like