Completed
Pull Request — master (#17)
by Svetlozar
10:03 queued 08:40
created
classes/Kohana/Auth/Jam.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -102,7 +102,6 @@  discard block
 block discarded – undo
102 102
 	/**
103 103
 	 * Logs a user in.
104 104
 	 *
105
-	 * @param   string   $username  username
106 105
 	 * @param   string   $password  password
107 106
 	 * @param   boolean  $remember  enable autologin
108 107
 	 * @return  boolean
@@ -402,7 +401,7 @@  discard block
 block discarded – undo
402 401
 	 * session data: user_id, username, roles.
403 402
 	 *
404 403
 	 * @param   object  $user Jam object
405
-	 * @return  void
404
+	 * @return  boolean
406 405
 	 */
407 406
 	protected function complete_login($user)
408 407
 	{
Please login to merge, or discard this patch.
classes/Kohana/Auth/Service.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -183,12 +183,24 @@
 block discarded – undo
183 183
 
184 184
 	abstract public function service_login_complete();
185 185
 
186
+	/**
187
+	 * @param string $back_url
188
+	 *
189
+	 * @return string
190
+	 */
186 191
 	abstract public function login_url($back_url);
187 192
 
193
+	/**
194
+	 * @param Request $request
195
+	 * @param string $back_url
196
+	 */
188 197
 	abstract public function logout_service($request, $back_url);
189 198
 
190 199
 	abstract public function service_user_info();
191 200
 
201
+	/**
202
+	 * @return string|null
203
+	 */
192 204
 	abstract public function service_uid();
193 205
 
194 206
 }
Please login to merge, or discard this patch.
classes/Kohana/Jam/Field/Twitter.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,6 @@
 block discarded – undo
17 17
 	 *
18 18
 	 * @param  Jam_Model $model
19 19
 	 * @param  string $value
20
-	 * @param  boolean $loaded
21 20
 	 * @return string
22 21
 	 */
23 22
 	public function set(Jam_Validated $model, $value, $is_changed)
Please login to merge, or discard this patch.