MappersTests.test_map_locatie_elementen() - Code Metrics - Inspection of "Merge pull request #15 from OnroerendErfgoed/14_lo..." - OnroerendErfgoed/oe_geoutils - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0e2af0...ec5bb6 )

unknown

created 2017-02-28 08:17 UTC

MappersTests.test_map_locatie_elementen() D

↳ Parent: MappersTests

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	9
c	1
b	0
f	0
dl	0
loc	53
rs	4.9852

How to fix Long Method

import os
import unittest
import json

from pyramid.compat import text_
from pyramid.testing import DummyModel

from oe_geoutils.data.mappers import (
    _map_locatie,
    _map_locatie_elementen,
)

TEST_DIR = os.path.dirname(__file__)

with open(os.path.join(TEST_DIR, 'fixtures/locaties.json'), 'rb') as f:
    locaties_json = json.loads(text_(f.read()))


class MappersTests(unittest.TestCase):

    def setUp(self):
        self.model = DummyModel()

    def test_map_locatie(self):
        self.model = _map_locatie(locaties_json['locatie'], self.model)
        self.assertIsNotNone(self.model.contour)
        self.assertIsInstance(self.model.locatie_elementen, list)
        self.assertEqual(len(self.model.locatie_elementen), 4)

    def test_map_locatie_elementen(self):
        locatie_elementen = _map_locatie_elementen(locaties_json['locatie']['elementen'])
        self.assertIsInstance(locatie_elementen, list)
        self.assertEqual(len(locatie_elementen), 4)
        # Perceel
        obj = [el for el in locatie_elementen
               if el.type == 'https://id.erfgoed.net/vocab/ontology#LocatieElementPerceel'][0]
        self.assertEqual(obj.type, 'https://id.erfgoed.net/vocab/ontology#LocatieElementPerceel')
        self.assertEqual(obj.provincie_niscode, 20001)
        self.assertEqual(obj.provincie_naam, 'Vlaams-Brabant')
        self.assertEqual(obj.gemeente_niscode, 24062)
        self.assertEqual(obj.gemeente_naam, 'Leuven')
        self.assertEqual(obj.gemeente_crab_id, 143)
        self.assertEqual(obj.afdeling, 'LEUVEN  5 AFD')
        self.assertEqual(obj.sectie, 'F')
        self.assertEqual(obj.perceel, '0415/00F000')
        self.assertEqual(obj.capakey, '24505F0415/00F000')
        # Openbaar Domein
        obj = [el for el in locatie_elementen
               if el.type == 'https://id.erfgoed.net/vocab/ontology#LocatieElementOpenbaarDomein'][0]
        self.assertEqual(obj.type, 'https://id.erfgoed.net/vocab/ontology#LocatieElementOpenbaarDomein')
        self.assertEqual(obj.provincie_niscode, 20001)
        self.assertEqual(obj.provincie_naam, 'Vlaams-Brabant')
        self.assertEqual(obj.gemeente_niscode, 24062)
        self.assertEqual(obj.gemeente_naam, 'Leuven')
        self.assertEqual(obj.gemeente_crab_id, 143)
        self.assertEqual(obj.omschrijving, 'Universiteitsbibliotheek Leuven')
        # LocatieAdres
        obj = [el for el in locatie_elementen
               if el.type == 'https://id.erfgoed.net/vocab/ontology#LocatieElementAdres'][0]
        self.assertEqual(obj.type, 'https://id.erfgoed.net/vocab/ontology#LocatieElementAdres')
        self.assertEqual(obj.provincie_niscode, 20001)
        self.assertEqual(obj.provincie_naam, 'Vlaams-Brabant')
        self.assertEqual(obj.gemeente_niscode, 24062)
        self.assertEqual(obj.gemeente_naam, 'Leuven')
        self.assertEqual(obj.gemeente_crab_id, 143)
        self.assertEqual(obj.straat_id, 34819)
        self.assertEqual(obj.straat, 'Fonteinstraat')
        self.assertEqual(obj.huisnummer_id, 201984)
        self.assertEqual(obj.huisnummer, '75')
        self.assertEqual(obj.subadres_id, 2)
        self.assertEqual(obj.subadres, 'test2')
        self.assertEqual(obj.postcode, '3000')
        self.assertEqual(obj.land, 'BE')
        # LocatieElement
        obj = [el for el in locatie_elementen
               if el.type == 'https://id.erfgoed.net/vocab/ontology#LocatieElement'][0]
        self.assertEqual(obj.type, 'https://id.erfgoed.net/vocab/ontology#LocatieElement')
        self.assertEqual(obj.provincie_niscode, 20001)
        self.assertEqual(obj.provincie_naam, 'Vlaams-Brabant')
        self.assertEqual(obj.gemeente_niscode, 24062)
        self.assertEqual(obj.gemeente_naam, 'Leuven')
        self.assertEqual(obj.gemeente_crab_id, 143)


1			import os
2			import unittest
3			import json
4
5			from pyramid.compat import text_
6			from pyramid.testing import DummyModel
7
8			from oe_geoutils.data.mappers import (
9			_map_locatie,
10			_map_locatie_elementen,
11			)
12
13			TEST_DIR = os.path.dirname(__file__)
14
15			with open(os.path.join(TEST_DIR, 'fixtures/locaties.json'), 'rb') as f:
16			locaties_json = json.loads(text_(f.read()))
17
18
19			class MappersTests(unittest.TestCase):
20
21			def setUp(self):
22			self.model = DummyModel()
23
24			def test_map_locatie(self):
25			self.model = _map_locatie(locaties_json['locatie'], self.model)
26			self.assertIsNotNone(self.model.contour)
27			self.assertIsInstance(self.model.locatie_elementen, list)
28			self.assertEqual(len(self.model.locatie_elementen), 4)
29
30			def test_map_locatie_elementen(self):
31			locatie_elementen = _map_locatie_elementen(locaties_json['locatie']['elementen'])
32			self.assertIsInstance(locatie_elementen, list)
33			self.assertEqual(len(locatie_elementen), 4)
34			# Perceel
35			obj = [el for el in locatie_elementen
36			if el.type == 'https://id.erfgoed.net/vocab/ontology#LocatieElementPerceel'][0]
37			self.assertEqual(obj.type, 'https://id.erfgoed.net/vocab/ontology#LocatieElementPerceel')
38			self.assertEqual(obj.provincie_niscode, 20001)
39			self.assertEqual(obj.provincie_naam, 'Vlaams-Brabant')
40			self.assertEqual(obj.gemeente_niscode, 24062)
41			self.assertEqual(obj.gemeente_naam, 'Leuven')
42			self.assertEqual(obj.gemeente_crab_id, 143)
43			self.assertEqual(obj.afdeling, 'LEUVEN 5 AFD')
44			self.assertEqual(obj.sectie, 'F')
45			self.assertEqual(obj.perceel, '0415/00F000')
46			self.assertEqual(obj.capakey, '24505F0415/00F000')
47			# Openbaar Domein
48			obj = [el for el in locatie_elementen
49			if el.type == 'https://id.erfgoed.net/vocab/ontology#LocatieElementOpenbaarDomein'][0]
50			self.assertEqual(obj.type, 'https://id.erfgoed.net/vocab/ontology#LocatieElementOpenbaarDomein')
51			self.assertEqual(obj.provincie_niscode, 20001)
52			self.assertEqual(obj.provincie_naam, 'Vlaams-Brabant')
53			self.assertEqual(obj.gemeente_niscode, 24062)
54			self.assertEqual(obj.gemeente_naam, 'Leuven')
55			self.assertEqual(obj.gemeente_crab_id, 143)
56			self.assertEqual(obj.omschrijving, 'Universiteitsbibliotheek Leuven')
57			# LocatieAdres
58			obj = [el for el in locatie_elementen
59			if el.type == 'https://id.erfgoed.net/vocab/ontology#LocatieElementAdres'][0]
60			self.assertEqual(obj.type, 'https://id.erfgoed.net/vocab/ontology#LocatieElementAdres')
61			self.assertEqual(obj.provincie_niscode, 20001)
62			self.assertEqual(obj.provincie_naam, 'Vlaams-Brabant')
63			self.assertEqual(obj.gemeente_niscode, 24062)
64			self.assertEqual(obj.gemeente_naam, 'Leuven')
65			self.assertEqual(obj.gemeente_crab_id, 143)
66			self.assertEqual(obj.straat_id, 34819)
67			self.assertEqual(obj.straat, 'Fonteinstraat')
68			self.assertEqual(obj.huisnummer_id, 201984)
69			self.assertEqual(obj.huisnummer, '75')
70			self.assertEqual(obj.subadres_id, 2)
71			self.assertEqual(obj.subadres, 'test2')
72			self.assertEqual(obj.postcode, '3000')
73			self.assertEqual(obj.land, 'BE')
74			# LocatieElement
75			obj = [el for el in locatie_elementen
76			if el.type == 'https://id.erfgoed.net/vocab/ontology#LocatieElement'][0]
77			self.assertEqual(obj.type, 'https://id.erfgoed.net/vocab/ontology#LocatieElement')
78			self.assertEqual(obj.provincie_niscode, 20001)
79			self.assertEqual(obj.provincie_naam, 'Vlaams-Brabant')
80			self.assertEqual(obj.gemeente_niscode, 24062)
81			self.assertEqual(obj.gemeente_naam, 'Leuven')
82			self.assertEqual(obj.gemeente_crab_id, 143)
83

OnroerendErfgoed / oe_geoutils

Push — master ( 0e2af0...ec5bb6 )

MappersTests.test_map_locatie_elementen() D

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like