Total Complexity | 69 |
Total Lines | 148 |
Duplicated Lines | 0 % |
Complex classes like TestCapakeyGateway often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
1 | # -*- coding: utf-8 -*- |
||
30 | @pytest.mark.skipif( |
||
31 | not pytest.config.getoption('--capakey-integration'), |
||
32 | reason = 'No CAPAKEY Integration tests required' |
||
33 | ) |
||
34 | class TestCapakeyGateway: |
||
35 | |||
36 | def test_list_gemeenten(self, capakey_gateway): |
||
37 | res = capakey_gateway.list_gemeenten() |
||
38 | assert isinstance(res, list) |
||
39 | |||
40 | def test_list_gemeenten_invalid_auth(self): |
||
41 | capakey_gateway_client = capakey_factory( |
||
42 | user='USER', |
||
43 | password='PASSWORD' |
||
44 | ) |
||
45 | capakey_gateway = CapakeyGateway( |
||
46 | capakey_gateway_client |
||
47 | ) |
||
48 | from crabpy.gateway.exception import GatewayAuthenticationException |
||
49 | with pytest.raises(GatewayAuthenticationException): |
||
50 | capakey_gateway.list_gemeenten() |
||
51 | |||
52 | def test_get_gemeente_by_id(self, capakey_gateway): |
||
53 | res = capakey_gateway.get_gemeente_by_id(44021) |
||
54 | assert isinstance(res, Gemeente) |
||
55 | assert res.id == 44021 |
||
56 | |||
57 | def test_get_gemeente_by_invalid_id(self, capakey_gateway): |
||
58 | with pytest.raises(GatewayResourceNotFoundException): |
||
59 | capakey_gateway.get_gemeente_by_id('gent') |
||
60 | |||
61 | def test_list_afdelingen(self, capakey_gateway): |
||
62 | res = capakey_gateway.list_kadastrale_afdelingen() |
||
63 | assert isinstance(res, list) |
||
64 | assert len(res) > 300 |
||
65 | |||
66 | def test_list_afdelingen_by_gemeente(self, capakey_gateway): |
||
67 | g = capakey_gateway.get_gemeente_by_id(44021) |
||
68 | res = capakey_gateway.list_kadastrale_afdelingen_by_gemeente(g) |
||
69 | assert isinstance(res, list) |
||
70 | assert len(res) > 0 |
||
71 | assert len(res) < 40 |
||
72 | |||
73 | def test_list_afdelingen_by_unexisting_gemeente(self, capakey_gateway): |
||
74 | g = Gemeente(99999) |
||
75 | res = capakey_gateway.list_kadastrale_afdelingen_by_gemeente(g) |
||
76 | assert isinstance(res, list) |
||
77 | assert len(res) == 0 |
||
78 | |||
79 | def test_list_afdelingen_by_gemeente_id(self, capakey_gateway): |
||
80 | res = capakey_gateway.list_kadastrale_afdelingen_by_gemeente(44021) |
||
81 | assert isinstance(res, list) |
||
82 | assert len(res) > 0 |
||
83 | assert len(res) < 40 |
||
84 | |||
85 | def test_get_kadastrale_afdeling_by_id(self, capakey_gateway): |
||
86 | res = capakey_gateway.get_kadastrale_afdeling_by_id(44021) |
||
87 | assert isinstance(res, Afdeling) |
||
88 | assert res.id == 44021 |
||
89 | assert isinstance(res.gemeente, Gemeente) |
||
90 | assert res.gemeente.id == 44021 |
||
91 | |||
92 | def test_get_kadastrale_afdeling_by_unexisting_id(self, capakey_gateway): |
||
93 | with pytest.raises(GatewayResourceNotFoundException): |
||
94 | capakey_gateway.get_kadastrale_afdeling_by_id(44000) |
||
95 | |||
96 | def test_list_secties_by_afdeling(self, capakey_gateway): |
||
97 | a = capakey_gateway.get_kadastrale_afdeling_by_id(44021) |
||
98 | res = capakey_gateway.list_secties_by_afdeling(a) |
||
99 | assert isinstance(res, list) |
||
100 | assert len(res) == 1 |
||
101 | |||
102 | def test_list_secties_by_unexisting_afdeling(self, capakey_gateway): |
||
103 | a = Afdeling(99000) |
||
104 | res = capakey_gateway.list_secties_by_afdeling(a) |
||
105 | assert isinstance(res, list) |
||
106 | assert len(res) == 0 |
||
107 | |||
108 | def test_list_secties_by_afdeling_id(self, capakey_gateway): |
||
109 | res = capakey_gateway.list_secties_by_afdeling(44021) |
||
110 | assert isinstance(res, list) |
||
111 | assert len(res) == 1 |
||
112 | |||
113 | def test_get_sectie_by_id_and_afdeling(self, capakey_gateway): |
||
114 | a = capakey_gateway.get_kadastrale_afdeling_by_id(44021) |
||
115 | res = capakey_gateway.get_sectie_by_id_and_afdeling('A', a) |
||
116 | assert isinstance(res, Sectie) |
||
117 | assert res.id == 'A' |
||
118 | assert res.afdeling.id == 44021 |
||
119 | |||
120 | def test_get_sectie_by_unexisting_id_and_afdeling(self, capakey_gateway): |
||
121 | a = capakey_gateway.get_kadastrale_afdeling_by_id(44021) |
||
122 | with pytest.raises(GatewayResourceNotFoundException): |
||
123 | capakey_gateway.get_sectie_by_id_and_afdeling('Z', a) |
||
124 | |||
125 | def test_list_percelen_by_sectie(self, capakey_gateway): |
||
126 | s = capakey_gateway.get_sectie_by_id_and_afdeling('A', 44021) |
||
127 | res = capakey_gateway.list_percelen_by_sectie(s) |
||
128 | assert isinstance(res, list) |
||
129 | assert len(res) > 0 |
||
130 | |||
131 | def test_list_percelen_by_unexisting_sectie(self, capakey_gateway): |
||
132 | s = Sectie('Z', Afdeling(99000)) |
||
133 | res = capakey_gateway.list_percelen_by_sectie(s) |
||
134 | assert isinstance(res, list) |
||
135 | assert len(res) == 0 |
||
136 | |||
137 | def test_get_perceel_by_id_and_sectie(self, capakey_gateway): |
||
138 | s = capakey_gateway.get_sectie_by_id_and_afdeling('A', 44021) |
||
139 | percelen = capakey_gateway.list_percelen_by_sectie(s) |
||
140 | perc = percelen[0] |
||
141 | res = capakey_gateway.get_perceel_by_id_and_sectie(perc.id, s) |
||
142 | assert isinstance(res, Perceel) |
||
143 | assert res.sectie.id == 'A' |
||
144 | assert res.sectie.afdeling.id == 44021 |
||
145 | |||
146 | def test_get_perceel_by_unexisting_id_and_sectie(self, capakey_gateway): |
||
147 | s = capakey_gateway.get_sectie_by_id_and_afdeling('A', 44021) |
||
148 | percelen = capakey_gateway.list_percelen_by_sectie(s) |
||
149 | perc = percelen[0] |
||
150 | with pytest.raises(GatewayResourceNotFoundException): |
||
151 | capakey_gateway.get_perceel_by_id_and_sectie(-1, s) |
||
152 | |||
153 | def test_get_perceel_by_capakey(self, capakey_gateway): |
||
154 | s = capakey_gateway.get_sectie_by_id_and_afdeling('A', 44021) |
||
155 | percelen = capakey_gateway.list_percelen_by_sectie(s) |
||
156 | perc = percelen[0] |
||
157 | res = capakey_gateway.get_perceel_by_capakey(perc.capakey) |
||
158 | assert isinstance(res, Perceel) |
||
159 | assert res.sectie.id == 'A' |
||
160 | assert res.sectie.afdeling.id == 44021 |
||
161 | |||
162 | def test_get_perceel_by_unexisting_capakey(self, capakey_gateway): |
||
163 | with pytest.raises(GatewayResourceNotFoundException): |
||
164 | capakey_gateway.get_perceel_by_capakey('0000000') |
||
165 | |||
166 | def test_get_perceel_by_percid(self, capakey_gateway): |
||
167 | s = capakey_gateway.get_sectie_by_id_and_afdeling('A', 44021) |
||
168 | percelen = capakey_gateway.list_percelen_by_sectie(s) |
||
169 | perc = percelen[0] |
||
170 | res = capakey_gateway.get_perceel_by_percid(perc.percid) |
||
171 | assert isinstance(res, Perceel) |
||
172 | assert res.sectie.id == 'A' |
||
173 | assert res.sectie.afdeling.id == 44021 |
||
174 | |||
175 | def test_get_perceel_by_unexisting_percid(self, capakey_gateway): |
||
176 | with pytest.raises(GatewayResourceNotFoundException): |
||
177 | capakey_gateway.get_perceel_by_percid('0000/0000') |
||
178 | |||
451 |