NoteManager.js ➔ ... ➔ columns.note.renderCell - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/Onroer..." - OnroerendErfgoed/atramhasis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 96c8f8...621469 )

by Koen

created 2016-05-30 08:35 UTC

NoteManager.js ➔ ... ➔ columns.note.renderCell A

↳ Parent: NoteManager.js ➔ ... ➔ declare._createGrid

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	2
nc	2
nop	1

define([

  'dojo/_base/declare',
  'dojo/_base/array',
  'dojo/_base/lang',
  'dojo/dom-construct',
  'dojo/dom-class',
  'dojo/dom-style',
  'dojo/json',
  'dojo/on',
  'dojo/topic',
  'dijit/_WidgetBase',
  'dijit/_TemplatedMixin',
  'dojo/text!./templates/NoteManager.html',
  'dstore/Memory',
  'dstore/Trackable',
  'dgrid/OnDemandGrid',
  'dgrid/extensions/DijitRegistry',
  'dgrid/extensions/ColumnResizer',
  '../../utils/DomUtils',
  '../dialogs/NotesDialog'
], function (
  declare,
  array,
  lang,
  domConstruct,
  domClass,
  domStyle,
  JSON,
  on,
  topic,
  _WidgetBase,
  _TemplatedMixin,
  template,
  Memory,
  Trackable,
  OnDemandGrid,
  DijitRegistry,
  ColumnResizer,
  DomUtils,
  NotesDialog
) {
  return declare([_WidgetBase, _TemplatedMixin], {

    templateString: template,
    baseClass: 'note-manager',
    languageController: null,
    listController: null,
    concept: null,
    languageList: null,
    _noteStore: null,
    _noteGrid: null,
    _index: 0,

    postCreate: function () {
      this.inherited(arguments);
      console.debug('NoteManager::postCreate');

      this.trackableMemory = declare([Memory, Trackable]);
      this._noteStore = new this.trackableMemory({ data: [] });
      if (this.concept) {
        array.forEach(this.concept.notes, lang.hitch(this, function (item) {
          item.id = this._index++;
          this._noteStore.put(item);
        }));
      }
      this._createGrid({
        collection: this._noteStore
      }, this.noteGridNode);

      this._notesDialog = new NotesDialog({
        parentNode: this,
        langList: this.languageList,
        typeList: this.listController.getNoteTypes()
      });
      on(this._notesDialog, 'add.note', lang.hitch(this, function(evt) {
        this._doAddNote(evt);
      }));
      on(this._notesDialog, 'edit.note', lang.hitch(this, function(evt) {
        this._doEditNote(evt);
      }));
    },

    startup: function () {
      this.inherited(arguments);
      console.debug('NoteManager::startup');
      this._notesDialog.startup();
      this._noteGrid.startup();
      this._noteGrid.resize();
    },

    reset: function() {
      if (this._notesDialog) { this._notesDialog.reset(); }
      var TrackableMemory = declare([Memory, Trackable]);
      this._noteStore = new TrackableMemory({ data: [] });
      this._noteGrid.set('collection', this._noteStore);
    },

    _createGrid: function(options, node) {
      var columns = {
        note: {
          label: "Note",
          field: "note",
          renderCell: function(object) {
            if (object) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
              var div = domConstruct.create('div', {innerHTML: object.note});
              return div;
            }
          }
        },
        language: {
          label: "Language",
          field: "language",
          formatter: lang.hitch(this, function (value) {
            var lang = array.filter(this.languageList, function (obj) {
              return obj.id === value;
            })[0];
            if (lang) {
              return lang.name;
            } else {
              return '-';
            }
          })
        },
        type: {
          label: "Type",
          field: "type",
          formatter: lang.hitch(this, function (value) {
            var lang = array.filter(this.listController.getNoteTypes(), function (obj) {
              return obj.value === value;
            })[0];
            return lang.label;
          })
        },
        actions: {
          label: '',
          renderCell: lang.hitch(this, function (object) {
            if (object.id === undefined) {
              return null;
            }
            var div = domConstruct.create('div', {'class': 'dGridHyperlink'});
            domConstruct.create('a', {
              href: '#',
              title: 'Edit note',
              className: 'fa fa-pencil',
              innerHTML: '',
              style: 'margin-right: 12px;',
              onclick: lang.hitch(this, function (evt) {
                evt.preventDefault();
                this._editNote(object);
              })
            }, div);
            domConstruct.create('a', {
              href: '#',
              title: 'Remove note',
              className: 'fa fa-trash',
              innerHTML: '',
              onclick: lang.hitch(this, function (evt) {
                evt.preventDefault();
                this._removeRow(object.id);
              })
            }, div);
            return div;
          })
        }
      };

      var grid = new (declare([OnDemandGrid, DijitRegistry, ColumnResizer]))({
        collection: options.collection,
        columns: columns,
        showHeader: false,
        noDataMessage: 'No notes found',
        loadingMessage: 'Fetching data..'
      }, node);

      this._noteGrid = grid;

      grid.on('dgrid-error', function(event) {
        console.log(event.error.message);

      });
    },

    getData: function() {
      var notes = {
        notes: this._noteStore.data
      }
      return notes;
    },

    setConcept: function(concept) {
      if (concept) {
        this.concept = concept;
        this._noteStore = new this.trackableMemory({ data: [] });
        array.forEach(this.concept.notes, lang.hitch(this, function (item) {
          item.id = this._index++;
          this._noteStore.put(item);
        }));
        this._noteGrid.set('collection', this._noteStore);
      }
    },

    updateLanguages: function(languages) {
      if (languages) {
        this.languageList = languages;
        this._notesDialog.updateLanguages(languages);
      }
    },

    _addNote: function(evt) {
      evt ? evt.preventDefault() : null;
      this._notesDialog.show();
    },

    _editNote: function(note) {
      this._notesDialog.show(note);
    },

    _doAddNote: function(note) {
      var newNote = {
        language: note.lang,
        type: note.noteType,
        note: note.note
      };
      console.log(newNote);

      this._noteStore.add(newNote);
    },

    _doEditNote: function(note) {
      var editNote = {
        language: note.lang,
        type: note.noteType,
        note: note.note,
        id: note.id
      };
      console.log(editNote);

      this._noteStore.put(editNote);
    },

    _removeRow: function(rowId) {
      this._noteStore.remove(rowId);
    }
  });
});

1			define([
			0 ignored issues – show Duplication introduced 2016-05-24 13:27 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
2			'dojo/_base/declare',
3			'dojo/_base/array',
4			'dojo/_base/lang',
5			'dojo/dom-construct',
6			'dojo/dom-class',
7			'dojo/dom-style',
8			'dojo/json',
9			'dojo/on',
10			'dojo/topic',
11			'dijit/_WidgetBase',
12			'dijit/_TemplatedMixin',
13			'dojo/text!./templates/NoteManager.html',
14			'dstore/Memory',
15			'dstore/Trackable',
16			'dgrid/OnDemandGrid',
17			'dgrid/extensions/DijitRegistry',
18			'dgrid/extensions/ColumnResizer',
19			'../../utils/DomUtils',
20			'../dialogs/NotesDialog'
21			], function (
22			declare,
23			array,
24			lang,
25			domConstruct,
26			domClass,
27			domStyle,
28			JSON,
29			on,
30			topic,
31			_WidgetBase,
32			_TemplatedMixin,
33			template,
34			Memory,
35			Trackable,
36			OnDemandGrid,
37			DijitRegistry,
38			ColumnResizer,
39			DomUtils,
40			NotesDialog
41			) {
42			return declare([_WidgetBase, _TemplatedMixin], {
43
44			templateString: template,
45			baseClass: 'note-manager',
46			languageController: null,
47			listController: null,
48			concept: null,
49			languageList: null,
50			_noteStore: null,
51			_noteGrid: null,
52			_index: 0,
53
54			postCreate: function () {
55			this.inherited(arguments);
56			console.debug('NoteManager::postCreate');
57
58			this.trackableMemory = declare([Memory, Trackable]);
59			this._noteStore = new this.trackableMemory({ data: [] });
60			if (this.concept) {
61			array.forEach(this.concept.notes, lang.hitch(this, function (item) {
62			item.id = this._index++;
63			this._noteStore.put(item);
64			}));
65			}
66			this._createGrid({
67			collection: this._noteStore
68			}, this.noteGridNode);
69
70			this._notesDialog = new NotesDialog({
71			parentNode: this,
72			langList: this.languageList,
73			typeList: this.listController.getNoteTypes()
74			});
75			on(this._notesDialog, 'add.note', lang.hitch(this, function(evt) {
76			this._doAddNote(evt);
77			}));
78			on(this._notesDialog, 'edit.note', lang.hitch(this, function(evt) {
79			this._doEditNote(evt);
80			}));
81			},
82
83			startup: function () {
84			this.inherited(arguments);
85			console.debug('NoteManager::startup');
86			this._notesDialog.startup();
87			this._noteGrid.startup();
88			this._noteGrid.resize();
89			},
90
91			reset: function() {
92			if (this._notesDialog) { this._notesDialog.reset(); }
93			var TrackableMemory = declare([Memory, Trackable]);
94			this._noteStore = new TrackableMemory({ data: [] });
95			this._noteGrid.set('collection', this._noteStore);
96			},
97
98			_createGrid: function(options, node) {
99			var columns = {
100			note: {
101			label: "Note",
102			field: "note",
103			renderCell: function(object) {
104			if (object) {
			0 ignored issues – show Complexity Best Practice introduced 2016-05-30 08:27 UTC by Report Bug Copy Issue Report There is no return statement if `object` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
105			var div = domConstruct.create('div', {innerHTML: object.note});
106			return div;
107			}
108			}
109			},
110			language: {
111			label: "Language",
112			field: "language",
113			formatter: lang.hitch(this, function (value) {
114			var lang = array.filter(this.languageList, function (obj) {
115			return obj.id === value;
116			})[0];
117			if (lang) {
118			return lang.name;
119			} else {
120			return '-';
121			}
122			})
123			},
124			type: {
125			label: "Type",
126			field: "type",
127			formatter: lang.hitch(this, function (value) {
128			var lang = array.filter(this.listController.getNoteTypes(), function (obj) {
129			return obj.value === value;
130			})[0];
131			return lang.label;
132			})
133			},
134			actions: {
135			label: '',
136			renderCell: lang.hitch(this, function (object) {
137			if (object.id === undefined) {
138			return null;
139			}
140			var div = domConstruct.create('div', {'class': 'dGridHyperlink'});
141			domConstruct.create('a', {
142			href: '#',
143			title: 'Edit note',
144			className: 'fa fa-pencil',
145			innerHTML: '',
146			style: 'margin-right: 12px;',
147			onclick: lang.hitch(this, function (evt) {
148			evt.preventDefault();
149			this._editNote(object);
150			})
151			}, div);
152			domConstruct.create('a', {
153			href: '#',
154			title: 'Remove note',
155			className: 'fa fa-trash',
156			innerHTML: '',
157			onclick: lang.hitch(this, function (evt) {
158			evt.preventDefault();
159			this._removeRow(object.id);
160			})
161			}, div);
162			return div;
163			})
164			}
165			};
166
167			var grid = new (declare([OnDemandGrid, DijitRegistry, ColumnResizer]))({
168			collection: options.collection,
169			columns: columns,
170			showHeader: false,
171			noDataMessage: 'No notes found',
172			loadingMessage: 'Fetching data..'
173			}, node);
174
175			this._noteGrid = grid;
176
177			grid.on('dgrid-error', function(event) {
178			console.log(event.error.message);
			0 ignored issues – show Debugging Code introduced 2016-05-24 13:27 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
179			});
180			},
181
182			getData: function() {
183			var notes = {
184			notes: this._noteStore.data
185			}
186			return notes;
187			},
188
189			setConcept: function(concept) {
190			if (concept) {
191			this.concept = concept;
192			this._noteStore = new this.trackableMemory({ data: [] });
193			array.forEach(this.concept.notes, lang.hitch(this, function (item) {
194			item.id = this._index++;
195			this._noteStore.put(item);
196			}));
197			this._noteGrid.set('collection', this._noteStore);
198			}
199			},
200
201			updateLanguages: function(languages) {
202			if (languages) {
203			this.languageList = languages;
204			this._notesDialog.updateLanguages(languages);
205			}
206			},
207
208			_addNote: function(evt) {
209			evt ? evt.preventDefault() : null;
210			this._notesDialog.show();
211			},
212
213			_editNote: function(note) {
214			this._notesDialog.show(note);
215			},
216
217			_doAddNote: function(note) {
218			var newNote = {
219			language: note.lang,
220			type: note.noteType,
221			note: note.note
222			};
223			console.log(newNote);
			0 ignored issues – show Debugging Code introduced 2016-05-24 13:27 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
224			this._noteStore.add(newNote);
225			},
226
227			_doEditNote: function(note) {
228			var editNote = {
229			language: note.lang,
230			type: note.noteType,
231			note: note.note,
232			id: note.id
233			};
234			console.log(editNote);
			0 ignored issues – show Debugging Code introduced 2016-05-24 13:27 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
235			this._noteStore.put(editNote);
236			},
237
238			_removeRow: function(rowId) {
239			this._noteStore.remove(rowId);
240			}
241			});
242			});

OnroerendErfgoed / atramhasis

Push — master ( 96c8f8...621469 )

NoteManager.js ➔ ... ➔ columns.note.renderCell A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like