AuthClient - Code Metrics - Onend/paypal-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

AuthClient A
last analyzed 2020-05-06 10:39 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	2
lcom	1
cbo	4
dl	0
loc	49
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setCredentials()	0	4	1
A	auth()	0	18	1

<?php

namespace Onend\PayPal\Common\Auth;

use Onend\PayPal\Common\Client\AbstractClient;
use Onend\PayPal\Common\Enum\Endpoint;
use Onend\PayPal\Common\Enum\RequestFormat;

class AuthClient extends AbstractClient
{
    /**
     * Request timeout
     * Bad Gateway
     * Service Unavailable
     * Gateway timeout
     *
     * @var array
     */
    protected static $retryCodes = [408, 502, 503, 504];

    /**
     * @var Credentials
     */
    protected $credentials;

    /**
     * @param Credentials $credentials
     */
    public function setCredentials(Credentials $credentials)
    {
        $this->credentials = $credentials;
    }

    /**
     * @throws \Guzzle\Common\Exception\InvalidArgumentException
     * @throws \Exception
     * @return AuthResponse
     */
    public function auth()
    {
        $request = $this->post(
            $this->getBaseUrl() . Endpoint::OAUTH_TOKEN,
            ["Accept" => "application/json", "Accept-Language" => "en_US"],
            ["grant_type" => "client_credentials"]
        );
        $request->setAuth($this->credentials->getClientId(), $this->credentials->getSecret());

        $response = parent::send($request);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

        // todo retry if status code in self::$retryCode
        return $this->getSerializer()->deserialize(
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            $response->getBody(true),
            'Onend\PayPal\Common\Auth\AuthResponse',
            RequestFormat::JSON
        );
    }
}


1			<?php
2
3			namespace Onend\PayPal\Common\Auth;
4
5			use Onend\PayPal\Common\Client\AbstractClient;
6			use Onend\PayPal\Common\Enum\Endpoint;
7			use Onend\PayPal\Common\Enum\RequestFormat;
8
9			class AuthClient extends AbstractClient
10			{
11			/**
12			* Request timeout
13			* Bad Gateway
14			* Service Unavailable
15			* Gateway timeout
16			*
17			* @var array
18			*/
19			protected static $retryCodes = [408, 502, 503, 504];
20
21			/**
22			* @var Credentials
23			*/
24			protected $credentials;
25
26			/**
27			* @param Credentials $credentials
28			*/
29			public function setCredentials(Credentials $credentials)
30			{
31			$this->credentials = $credentials;
32			}
33
34			/**
35			* @throws \Guzzle\Common\Exception\InvalidArgumentException
36			* @throws \Exception
37			* @return AuthResponse
38			*/
39			public function auth()
40			{
41			$request = $this->post(
42			$this->getBaseUrl() . Endpoint::OAUTH_TOKEN,
43			["Accept" => "application/json", "Accept-Language" => "en_US"],
44			["grant_type" => "client_credentials"]
45			);
46			$request->setAuth($this->credentials->getClientId(), $this->credentials->getSecret());
47
48			$response = parent::send($request);
			0 ignored issues – show Comprehensibility Bug introduced 2020-05-06 10:39 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`send()` instead of `auth()`). Are you sure this is correct? If so, you might want to change this to `$this->send()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
49
50			// todo retry if status code in self::$retryCode
51			return $this->getSerializer()->deserialize(
			0 ignored issues – show Bug Best Practice introduced 2020-05-06 10:39 UTC by Report Bug Copy Issue Report The return type of `return $this->getSeriali...m\RequestFormat::JSON);` (`object\|array\|integer\|double\|string\|boolean`) is incompatible with the return type documented by `Onend\PayPal\Common\Auth\AuthClient::auth` of type `Onend\PayPal\Common\Auth\AuthResponse`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
52			$response->getBody(true),
53			'Onend\PayPal\Common\Auth\AuthResponse',
54			RequestFormat::JSON
55			);
56			}
57			}
58

Onend / paypal-sdk-php

GitHub Access Token became invalid

AuthClient A last analyzed 2020-05-06 10:39 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

AuthClient A
last analyzed 2020-05-06 10:39 UTC